Wallet - Make default payment method option uses a message icon instead of star icon

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.80-3
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: #52322
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: User Settings

Action Performed:

Precondition:

• Account has two personal bank accounts.

1. Go to staging.new.expensify.com
2. Go to Account settings > Wallet.
3. Click on the non-default bank account.

Expected Result:

Make default payment method option uses a star icon (according to this doc https://docs.google.com/document/d/1H1hMnTcMrR8MT6BXz3fCE99eVIurgrHDtaxIH5aW8Ug/edit?tab=t.0)

Actual Result:

Make default payment method option uses a message icon instead of star icon.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6704997_1735809214614.20250102_163155.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[linhvovan29546]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Make default payment method option uses a message icon instead of star icon.

What is the root cause of that problem?

In the wallet page, we useMail icon for "Make default payment method" button

What changes do you think we should make in order to solve the problem?

We need to update Mail icon to Star icon here

from

App/src/pages/settings/Wallet/WalletPage/WalletPage.tsx

Lines 580 to 583 in 629220d

	{shouldShowMakeDefaultButton && (
	<MenuItem
	title={translate('walletPage.setDefaultConfirmation')}
	icon={Expensicons.Mail}

to

  <MenuItem
   title={translate('walletPage.setDefaultConfirmation')}
    icon={Expensicons.Star}

We can also consider updating here as well.

POC

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

No, it only UI

What alternative solutions did you explore? (Optional)

N/A

[github-actions]

Haochensong Your proposal will be dismissed because you did not follow the proposal template.

[nkdengineer]

I think this will be fixed here.

[melvin-bot]

@anmurali Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!