[$250] Trip- No option to copy Modify trip or Trip support external link when right-click on the link

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.78-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Windows 11
App Component: Money Requests

Action Performed:

Precondition:

• Create a trip with steps from this PR [vip-travel] Create Trip Details Screen #52823

1. Go to staging.new.expensify.com
2. Go to Account settings.
3. Right click on any option that will open external website (Domains, Help, View the code).
4. Note that it shows option to copy the external link.
5. Go to Trip room.
6. Go to Trip thread.
7. Click View trip details.
8. Right click on Modify trip or Trip support button.

Expected Result:

There should be an option to copy Modify trip or Trip support external link when right-click on the button.

Actual Result:

There is no option to copy Modify trip or Trip support external link when right-click on the button.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6701804_1735047593465.bandicam_2024-12-24_21-34-11-875.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021873741980414961550
• Upwork Job ID: 1873741980414961550
• Last Price Increase: 2024-12-30

Issue Owner

Current Issue Owner: @paultsimura

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @thienlnam (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @neil-marcellini (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[Shahidullah-Muffakir]

Edited by proposal-police: This proposal was edited at 2024-12-24 22:24:28 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

No option to copy Modify trip or Trip support external link when right-click on the link

What is the root cause of that problem?

The onSecondaryInteraction is not added in the TripDetailsPage, like it is added in the About and other pages for links.

What changes do you think we should make in order to solve the problem?

We can add the onSecondaryInteraction prop to the MenuItem here in the TripDetailsPage :

App/src/pages/Travel/TripDetailsPage.tsx

Lines 123 to 124 in ad99c20

	<MenuItem
	title={translate('travel.tripSupport')}

as:

                      <MenuItem
                        title={translate('travel.tripSupport')}
                        ref={popoverAnchor}
                        onSecondaryInteraction={(e) => ReportActionContextMenu.showContextMenu(CONST.CONTEXT_MENU_TYPES.LINK, e, CONST.TRAVEL_DOT_URL, popoverAnchor.current)}

and also for modifyTrip

we can invoke the buildTravelDotURL to return the exact URL instead of using hardcoded CONST.TRAVEL_DOT_URL

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

[melvin-bot]

@thienlnam, @bfitzexpensify Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021873741980414961550

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @paultsimura (External)

[mkzie2]

I don't think it's a bug because the TRAVEL_DOT_URL requires the token and it doesn't make sense to display the copy with URL is TRAVEL_DOT_URL (it's not the same with the correct URL) or using buildTravelDotURL (this will call the API to request the sort live token that can be outdated quickly).

[paultsimura]

@thienlnam @bfitzexpensify do we want to enable the right-click + copy functionality for these links?

[bfitzexpensify]

Hm, yeah, after reviewing this, I'm not sure what the purpose would be of that flow. Closing this out.