[$250] Reports - The "Travel and expense..." modal is not displayed

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.76-6
Reproducible in staging?: Yes
Reproducible in production?: Yes
Issue was found when executing this PR: #54065
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: Windows 10/ Chrome, Samsung S23FE/ Android 14
App Component: Search

Action Performed:

1. Sign into an account in OldDot
2. Set the nudgeMigration nvp in the JS console by doing: SSetNameValuePair('tryNewDot', {clasicRedirect: {dismissed: false}, nudgeMigration: "2024-12-12"} );
3. Sign into the same account on NewDot
4. Make sure you see the "Travel and expense, at the speed of chat" modal
5. Make sure that after clicking/tapping "Let's go" that you are on the Search/Reports page

Expected Result:

The "Travel and expense, at the speed of chat" modal is displayed, and after clicking/tapping "Let's go" the user is on the Reports page.

Actual Result:

The "Travel and expense, at the speed of chat" modal is not displayed and the user lands on Inbox as usual.

Hybrid Android behavior: After completing steps 1 and 2, the app redirects to OD. Before running the snippet, the app was redirected to ND.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6694056_1734154378425.54065-Android.mp4

Bug6694056_1734154378433.No_modal.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021868478624829865820
• Upwork Job ID: 1868478624829865820
• Last Price Increase: 2024-12-16

Issue Owner

Current Issue Owner: @dukenv0307

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021868478624829865820

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 (External)

[mkzie2]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The "Travel and expense, at the speed of chat" modal is not displayed and the user lands on Inbox as usual.

What is the root cause of that problem?

The type of nudgeMigration is an object with timestamp field as a date string. But in the test nudgeMigration is a string.

App/src/libs/onboardingSelectors.ts

Lines 32 to 35 in 653af04

	function tryNewDotOnyxSelector(tryNewDotData: OnyxValue<typeof ONYXKEYS.NVP_TRYNEWDOT>): {isHybridAppOnboardingCompleted: boolean | undefined; hasBeenAddedToNudgeMigration: boolean} {
	let isHybridAppOnboardingCompleted = tryNewDotData?.classicRedirect?.completedHybridAppOnboarding;
	const hasBeenAddedToNudgeMigration = !!tryNewDotData?.nudgeMigration?.timestamp;

App/src/types/onyx/TryNewDot.ts

Lines 26 to 29 in 653af04

	nudgeMigration: {
	/** Indicates timestamp of an action. */
	timestamp: Date;
	};

What changes do you think we should make in order to solve the problem?

1. If nudgeMigration is a string, we should update type here and replace all using of tryNewDotData?.nudgeMigration?.timestamp to tryNewDotData?.nudgeMigration.

2. If not, we can update the test and close this issue.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[mkzie2]

@puneetlath Can you please confirm what is the correct?

1. In this PR, you added the test step with nudgeMigration as a string.

2. In the current code, nudgeMigration is an object.

[puneetlath]

My apologies. It's an object. With the key timestamp inside it.

[mkzie2]

My apologies. It's an object. With the key timestamp inside it.

@puneetlath Based on this we can close this issue

[dukenv0307]

@puneetlath Let's close this issue