Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A migrated user should land on the Search page the very first session when they are nudged over to newdot #53792

Closed
8 tasks
flaviadefaria opened this issue Dec 9, 2024 · 10 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Reviewing Has a PR in review

Comments

@flaviadefaria
Copy link
Contributor

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: NA
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: NA
If this was caught during regression testing, add the test name, ID and link from TestRail: NA
Email or phone of affected tester (no customers): [email protected]
Logs: NA
Expensify/Expensify Issue URL: NA
Issue reported by: @flaviadefaria
Slack conversation (hyperlinked to channel name): https://expensify.slack.com/archives/C07NMDKEFMH/p1733514796643789

Action Performed:

  1. Migrate a user
  2. Sign in after the user has been migrated

Expected Result:

The migrated user should land on the Search page the very first session when they are nudged over to newdot

Actual Result:

The user lands on the Inbox page

Workaround:

NA

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

@flaviadefaria flaviadefaria added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Dec 9, 2024
@flaviadefaria flaviadefaria moved this to First Cohort - CRITICAL in [#whatsnext] #migrate Dec 9, 2024
Copy link

melvin-bot bot commented Dec 9, 2024

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Dec 20, 2024

@puneetlath, @ZhenjaHorbach Whoops! This issue is 2 days overdue. Let's get this updated quick!

@flaviadefaria
Copy link
Contributor Author

@puneetlath can we close this?

@ZhenjaHorbach
Copy link
Contributor

ZhenjaHorbach commented Dec 23, 2024

I hope that payment will still be required here on December 25th because I reviewed this PR 😅
And I will fill out the bugZero checklist by December 25th if required !

@flaviadefaria
Copy link
Contributor Author

Oh my bad, @ZhenjaHorbach, for sure payment will still be issued for you.

@ZhenjaHorbach
Copy link
Contributor

ZhenjaHorbach commented Dec 27, 2024

BugZero Checklist:

  • [Contributor] Classify the bug:
Bug classification

Source of bug:

  • 1a. Result of the original design (eg. a case wasn't considered)
  • 1b. Mistake during implementation
  • 1c. Backend bug
  • 1z. Other:

Where bug was reported:

  • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
  • 2b. Reported on staging (eg. found during regression or PR testing)
  • 2d. Reported on a PR
  • 2z. Other:

Who reported the bug:

  • 3a. Expensify user
  • 3b. Expensify employee
  • 3c. Contributor
  • 3d. QA
  • 3z. Other:
  • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

    This is a part of a project
    But if I understand correctly this case wasn't considered in the previous PR

  • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

    Link to discussion: NA

  • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

I'm not sure regression test is needed here since tests will be added as part of the project wrap-up

But if tests are required:

Test:

  1. In newdot Sign in with a account thats been added to nudge migration from Olddot
  2. Verify user lands on search page after sign in and a welcome modal appears.
  3. Click on "Lets go!" greeen button in modal verify it dismisses the modal and you are on Search page

Do we agree 👍 or 👎

@ZhenjaHorbach
Copy link
Contributor

@puneetlath
Can we please continue the payment process?

@puneetlath
Copy link
Contributor

Sent upwork offer here. @ZhenjaHorbach can you ping me on this issue when you've accepted?

@ZhenjaHorbach
Copy link
Contributor

Sent upwork offer here. @ZhenjaHorbach can you ping me on this issue when you've accepted?

@puneetlath
I accepted !
Thanks !

@puneetlath
Copy link
Contributor

All paid. Thanks!

@github-project-automation github-project-automation bot moved this from First Cohort - CRITICAL to Done in [#whatsnext] #migrate Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Reviewing Has a PR in review
Projects
Development

No branches or pull requests

4 participants