[C+ Checklist Needs Completion] [$250] IOS - Avatar doesn't get back to its original center position after zooming in and out

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.70-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5291133
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Action Performed:

1. Open hybrid app
2. Upload a custom avatar for your profile
3. Open your self DM
4. Open the avatar to show in full screen
5. Pinch out to zoom and without releasing our finger pinch in to zoom out and position your fingers to the corner while zooming out and release your fingers

Expected Result:

The position of the avatar gets back to its original center position

Actual Result:

The avatar stays at the position it was released on and doesn't get back to the center

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6683084_1733231204767.ScreenRecording_12-03-2024_15-58-36_1.1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021863989062279850488
• Upwork Job ID: 1863989062279850488
• Last Price Increase: 2025-02-03
• Automatic offers:
• dominictb | Contributor | 106011607

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021863989062279850488

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

[melvin-bot]

Upwork job price has been updated to $125

[ahmedkhan28]

Hi! I came across your job posting on Upwork regarding the avatar centering issue in your iOS app. After analyzing the problem where the avatar doesn't return to center after zoom gestures, I believe this can be fixed effectively through iterative solutions. I am a full time full stack iOS developer, designer and game developer at MagicHabits. This can be fixed in max 1-2 days.

Based on my experience with iOS gesture handling and UI animations, I've identified 5 potential approaches that could solve this:

Spring Animation Reset

swiftCopyUIView.animate(withSpringDamping: 0.8) {
avatarImageView.center = view.center
}

Velocity-Based Repositioning

swiftCopylet velocity = gesture.velocity(in: view)
let newCenter = calculatePosition(from: velocity)
animateToPosition(newCenter)

Smart Edge Detection

swiftCopyif !safeBounds.contains(avatar.frame) {
returnToCenter(animated: true)
}

Progressive Center Force

swiftCopylet centerForce = 1 - currentScale
let newCenter = interpolate(current: position,
target: center,
force: centerForce)

Physics-Based Boundaries

swiftCopylet behavior = UIAttachmentBehavior(item: avatarImageView)
animator.addBehavior(behavior)
Most natural but complex implementation
Recommended Approach:

I suggest implementing Solution #1 (Spring Animation Reset) first, then enhancing it with elements of Solution #4 (Progressive Center Force). This combination would:

Provide immediate improvement in UX
Feel natural and iOS-native
Be quick to implement and test
Allow for easy tuning of behavior

Let me know if you like it so I can submit a proposal on upwork!

[melvin-bot]

📣 @ahmedkhan28! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[ahmedkhan28]

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: www.upwork.com/agencies/1838604427293852717

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[JoshIri360]

Edited by proposal-police: This proposal was edited at 2024-12-20 10:33:27 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Avatar doesn't get back to its original center position after zooming in and out

What is the root cause of that problem?

The root cause of this problem is that recentering the avatar is only done if the zoom scale is less than the minimum zoom scale or more than the maximum zoom scale.

When zoomed past the minimum zoom, it recenters and adjusts the zoom:

overzoomed.mp4

When zoomed past the maximum zoom, it does the same (may be difficult to see here)

output.mp4

If it's not a maximum or minimum zoom, there is no recenter, this allows the user move the avatar in any direction without it recentering

Recording.at.2024-12-20.11.06.43.mp4

The line of code that helps the zoom recenter after minimum or maximum zoom can be found here:

App/src/components/MultiGestureCanvas/usePinchGesture.ts

Lines 164 to 168 in 207622d

	// If the content was "overzoomed" or "underzoomed", we need to bounce back with an animation
	if (pinchBounceTranslateX.get() !== 0 || pinchBounceTranslateY.get() !== 0) {
	pinchBounceTranslateX.set(withSpring(0, SPRING_CONFIG));
	pinchBounceTranslateY.set(withSpring(0, SPRING_CONFIG));
	}

What changes do you think we should make in order to solve the problem?

We should modify the onEnd handler to reset the position to center when the gesture ends, if it's not overzoomed or underzoomed. This ensures the avatar maintains its expected centered position after any pinch interaction.

The logic should be added in the else block where we handle normal zoom levels:

zoom scale, we need to set the zoom scale to the maximum
        pinchScale.set(zoomRange.max);
        zoomScale.set(withSpring(zoomRange.max, SPRING_CONFIG, triggerScaleChangedEvent));
    } else {
+         // Ensure image is centered
+         offsetX.set(withSpring(0, SPRING_CONFIG));
+         offsetY.set(withSpring(0, SPRING_CONFIG));
    
        // Otherwise, we just update the pinch scale offset
        pinchScale.set(zoomScale.get());
        triggerScaleChangedEvent();
    }
});

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A, It's a UI issue

What alternative solutions did you explore? (Optional)

N/A

Result

compressednormalxoom.mp4

[melvin-bot]

📣 @JoshIri360! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[JoshIri360]

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~018bc4a19179469daa

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[ahmedkhan28]

Submitted the proposal just now, thank you!

[greg-schroeder]

Next up is proposal review

[melvin-bot]

@greg-schroeder, @abdulrahuman5196 Huh... This is 4 days overdue. Who can take care of this?

[ahmedkhan28]

We had to have a contract before me solving it, right?

…

On Mon, 9 Dec 2024 at 2:42 PM, melvin-bot[bot] ***@***.***> wrote: @greg-schroeder <https://github.com/greg-schroeder>, @abdulrahuman5196 <https://github.com/abdulrahuman5196> Huh... This is 4 days overdue. Who can take care of this? — Reply to this email directly, view it on GitHub <#53471 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BACMSUPE6HB5SRTCJIZO6OL2EVQXXAVCNFSM6AAAAABS54WRMOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMRXGQYTKMZZG4> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[abdulrahuman5196]

Hi, will review today

[greg-schroeder]

Thanks @abdulrahuman5196

[abdulrahuman5196]

@ahmedkhan28 / @JoshIri360 Kindly follow the proposal template for suggesting solutions as mentioned here https://github.com/Expensify/App/blob/main/contributingGuides/CONTRIBUTING.md#propose-a-solution-for-the-job

And on another not @JoshIri360 I tried your solution and its not fixing the issue. I am still able to repro the issue with your solution.

[abdulrahuman5196]

No pending proposal to review or approve yet

[greg-schroeder]

Friendly bump @dominictb

[dominictb]

on it now

[dominictb]

Thanks for all your proposals. I think @bernhardoj's solution makes more sense, I only can understand the RCA after reading his proposal. I think we can use worklet, but I need more time to verify the solution. I'll give the final update in 1 hour

[dominictb]

@bernhardoj's proposal looks good to me. Using worklet seems to be fine, and works well

🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @francoisl, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[bernhardoj]

PR is ready

cc: @dominictb

[greg-schroeder]

Deployed to prod 2025-02-17

[greg-schroeder]

Will process today

[greg-schroeder]

Payment summary:

Contributor: @bernhardoj - $250 - ND
C+: @dominictb - $250 - Upwork

[greg-schroeder]

Can you take care of the C+ checklist @dominictb? Thanks

[dominictb]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production
• 2b. Reported on staging (deploy blocker)
• 2c. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: https://github.com/Expensify/App/pull/33756/files#r1967696226

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: N/A

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. Yes

Regression Test Proposal

Test:

• Prerequisite: have a custom profile avatar

1. Open a chat where you can see your own avatar (e.g., self dm, workspace chat)
2. Open the avatar in an attachment modal
3. Zoom in the avatar
4. Drag left/right
5. Zoom out until the avatar image is fully visible
6. Verify the avatar goes back to the center

Do we agree 👍 or 👎

[dominictb]

@greg-schroeder done

[bernhardoj]

Requested in ND.