Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD #49539] [$250] iOS - Inbox becomes blank briefly after several navigation from workspace settings #53348

Open
2 of 8 tasks
IuliiaHerets opened this issue Nov 30, 2024 · 19 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Monthly KSv2

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Nov 30, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.69-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

  1. Launch ND or hybrid app.
  2. Go to workspace settings.
  3. Tap on the workspace chat in workspace editor.
  4. Swipe to the right three times (iOS swiping style) to return to Inbox.

Expected Result:

Inbox will not turn blank briefly when navigating back to Inbox.

Actual Result:

Inbox turns blank briefly when navigating back to Inbox.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6680806_1732989286383.ScreenRecording_12-01-2024_01-48-07_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021863134374595140416
  • Upwork Job ID: 1863134374595140416
  • Last Price Increase: 2024-12-01
  • Automatic offers:
    • c3024 | Reviewer | 105155696
Issue OwnerCurrent Issue Owner: @c3024
@IuliiaHerets IuliiaHerets added DeployBlockerCash This issue or pull request should block deployment Bug Something is broken. Auto assigns a BugZero manager. labels Nov 30, 2024
Copy link

melvin-bot bot commented Nov 30, 2024

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Nov 30, 2024

Triggered auto assignment to @tylerkaraszewski (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@melvin-bot melvin-bot bot added the Daily KSv2 label Nov 30, 2024
Copy link

melvin-bot bot commented Nov 30, 2024

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Nov 30, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@mountiny mountiny added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Dec 1, 2024
@mountiny
Copy link
Contributor

mountiny commented Dec 1, 2024

@chrispader @kirillzyusko @hannojg something to look into, i dont think this is a blocker so demoted.

@mountiny mountiny assigned mountiny and unassigned tylerkaraszewski Dec 1, 2024
@mountiny mountiny added the External Added to denote the issue can be worked on by a contributor label Dec 1, 2024
@melvin-bot melvin-bot bot changed the title iOS - Inbox becomes blank briefly after several navigation from workspace settings [$250] iOS - Inbox becomes blank briefly after several navigation from workspace settings Dec 1, 2024
Copy link

melvin-bot bot commented Dec 1, 2024

Job added to Upwork: https://www.upwork.com/jobs/~021863134374595140416

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Dec 1, 2024
Copy link

melvin-bot bot commented Dec 1, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External)

@WojtekBoman
Copy link
Contributor

Hi! I'll take a look at it :)

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Dec 2, 2024
Copy link

melvin-bot bot commented Dec 2, 2024

📣 @c3024 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

@mountiny
Copy link
Contributor

mountiny commented Dec 3, 2024

Any luck so far @WojtekBoman ?

@WojtekBoman
Copy link
Contributor

I'm still investigating it 👀

@WojtekBoman
Copy link
Contributor

@mountiny

I don't know how urgent this task is, but I checked how it works on our branch with improved bottom tabs and it seems that this issue doesn't occur there, because workspace settings page contains the bottom tab bar and it's not possible to go back using swipe on this page. If we can wait for our PR to be merged, I believe we can put this issue on hold. If not I'll try to find a solution for the current version :) I'm attaching videos with a reproduction of this issue from our PR:

Screen.Recording.2024-12-04.at.16.40.51.mov
Screen.Recording.2024-12-04.at.16.41.57.mov

@mountiny
Copy link
Contributor

mountiny commented Dec 4, 2024

it's not possible to go back using swipe on this page.

I think we might need to discuss that on the PR

@mountiny mountiny changed the title [$250] iOS - Inbox becomes blank briefly after several navigation from workspace settings [HOLD App#49539] [$250] iOS - Inbox becomes blank briefly after several navigation from workspace settings Dec 4, 2024
@kirillzyusko
Copy link
Contributor

Hello @WojtekBoman 👋

Do you think this problem is related to this problem: #53359?

From a description point of view they look very similar to each other 👀

@melvin-bot melvin-bot bot added the Overdue label Dec 5, 2024
@WojtekBoman
Copy link
Contributor

Hi @kirillzyusko!

I have checked the issue you mentioned and cannot determine if it is connected at this time.

About this issue:

In my opinion, the cause of this error is the new `Home' screen pushed when we open the chat from workspace settings. This screen is rendered first time when we go back to it and because it is being rendered for the first time it does not appear immediately. Furthermore, I think the expected result in this case would be to return from the workspace list to settings instead of the chat list page.

I'm attaching a navigation state snapshot from the chat opened from the workspace settings. You can notice that we have two home screens in the navigation state and this is the source of the problem.

{
    "stale": false,
    "type": "stack",
    "key": "stack-eECbmLpJ3eH4jn7os4zAT",
    "index": 3,
    "routeNames": [
        "BottomTabNavigator",
        "ValidateLogin",
        "TransitionBetweenApps",
        "Concierge",
        "TrackExpense",
        "SubmitExpense",
        "Attachments",
        "ProfileAvatar",
        "WorkspaceAvatar",
        "ReportAvatar",
        "not-found",
        "RightModalNavigator",
        "FullScreenNavigator",
        "LeftModalNavigator",
        "DesktopSignInRedirect",
        "ExplanationModalNavigator",
        "FeatureTrainingModalNavigator",
        "WelcomeVideoModalNavigator",
        "WorkspaceJoinUser",
        "TransactionReceipt",
        "ConnectionComplete",
        "Settings_Workspaces",
        "Settings_Preferences",
        "Settings_Security",
        "Settings_Profile",
        "Settings_Wallet",
        "Settings_About",
        "Settings_Troubleshoot",
        "Settings_TeachersUnite",
        "Settings_Subscription",
        "Search_Central_Pane",
        "Report"
    ],
    "routes": [
        {
            "key": "BottomTabNavigator-sBFO700o0OLGFBY5kJCSf",
            "name": "BottomTabNavigator",
            "state": {
                "stale": false,
                "type": "stack",
                "key": "stack--oict0Uf-n-1uDFawe7kg",
                "index": 2,
                "routeNames": ["Home", "Search_Bottom_Tab", "Settings_Root"],
                // here's the problem!!!
                "routes": [
                    {"key": "Home-WUo0QxbwVxl8ZtS9aDY4u", "name": "Home"},
                    {"key": "Settings_Root-Ue-woVWiI7dB1pNi8Ggmc", "name": "Settings_Root"},
                    {"key": "Home--4mU8eS8qr6EqKAfimj6_", "name": "Home"}
                ]
            }
        },
        {"key": "Settings_Workspaces-7Qrs8JEkdkhleK9FIdY0t", "name": "Settings_Workspaces", "params": {}},
        {
            "key": "FullScreenNavigator-7cjb85MunwBYh4me17S2y",
            "name": "FullScreenNavigator",
            "params": {"initial": true, "screen": "Workspace_Initial", "params": {"policyID": "8852B572B18D6DC3"}, "path": "/settings/workspaces/8852B572B18D6DC3"},
            "state": {
                "stale": false,
                "type": "stack",
                "key": "stack-jyqQad877x2EHVsP9V3P8",
                "index": 0,
                "routeNames": [
                    "Workspace_Initial",
                    "Workspace_Profile",
                    "Workspace_Workflows",
                    "Workspace_Invoices",
                    "Workspace_Members",
                    "Policy_Accounting",
                    "Workspace_Categories",
                    "Workspace_More_Features",
                    "Workspace_Tags",
                    "Workspace_Taxes",
                    "Workspace_ReportFields",
                    "Workspace_ExpensifyCard",
                    "Workspace_CompanyCards",
                    "Per_Diem",
                    "Distance_Rates",
                    "Policy_Rules"
                ],
                "routes": [{"key": "Workspace_Initial-6aCwlX184gJbX463F9apa", "name": "Workspace_Initial", "params": {"policyID": "8852B572B18D6DC3"}}]
            }
        },
        {"key": "Report-iKe0jp4Dhphue_k2mUjIZ", "name": "Report", "params": {"reportID": "5846539004240011"}}
    ]
}

@c3024
Copy link
Contributor

c3024 commented Dec 5, 2024

The RCA looks same as the RCA for this issue too.

@melvin-bot melvin-bot bot removed the Overdue label Dec 5, 2024
Copy link

melvin-bot bot commented Dec 9, 2024

@mallenexpensify, @mountiny, @WojtekBoman, @c3024 Whoops! This issue is 2 days overdue. Let's get this updated quick!

Copy link

melvin-bot bot commented Jan 2, 2025

This issue has not been updated in over 15 days. @mallenexpensify, @mountiny, @WojtekBoman, @c3024 eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot added the Monthly KSv2 label Jan 2, 2025
@mallenexpensify mallenexpensify changed the title [HOLD App#49539] [$250] iOS - Inbox becomes blank briefly after several navigation from workspace settings [HOLD #49539] [$250] iOS - Inbox becomes blank briefly after several navigation from workspace settings Jan 7, 2025
@mallenexpensify
Copy link
Contributor

In held PR

Now, after the Native stack PR and the RN upgrade, are we waiting for anything else with this PR, or should we approach a final stretch sprint now? 🏃‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Monthly KSv2
Projects
Status: LOW
Development

No branches or pull requests

7 participants