Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow CompleteGuidedSetup to post tasks in the #admins room #52219

Closed
yuwenmemon opened this issue Nov 7, 2024 · 1 comment
Closed

Allow CompleteGuidedSetup to post tasks in the #admins room #52219

yuwenmemon opened this issue Nov 7, 2024 · 1 comment
Assignees
Labels
Daily KSv2

Comments

@yuwenmemon
Copy link
Contributor

Coming from #51443 and the proposal outlined here.

Background

Right now, CompleteGuidedSetup posts setup tasks from the Concierge Account. The reportID it is posted into is provided by the parentReportID sent by the client when providing the optimistic task data.

Problem

Because the tasks are sent by the concierge account, we can't allow CompleteGuidedSetup to post tasks in the #admins room since the concierge is not part of that room (nor do we want it to be).

Solution

If the #admins room is provided as the parentReportID for a task, create the tasks from the guide in the #admins room who also sent the welcome message.

cc @MonilBhavsar @deetergp @c3024

@yuwenmemon
Copy link
Contributor Author

This is complete

@melvin-bot melvin-bot bot removed the Overdue label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2
Projects
None yet
Development

No branches or pull requests

2 participants