Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250][HOLD https://github.com/Expensify/App/pull/52164] Add workspace creation confirmation to workspace switcher. #52075

Open
danielrvidal opened this issue Nov 5, 2024 · 15 comments
Assignees
Labels
Daily KSv2 External Added to denote the issue can be worked on by a contributor Overdue

Comments

@danielrvidal
Copy link
Contributor

danielrvidal commented Nov 5, 2024

We're already adding the workspace confirmation to Global Create and in Settings > Workspaces. We forgot to also put the confirmation in another flow, the workspace switcher.

Can you please add the confirmation in the following screens as well.

Workspace switcher > Get started:
image

Workspace switcher > + New Workspace:
image

Video of me showing these screens:
https://github.com/user-attachments/assets/81f82325-a96b-43da-ac7a-560a277ec2eb

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021853885696160356282
  • Upwork Job ID: 1853885696160356282
  • Last Price Increase: 2024-11-05
  • Automatic offers:
    • allgandalf | Reviewer | 104757767
    • Krishna2323 | Contributor | 104757770
Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @allgandalf
@danielrvidal danielrvidal added the Daily KSv2 label Nov 5, 2024
@danielrvidal danielrvidal added the External Added to denote the issue can be worked on by a contributor label Nov 5, 2024
Copy link

melvin-bot bot commented Nov 5, 2024

Job added to Upwork: https://www.upwork.com/jobs/~021853885696160356282

@melvin-bot melvin-bot bot changed the title Add workspace creation confirmation to workspace switcher. [$250] Add workspace creation confirmation to workspace switcher. Nov 5, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 5, 2024
Copy link

melvin-bot bot commented Nov 5, 2024

Current assignee @allgandalf is eligible for the External assigner, not assigning anyone new.

@Krishna2323
Copy link
Contributor

Krishna2323 commented Nov 5, 2024

@danielrvidal please assign me, I will work on this.

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 5, 2024
Copy link

melvin-bot bot commented Nov 5, 2024

📣 @allgandalf 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

Copy link

melvin-bot bot commented Nov 5, 2024

📣 @Krishna2323 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@rafecolton rafecolton self-assigned this Nov 5, 2024
@melvin-bot melvin-bot bot added the Overdue label Nov 11, 2024
@allgandalf
Copy link
Contributor

not overdue sir melvin

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Nov 11, 2024
@rafecolton
Copy link
Member

Is there a WIP PR for this?

@melvin-bot melvin-bot bot removed the Overdue label Nov 13, 2024
@Krishna2323
Copy link
Contributor

Krishna2323 commented Nov 13, 2024

Is there a WIP PR for this?

@rafecolton nope, we can put this on hold until this PR is being merged.

@rafecolton rafecolton changed the title [$250] Add workspace creation confirmation to workspace switcher. [$250][HOLD https://github.com/Expensify/App/pull/52164] Add workspace creation confirmation to workspace switcher. Nov 13, 2024
@allgandalf
Copy link
Contributor

@danielrvidal lets make this one weekly, untill we merge #52164

@melvin-bot melvin-bot bot added the Overdue label Nov 18, 2024
@allgandalf
Copy link
Contributor

also can you change the star to me or you @rafecolton , currently @Krishna2323 has that star so they have to comment to remove the overdue label

@rafecolton
Copy link
Member

Done

@melvin-bot melvin-bot bot removed the Overdue label Nov 18, 2024
Copy link

melvin-bot bot commented Nov 22, 2024

@rafecolton, @danielrvidal, @Krishna2323, @allgandalf Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label Nov 22, 2024
@danielrvidal
Copy link
Contributor Author

Still on hold. The other issue is making daily progress.

@allgandalf
Copy link
Contributor

Let's put this to weekly until the other one hits staging ?

@melvin-bot melvin-bot bot removed the Overdue label Nov 25, 2024
Copy link

melvin-bot bot commented Nov 28, 2024

@rafecolton, @danielrvidal, @Krishna2323, @allgandalf Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 External Added to denote the issue can be worked on by a contributor Overdue
Projects
Status: No status
Development

No branches or pull requests

4 participants