Chat -Uploading csv file in offline showing infinite loading

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.56-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5171911
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to https://staging.new.expensify.com/home
2. Open a chat
3. Go offline
4. Tap plus icon - upload below attachment

Expected Result:

Uploading csv file in offline must not show infinite loading

Actual Result:

Uploading csv file in offline showing infinite loading

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6651178_1730383918625.Screenrecorder-2024-10-31-19-38-12-814_compress_1.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Nodebrute]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Uploading csv file in offline showing infinite loading

What is the root cause of that problem?

In this PR, we displayed a loading spinner while a file is uploading. However, in offline mode, the spinner will load indefinitely since the upload can't be completed until the user is back online.

What changes do you think we should make in order to solve the problem?

We can add another check here !isOffline to not show loading indicator when user is offline

App/src/components/AnchorForAttachmentsOnly/BaseAnchorForAttachmentsOnly.tsx

Line 67 in 224b633

isUploading={!sourceID}

                isUploading={!sourceID && !isOffline}

What alternative solutions did you explore? (Optional)

[MuaazArshad]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Uploading csv file in offline showing infinite loading

What is the root cause of that problem?

As the file is uploading the loading will continue until the site is offline.

What changes do you think we should make in order to solve the problem?

If we want to remove the loader while offline we should add the condition for offline here.

App/src/components/Attachments/AttachmentView/DefaultAttachmentView/index.tsx

Lines 60 to 68 in 224b633

	{shouldShowLoadingSpinnerIcon && (
	<View style={styles.ml2}>
	<Tooltip text={isUploading ? translate('common.uploading') : translate('common.downloading')}>
	<ActivityIndicator
	size="small"
	color={theme.textSupporting}
	/>
	</Tooltip>
	</View>

like this

{!isOffline && shouldShowLoadingSpinnerIcon && (
                <View style={styles.ml2}>
                    <Tooltip text={isUploading ? translate('common.uploading') : translate('common.downloading')}>
                        <ActivityIndicator
                            size="small"
                            color={theme.textSupporting}
                        />
                    </Tooltip>
                </View>
            )}

What alternative solutions did you explore? (Optional)

[getusha]

Technically the file is still uploading, imo it's fine if we leave it like that.

cc @Expensify/design

[dannymcclain]

Technically the file is still uploading, imo it's fine if we leave it like that.

Agree—the file is still uploading and the message is correctly styled as an offline message waiting to be posted so this seems like expected behavior to me.

[stephanieelliott]

Yeah I agree, this seems expected seeing as you are offline