Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-12-07] [$250] Remove or update the “Chat with your account manager here” banner #51433

Open
danielrvidal opened this issue Oct 24, 2024 · 39 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production External Added to denote the issue can be worked on by a contributor High Priority Weekly KSv2

Comments

@danielrvidal
Copy link
Contributor

danielrvidal commented Oct 24, 2024

Problem: Chat with your account manager makes users think they are chatting with their account manager in Concierge.

  • We have this green bar on the top of the Concierge DM that looks like notice, but it actually directs you to the #admins room. But from looking at the UX, I would never guess that is a linkable banner.

Solution: Update the banner to look like button that clearly links to somewhere. And in the process, include the email and also have the link direct to the AM DM rather than the #admins room.

[Lightbulb] Need something specific? Chat with your account manager, [firstName] ([accountManagerEmail]). [Chat now] X

Image 1 shows the old UI. Image 2 shows the proposed updated UI. Please weigh in before I take it to GH with a contributor!

image
image

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021853509960370506398
  • Upwork Job ID: 1853509960370506398
  • Last Price Increase: 2024-11-11
  • Automatic offers:
    • allgandalf | Reviewer | 104908687
    • mkzie2 | Contributor | 104908688
Issue OwnerCurrent Issue Owner: @allgandalf
@danielrvidal danielrvidal added Daily KSv2 Internal Requires API changes or must be handled by Expensify staff labels Oct 24, 2024
@danielrvidal danielrvidal self-assigned this Oct 24, 2024
@dannymcclain
Copy link
Contributor

Figma file and easier to view updated mocks:

Account manager banner (Figma)

image

image

☝️ No difference between those mocks—just showing light and dark mode. Note that they mostly follow the banner style we use for when a chat is read only or archived and we replace the composer with a banner.

@melvin-bot melvin-bot bot added the Overdue label Oct 28, 2024
@flaviadefaria flaviadefaria moved this to First Cohort in [#whatsnext] #migrate Oct 28, 2024
@flaviadefaria flaviadefaria moved this from First Cohort to Upcoming Cohorts in [#whatsnext] #migrate Oct 28, 2024
@flaviadefaria
Copy link
Contributor

@danielrvidal Since cohort 1 is for customers with less than 10 users, then effectively, they won't have AMs. I'll keep this in the project board under Upcoming cohorts but if you think this can be prioritized elsewhere or if you think this should be prioritized differently lmk!

@danielrvidal
Copy link
Contributor Author

That sounds good, I think this can be done purely by Contributors, so maybe I still open it up so they can work on it even if it's not going to be CRITICAL for this cohort.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Oct 28, 2024
@danielrvidal
Copy link
Contributor Author

Still working on this.

@melvin-bot melvin-bot bot removed the Overdue label Oct 31, 2024
@flaviadefaria
Copy link
Contributor

That sounds good, I think this can be done purely by Contributors, so maybe I still open it up so they can work on it even if it's not going to be CRITICAL for this cohort.

Oh absolutely! We should open everything that is possible, and on a project board, to contributors (regardless of priority).

Copy link

melvin-bot bot commented Nov 4, 2024

@danielrvidal Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@danielrvidal danielrvidal removed Internal Requires API changes or must be handled by Expensify staff Overdue labels Nov 4, 2024
@danielrvidal danielrvidal added External Added to denote the issue can be worked on by a contributor and removed Overdue labels Nov 4, 2024
@melvin-bot melvin-bot bot added the Overdue label Nov 4, 2024
@melvin-bot melvin-bot bot changed the title Remove or update the “Chat with your account manager here” banner [$250] Remove or update the “Chat with your account manager here” banner Nov 4, 2024
Copy link

melvin-bot bot commented Nov 4, 2024

Job added to Upwork: https://www.upwork.com/jobs/~021853509960370506398

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 4, 2024
@melvin-bot melvin-bot bot removed the Overdue label Nov 12, 2024
@danielrvidal
Copy link
Contributor Author

@marcaaron any chance you could review this sometime soon?

@melvin-bot melvin-bot bot added Overdue and removed Help Wanted Apply this label when an issue is open to proposals by contributors labels Nov 15, 2024
Copy link

melvin-bot bot commented Nov 15, 2024

📣 @allgandalf 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

Copy link

melvin-bot bot commented Nov 15, 2024

📣 @mkzie2 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@marcaaron
Copy link
Contributor

Huh weird. This one must have fallen off my radar somehow. Assigned!

@allgandalf
Copy link
Contributor

not overdue sir melvin, @mkzie2 when can we expect the PR?

@melvin-bot melvin-bot bot removed the Overdue label Nov 15, 2024
@mkzie2
Copy link
Contributor

mkzie2 commented Nov 15, 2024

Will raise the PR on Monday.

@mkzie2
Copy link
Contributor

mkzie2 commented Nov 18, 2024

@allgandalf Currently I'm unable to access Expensify Slack channel, can you help ask for these translations? Thanks!

en: Need something specific? Chat with your account manager
es: ¿Necesitas algo específico? Habla con tu gerente de cuenta.

I forgot to mention this one as well:

en: Chat now
es: Chatear ahora

@melvin-bot melvin-bot bot added the Overdue label Nov 18, 2024
@mkzie2
Copy link
Contributor

mkzie2 commented Nov 18, 2024

@marcaaron How can we display the banner? Currently I'm using mock data and I want to test the PR with real data.

@allgandalf
Copy link
Contributor

allgandalf commented Nov 18, 2024

@mkzie2 can you share me the screenshot where this translation is used, helps us verify things for the internal people

(NVM, i took it from the mock)

@melvin-bot melvin-bot bot removed the Overdue label Nov 18, 2024
@allgandalf
Copy link
Contributor

Asked for translations here https://expensify.slack.com/archives/C01GTK53T8Q/p1731956643857439

@marcaaron
Copy link
Contributor

@mkzie2 Hmm this is just a UI change AFAICT so mocking or forcing this to show up seems fine. Let's use git blame to figure out when we added it and use the same manual QA steps?

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Nov 19, 2024
@danielrvidal
Copy link
Contributor Author

Looks like we should be deploying PRs soon per this issue: #52682

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Nov 30, 2024
@melvin-bot melvin-bot bot changed the title [$250] Remove or update the “Chat with your account manager here” banner [HOLD for payment 2024-12-07] [$250] Remove or update the “Chat with your account manager here” banner Nov 30, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Nov 30, 2024
Copy link

melvin-bot bot commented Nov 30, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Nov 30, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.68-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-12-07. 🎊

For reference, here are some details about the assignees on this issue:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production External Added to denote the issue can be worked on by a contributor High Priority Weekly KSv2
Projects
Status: Support (HIGH)
Development

No branches or pull requests

8 participants