-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-12-07] [$250] Remove or update the “Chat with your account manager here” banner #51433
Comments
Figma file and easier to view updated mocks: Account manager banner (Figma) ☝️ No difference between those mocks—just showing light and dark mode. Note that they mostly follow the banner style we use for when a chat is read only or archived and we replace the composer with a banner. |
@danielrvidal Since cohort 1 is for customers with less than 10 users, then effectively, they won't have AMs. I'll keep this in the project board under |
That sounds good, I think this can be done purely by Contributors, so maybe I still open it up so they can work on it even if it's not going to be CRITICAL for this cohort. |
Still working on this. |
Oh absolutely! We should open everything that is possible, and on a project board, to contributors (regardless of priority). |
@danielrvidal Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
Job added to Upwork: https://www.upwork.com/jobs/~021853509960370506398 |
@marcaaron any chance you could review this sometime soon? |
📣 @allgandalf 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app! |
📣 @mkzie2 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
Huh weird. This one must have fallen off my radar somehow. Assigned! |
not overdue sir melvin, @mkzie2 when can we expect the PR? |
Will raise the PR on Monday. |
@allgandalf Currently I'm unable to access Expensify Slack channel, can you help ask for these translations? Thanks! en: I forgot to mention this one as well: en: |
@marcaaron How can we display the banner? Currently I'm using mock data and I want to test the PR with real data. |
@mkzie2 can you share me the screenshot where this translation is used, helps us verify things for the internal people (NVM, i took it from the mock) |
Asked for translations here https://expensify.slack.com/archives/C01GTK53T8Q/p1731956643857439 |
@mkzie2 Hmm this is just a UI change AFAICT so mocking or forcing this to show up seems fine. Let's use |
Looks like we should be deploying PRs soon per this issue: #52682 |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.68-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-12-07. 🎊 For reference, here are some details about the assignees on this issue:
|
Problem: Chat with your account manager makes users think they are chatting with their account manager in Concierge.
Solution: Update the banner to look like button that clearly links to somewhere. And in the process, include the email and also have the link direct to the AM DM rather than the #admins room.
[Lightbulb] Need something specific? Chat with your account manager, [firstName] ([accountManagerEmail]). [Chat now] X
Image 1 shows the old UI. Image 2 shows the proposed updated UI. Please weigh in before I take it to GH with a contributor!
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @allgandalfThe text was updated successfully, but these errors were encountered: