Split - App crashes after clicking on split preview

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.52-1
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to DM.
3. Split any type of expense (manual, scan or distance).
4. Click on the split preview.

Expected Result:

App will not crash.

Actual Result:

App crashes after clicking on split preview.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

2210_1.txt

Bug6641912_1729593788314.crash.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @youssef-lr (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[Krishna2323]

Proposal


Please re-state the problem that we are trying to solve in this issue.

Split - App crashes after clicking on split preview

What is the root cause of that problem?

• Object.values throws error when tagList.tags is undefined.

App/src/components/MoneyRequestConfirmationList.tsx

Line 675 in d3db2a1

const enabledTags = Object.values(tagList.tags).filter((tag) => tag.enabled);

What changes do you think we should make in order to solve the problem?


• Add default value {}

Object.values(tagList.tags ?? {})

What alternative solutions did you explore? (Optional)

Result

[daledah]

This comes from #50327

I'll raise a follow-up PR soon.