Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Hybrid App - Unlink button is not seen on hybrid app for unvalidated secondary login #51091

Closed
2 of 8 tasks
IuliiaHerets opened this issue Oct 18, 2024 · 20 comments
Closed
2 of 8 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Oct 18, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.50-0
Reproducible in staging?: N
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
Issue was found when executing this PR: #50769
**Email or phone of affected tester (no customers):**[email protected]
Issue reported by: Applause Internal Team

Action Performed:

  1. Create a new account and add a secondary email but don't validate the secondary email
  2. Try to login with the unvalidated secondary email on hybrid app

Expected Result:

Unlink button gets shown after the email input page

Actual Result:

Instead of showing unlink button validation link button with a "Resend link" copy is shown

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6638817_1729261828818.Screen_Recording_20241018_135451.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021848544820308237719
  • Upwork Job ID: 1848544820308237719
  • Last Price Increase: 2024-10-29
@IuliiaHerets IuliiaHerets added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Oct 18, 2024
Copy link

melvin-bot bot commented Oct 18, 2024

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@IuliiaHerets
Copy link
Author

We think that this bug might be related to #wave-collect - Release 2

@IuliiaHerets
Copy link
Author

@johncschuster FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributor

Copy link

melvin-bot bot commented Oct 21, 2024

@johncschuster Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@johncschuster johncschuster added the External Added to denote the issue can be worked on by a contributor label Oct 22, 2024
@melvin-bot melvin-bot bot changed the title Hybrid App - Unlink button is not seen on hybrid app for unvalidated secondary login [$250] Hybrid App - Unlink button is not seen on hybrid app for unvalidated secondary login Oct 22, 2024
Copy link

melvin-bot bot commented Oct 22, 2024

Job added to Upwork: https://www.upwork.com/jobs/~021848544820308237719

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 22, 2024
Copy link

melvin-bot bot commented Oct 22, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

@melvin-bot melvin-bot bot removed the Overdue label Oct 22, 2024
@mananjadhav
Copy link
Collaborator

@johncschuster do we have a way for external contributors to work on Hybrid App?

@waterim
Copy link
Contributor

waterim commented Oct 22, 2024

Hello, Im Artem from Callstack and would like to help with this issue!
Also I will need a permission to the Hybrid app repo to start working on this

@muttmuure
Copy link
Contributor

HybridApp isn't open to CS yet unfortunately, please look out for the announcement when it is

@muttmuure muttmuure moved this to MEDIUM in [#whatsnext] #quality Oct 23, 2024
Copy link

melvin-bot bot commented Oct 25, 2024

@mananjadhav, @johncschuster Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Oct 25, 2024
@johncschuster
Copy link
Contributor

Bumping for Melv. @mananjadhav, do we need other proposals?

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Oct 25, 2024
@johncschuster
Copy link
Contributor

@mananjadhav bump on the above!

@melvin-bot melvin-bot bot removed the Overdue label Oct 28, 2024
Copy link

melvin-bot bot commented Oct 29, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot melvin-bot bot added the Overdue label Oct 31, 2024
@johncschuster
Copy link
Contributor

Bumped in Slack

@melvin-bot melvin-bot bot removed the Overdue label Oct 31, 2024
Copy link

melvin-bot bot commented Nov 1, 2024

@mananjadhav @johncschuster this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@mananjadhav
Copy link
Collaborator

@johncschuster As @muttmuure mentioned HybridApp isn't available for external contributors. We'll either need to resolve this internally or take agency help.

@melvin-bot melvin-bot bot added the Overdue label Nov 4, 2024
Copy link

melvin-bot bot commented Nov 4, 2024

@mananjadhav, @johncschuster Whoops! This issue is 2 days overdue. Let's get this updated quick!

@johncschuster
Copy link
Contributor

I've raised this in #quality

@melvin-bot melvin-bot bot removed the Overdue label Nov 4, 2024
@johncschuster
Copy link
Contributor

I discussed this in Slack, and based on this:

If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y

it sounds like this issue is not a HybridApp issue and should be able to be worked on by anyone. @mananjadhav, can you take another look?

@johncschuster
Copy link
Contributor

johncschuster commented Nov 5, 2024

Wait, there's more! Given we are moving to the New Expensify Sign in page (discussion here), it sounds like this might be irrelevant. I'm going to close this.

@github-project-automation github-project-automation bot moved this from MEDIUM to Done in [#whatsnext] #quality Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
Development

No branches or pull requests

5 participants