[HOLD for payment 2024-10-25] [Search v2.4] Remove Search in contextual suggestion when typing

[luacmartins]

Coming from here, we should only show the Search in... contextual suggestion when the user has no input in the router. We should remove it from the suggestions as soon as the user starts typing.

Issue Owner

Current Issue Owner: @sonialiap

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.50-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Remove the Search in contextual search when typing query #50821

If no regressions arise, payment will be issued on 2024-10-25. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@luacmartins] The PR that introduced the bug has been identified. Link to the PR: N/A new feature
• [@luacmartins] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A new feature
• [@luacmartins] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@luacmartins] Determine if we should create a regression test for this bug.
• [@luacmartins] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@sonialiap] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[sonialiap]

@luacmartins did we have a C+ review this PR or is there no payment needed on this issue? I see dacitto is on the PR but I'm not clear if Srikar was the only reviewer

[luacmartins]

No C+, only Srikar. No payment needed here. Closing.