Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-10-24] [$250][Search v2.1] Remove Search filter multi-select list headers #50654

Closed
luacmartins opened this issue Oct 11, 2024 · 11 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff

Comments

@luacmartins
Copy link
Contributor

luacmartins commented Oct 11, 2024

Coming from here, we should remove the list headers for the following Search filters:

  • Expense type
  • Tag
  • Category
  • Currency
  • Tax rate

Additionally, we should add a Virtual flag to indicate that a specific card is a virtual card

Issue OwnerCurrent Issue Owner: @zanyrenney
@luacmartins luacmartins added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Oct 11, 2024
@luacmartins luacmartins self-assigned this Oct 11, 2024
Copy link

melvin-bot bot commented Oct 11, 2024

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@luacmartins luacmartins mentioned this issue Oct 11, 2024
50 tasks
@luacmartins luacmartins added the Internal Requires API changes or must be handled by Expensify staff label Oct 11, 2024
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Oct 11, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Oct 17, 2024
@melvin-bot melvin-bot bot changed the title [Search v2.1] Remove Search filter multi-select list headers [HOLD for payment 2024-10-24] [Search v2.1] Remove Search filter multi-select list headers Oct 17, 2024
Copy link

melvin-bot bot commented Oct 17, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Oct 17, 2024
Copy link

melvin-bot bot commented Oct 17, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.49-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-10-24. 🎊

For reference, here are some details about the assignees on this issue:

  • @fedirjh requires payment through NewDot Manual Requests

Copy link

melvin-bot bot commented Oct 17, 2024

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@fedirjh] The PR that introduced the bug has been identified. Link to the PR:
  • [@fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • [@fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • [@fedirjh] Determine if we should create a regression test for this bug.
  • [@fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • [@zanyrenney] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Oct 23, 2024
@zanyrenney
Copy link
Contributor

@luacmartins can you clarify the payment amount in your issues like this, so it helps the BZ team to know what amount to state in the payment summary? Cheers!

@luacmartins luacmartins changed the title [HOLD for payment 2024-10-24] [Search v2.1] Remove Search filter multi-select list headers [HOLD for payment 2024-10-24] [$250][Search v2.1] Remove Search filter multi-select list headers Oct 24, 2024
Copy link

melvin-bot bot commented Oct 24, 2024

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

@luacmartins
Copy link
Contributor Author

luacmartins commented Oct 24, 2024

Ah yea, not sure why the automation didn't add the price to it (I added it to the title now), but this is the standard $250.

@zanyrenney
Copy link
Contributor

Cool thanks for clarifying @luacmartins

@zanyrenney
Copy link
Contributor

Payment summary

$250 to @fedirjh - please request via ND Manual Requests. Thanks!

@github-project-automation github-project-automation bot moved this from Hold for Payment to Done in [#whatsnext] #expense Oct 24, 2024
Copy link

melvin-bot bot commented Oct 24, 2024

@luacmartins @zanyrenney Be sure to fill out the Contact List!

@garrettmknight
Copy link
Contributor

$250 approved for @fedirjh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff
Projects
Status: Done
Development

No branches or pull requests

4 participants