mWeb - Card - PR50039-No virtual card is created when issuing it from the members page

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.46-3
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR #50039

Action Performed:

1. Log in in the App
2. Create a WS
3. 3. Add a Verified Bank Account to the Workspace
4. In WS settings go to More Features and Enable Expensify card
5. Invite a member to WS
6. Click on the member just invited, on the RHP click om the +New Card
7. Go with the flow to (select virtual card)
8. On the last page click Issue Card

Expected Result:

A new virtual card is issued to the selected member

Actual Result:

The card issue flow ends but no new card is displayed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6628427_1728398410811.nocardprod.mp4

Bug6628427_1728398410834.az_recorder_20241008_130453.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@alexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 2

[Nodebrute]

probably dupe of #50441

[mountiny]

@VickyStash @koko57 can you have a look at this one? I think the same solution is required - add card optimistically

[koko57]

#50441 (comment) - commenting for assignment 🙂

[koko57]

@lanitochka17 just to make sure - these are the exact steps for reproduction - after enabling the Expensify Card you go to the members page? You're not adding/choosing the bank account on this page?

if so, that means it's the problem I mentioned here #50248 (comment)
so it'll be fixed by hiding Assigned Cards section
cc @mountiny

[koko57]

another issue that I need to take care of and add RBR - when we're trying to choose an account that is already assigned to another's workspace Expensify Card

[mountiny]

Thanks I will ask QA to confirm

[isagoico]

@koko57 Apologies for the confusion, looks like we missed adding the step to add a Bank Account as the tester already had one added to the Workspace. That's why the selection of the bank account is not displayed in the video attached to the OC.
The correct steps would be:

1. Log in in the App
2. Create a WS
3. Add a Verified Bank Account to the Workspace ✨
4. In WS settings go to More Features and Enable Expensify card
5. Invite a member to WS
6. Click on the member just invited, on the RHP click om the +New Card
7. Go with the flow to (select virtual card)
8. On the last page click Issue Card

I have updated the OC to reflect this.

[koko57]

@isagoico ok! thanks!

[koko57]

So we will need the optimistic update - but shouldn't also the BE send cardList as onyxUpdate in CreateAdminIssuedVirtualCard response?

cc @mountiny @MariaHCD

[mountiny]

Lets discuss in slack

[mountiny]

PR to send the onyx updates is raised

[koko57]

BE returns the card when creating one following these steps - this can be retested and closed.

[isagoico]

@koko57 Hello there! We're still able to reproduce the issue on our end. The testers also pointed out that the issue is NOT reproducible with accounts that were created today.

The video below shows the flow when we're trying to assign a card to an existing account (>1 day older)

bandicam.2024-10-11.16-04-38-487.mp4

[mountiny]

The QA can still experience this issue because the update is sent via pusher so its not instant, we will make couple changes to make this more smooth so making weekly and then we can recheck

[mountiny]

https://github.com/Expensify/Auth/pull/12749 this PR should make it work better together with this https://github.com/Expensify/App/pull/50644/files and a loading state so we do not leave the page until you have a card

[melvin-bot]

This issue has not been updated in over 15 days. @alexpensify, @koko57, @mountiny eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[mountiny]

Asked for a retest here

[kavimuru]

Bug is not reproducible.

50467-2.mp4

[mountiny]

Nice so we can close this, the fix was internal in the BE