[$250] [Due for payment 2025-02-25] [HOLD] Web - Attachment - Console error on preview page of Large PDF uploaded

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v9.0.40-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5006507
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

1. Log into staging.new.expensify.com and open any chat
2. Tap "+" and tap Add attachment
3. Upload "Large PDF File"

Expected Result:

No error in console appears

Actual Result:

A console error is shown on PDF preview page.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6615543_1727314388572!LARGE_PDF_FILE.pdf

Bug6615543_1727314388594.Screen_Recording_2024-09-25_at_7.13.58_PM.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021894593784371336669
• Upwork Job ID: 1894593784371336669
• Last Price Increase: 2025-02-26

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

@mallenexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[mallenexpensify]

Bumping to weekly, will review next week since it's a console error

[mallenexpensify]

Console error, not an immediate priority

[MelvinBot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

[CyberAndrii]

I've opened an issue in the upstream repo: mozilla/pdf.js#18876

[melvin-bot]

@mallenexpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[mallenexpensify]

@CyberAndrii , did you upstream PR fix this bug? I just tried to reproduce in Chrome with the file linked in the OP and I didn't see any console errors. Added retest-weekly here too

[CyberAndrii]

I can still reproduce this on staging v9.0.53-1. A new version of pdf.js that includes the fix will be released in about a week.

[mallenexpensify]

I'm off the next week, will address this once back.

[mallenexpensify]

A new version of pdf.js that includes the fix will be released in about a week.

Reckon we're waiting on this. We have retest-weekly here so we should get a retest soon.

[mallenexpensify]

Still kicking a can here, we're starting part deux for console error cleanup so this might be picked up there

• Console Error Cleanup part deux! #53417

[kubabutkiewicz]

I will take a look, since pdfjs-dist was already upgraded and the fix is there for that, so for me it seems to be different problem than before.

[kubabutkiewicz]

Expensify/react-fast-pdf#46
I found the fix, @francoisl would you be able to review this PR ?

[melvin-bot]

Triggered auto assignment to @jasperhuangg, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[hungvu193]

@mallenexpensify Can you please assign me here as I reviewed the linked PR? ty

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.99-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Upgarde react-fast-pdf package #56669

If no regressions arise, payment will be issued on 2025-02-25. 🎊

For reference, here are some details about the assignees on this issue:

• @hungvu193 requires payment through NewDot Manual Requests
• @kubabutkiewicz does not require payment (Contractor)

[melvin-bot]

@hungvu193 @mallenexpensify @hungvu193 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[hungvu193]

This issue is a part of the bigger issue, so I think we only need to propose the regression test here:

Regression Test:

1. Go to any chat
2. Click Add attachment.
3. Use this https://github.com/user-attachments/files/17156100/Bug6615543_1727314388572.LARGE_PDF_FILE.pdf attachment and
4. Verify that the attachment is uploaded successfully and no console errors appear.

Do we 👍 or 👎 ?

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @hungvu193 owed $250 via NewDot
• Contributor: @kubabutkiewicz is from an agency-contributor and not due payment

BugZero Checklist (@mallenexpensify)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021894593784371336669

[melvin-bot]

Current assignee @hungvu193 is eligible for the External assigner, not assigning anyone new.

[mallenexpensify]

@hungvu193 can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~021894593784371336669

Test case, thx @hungvu193
https://github.com/Expensify/Expensify/issues/474385

[hungvu193]

@hungvu193 can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~021894593784371336669

Cool. I've just accepted.