Expense - Banner shows user email/name first, then "You" instead of "You" directly

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.38-1
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
Issue was found when executing this PR: #49315
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Submit an expense.
4. Go to expense report.

Expected Result:

The banner will directly display "You" in "Waiting for You's expense(s) to..."

Actual Result:

The banner shows user email (or name if there is custom name) first, then "You" in "Waiting for You's expense(s) to..."

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6609074_1726764087538.bandicam_2024-09-20_00-37-22-624.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

We think that this bug might be related to #wave-collect - Release 1

[melvin-bot]

Triggered auto assignment to @srikarparsi (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[IuliiaHerets]

Sorry, didn't add a blocker label, fixed

[ishpaul777]

fix is under review #49482

[srikarparsi]

Awesome thanks! Will check back once this gets gets CPed

[grgia]

Just triggered CP for #49482
Progress on build here

[srikarparsi]

This has been fixed with this PR:

Going to close this out. Also @grgia do you know if there's plans to make the "Your" lowercase?