[HOLD for Payment 2024-10-10][$250] NetSuite - "This field is required" message displayed instead of "Please select an option"

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.35-0
Reproducible in staging?: Y
Reproducible in production?: Y
Issue reported by: Applause Internal Team

Action Performed:

1. Navigate to https://staging.new.expensify.com/
2. Log in with a new Gmail account
3. Click on FAB - New workspace
4. Enable "Accounting" in the "More features" page.
5. Navigate to "Accounting"
6. Connect to NetSuite and upgrade the workspace to Control when asked
7. Wait for the sync to finish
8. Navigate to Accounting - Import - Custom lists
9. Click on the "Add custom list" button
10. Click on "Name" and select any of the options
11. Click on the "Next" button
12. Type any ID name and click on the "Next" button
13. Click on the "Next" button without making a selection

Expected Result:

The message should be "Please select an option above.".

Actual Result:

"This field is required." message displayed instead of "Please select an option above." in custom list. Custom segments/records has a similar selection where the message is "Please select an option above.".

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6603678_1726331976892.bandicam_2024-09-14_18-29-50-687.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021838993006619000838
• Upwork Job ID: 1838993006619000838
• Last Price Increase: 2024-09-25

Issue Owner

Current Issue Owner: @JmillsExpensify

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

We think that this bug might be related to #wave-control

[IuliiaHerets]

@JmillsExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[cretadn22]

Edited by proposal-police: This proposal was edited at 2024-09-16 14:30:28 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

NetSuite - "This field is required" message displayed instead of "Please select an option"

What is the root cause of that problem?

The validate function at the Mapping step is not displaying the correct error message

App/src/pages/workspace/accounting/netsuite/import/NetSuiteImportCustomFieldNew/NetSuiteImportAddCustomListPage.tsx

Lines 96 to 97 in 025a630

	case CONST.NETSUITE_CUSTOM_FIELD_SUBSTEP_INDEXES.CUSTOM_LISTS.MAPPING:
	return ValidationUtils.getFieldRequiredErrors(values, [INPUT_IDS.MAPPING]);

What changes do you think we should make in order to solve the problem?

We need to update the error message to match the one in NetSuiteImportAddCustomSegmentPage

App/src/pages/workspace/accounting/netsuite/import/NetSuiteImportCustomFieldNew/NetSuiteImportAddCustomSegmentPage.tsx

Lines 126 to 130 in 025a630

	case CONST.NETSUITE_CUSTOM_FIELD_SUBSTEP_INDEXES.CUSTOM_SEGMENTS.MAPPING:
	if (!ValidationUtils.isRequiredFulfilled(values[INPUT_IDS.MAPPING])) {
	errors[INPUT_IDS.MAPPING] = translate('common.error.pleaseSelectOne');
	}
	return errors;

Additionally, add the shouldHideFixErrorsAlert prop to FormProvider to hide the old error message

shouldHideFixErrorsAlert={screenIndex === CONST.NETSUITE_CUSTOM_FIELD_SUBSTEP_INDEXES.CUSTOM_LISTS.MAPPING}

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

@JmillsExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@JmillsExpensify Still overdue 6 days?! Let's take care of this!

[cretadn22]

@JmillsExpensify, could you please check out this issue?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021838993006619000838

[JmillsExpensify]

Opened up to the community. Pending proposal review.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[mananjadhav]

@cretadn22's proposal looks good to me.

🎀 👀 🎀 C+ reviewed.

[melvin-bot]

Triggered auto assignment to @luacmartins, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[luacmartins]

Shouldn't the error message be displayed under the field with the error instead of the bottom of the page as well? IIRC that's our form design

[cretadn22]

@luacmartins The design is confirmed here

[luacmartins]

Thanks for confirming @cretadn22! In that case the proposal looks good.

[melvin-bot]

❌ There was an error making the offer to @cretadn22 for the Contributor role. The BZ member will need to manually hire the contributor.

[cretadn22]

⚠️ Automation failed here -> this should be on [HOLD for Payment 2024-10-10]

[JmillsExpensify]

Payment summary:

• Contributor: @cretadn22 $250
• Reviewer: @mananjadhav $250

[cretadn22]

@JmillsExpensify The payment is ready

[garrettmknight]

$250 approved for @mananjadhav

[mananjadhav]

@JmillsExpensify Is the payout done for @cretadn22 ?

I think we didn't decide on the error message during the NetSuite integration. Hence, I don't think we have any offending PR. I also think we don't need a regression test for this one. Hence, once the payout is done, we can close this one out?

[JmillsExpensify]

Sounds good, will do.