[$250] [HOLD for payment 2024-10-25] [Search v2.4] [App] Remove existing ChatFinder functionality

[luacmartins]

Implement this section of the doc

• Hold on [HOLD for payment 2024-10-04][$250] [Search v2.4] [App] Extend the 🔍icon and search router to all pages by adding “Search”  #49122

cc @Kicu @289Adam289 @Guccio163 @SzymczakJ

Issue Owner

Current Issue Owner: @

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021849747339555708566
• Upwork Job ID: 1849747339555708566
• Last Price Increase: 2024-10-25
• Automatic offers:
• rayane-djouah | Contributor | 104587131

[melvin-bot]

Triggered auto assignment to @zanyrenney (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[Kicu]

This is on Hold and it will be literally the last thing to do, after everything else in 2.4 works fine.
So we can either leave it be for now, or if you prefer to always have someone assigned then you can assign this to me.

[zanyrenney]

as per comment above, this is the last item for search.

[luacmartins]

On hold

[Kicu]

Leaving a paper trail.

As part of removing old chat finder we need to migrate the performance measurements done there. Relevant thread: https://swmansion.slack.com/archives/C06ML6X0W9L/p1727777756022389?thread_ts=1727777636.836479&cid=C06ML6X0W9L

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.50-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Use SearchRouter everywhere and drop Chat finder #49984

If no regressions arise, payment will be issued on 2024-10-25. 🎊

For reference, here are some details about the assignees on this issue:

• @Kicu does not require payment (Contractor)
• @rayane-djouah requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rayane-djouah] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@zanyrenney] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

As per the comment below, regression tests are not being added in this issue and will be covered by the project wrap up. Ticking these boxes as no action currently.

[rayane-d]

Regression tests will be added as part of the project wrap-up

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021849747339555708566

[melvin-bot]

Current assignee @rayane-djouah is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

📣 @rayane-djouah 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[rayane-d]

@zanyrenney Offer accepted

[zanyrenney]

Just noting here that there seems to be no bug zero checklist as this is a new feature. Adding the payment summary as per below -

@Kicu does not require payment (Contractor)
@rayane-djouah requires payment (Needs manual offer from BZ) - paid $250 via upwork.

[melvin-bot]

@luacmartins @zanyrenney Be sure to fill out the Contact List!