Copilot - No message is shown when trying to add the owner as copilot

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v9.0.32-0
Reproducible in staging?: Y
Reproducible in production?: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

1. Login to an Expensifail account
2. Go to settings > security > add Copilot
3. Write the email you used to login

Expected Result:

You can not add your own email as a Copilot message is shown

Actual Result:

No message is shown when trying to add the owner as copilot

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6599491_1726024277915.Screen_Recording_2024-09-11_at_6.09.24_in_the_morning.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @youssef-lr (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[rushatgabhane]

@youssef-lr @joekaufmanexpensify not a blocker.

this is behind a beta. kindly assign me because I'm working on copilot project

[joekaufmanexpensify]

Sounds good! LMK if there's anything I can do to help.

[dominictb]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• No message is shown when trying to add the owner as copilot

What is the root cause of that problem?

• In:
  

  App/src/pages/settings/Security/AddDelegate/AddDelegatePage.tsx

  Line 75 in ecb629d

  (filteredOptions.recentReports?.length || 0) + (filteredOptions.personalDetails?.length || 0) !== 0 || !!filteredOptions.currentUserOption,

  
  we are adding filteredOptions.currentUserOption when calculating hasSelectableOptions param in getHeaderMessage.

• So, when searching the current signed in email, there is no message is shown.

What changes do you think we should make in order to solve the problem?

• In here and here we can remove !!filteredOptions.currentUserOption check.

What alternative solutions did you explore? (Optional)

• We can add the custom message to tell user that they cannot add the current email as the delegate:

        if(searchValue === filteredOptions.currentUserOption?.login){
            headerMessage = "Cannot add the current user as delegate"
        }

[joekaufmanexpensify]

@rushatgabhane correct me if I'm wrong here but I don't think we need to hire anyone for this issue, is that right?

[dangrous]

correct, this will be handled as part of the copilot project by @rushatgabhane

[joekaufmanexpensify]

Sounds good. TY!

[joekaufmanexpensify]

@rushatgabhane is there an ETA for a PR here?

[joekaufmanexpensify]

PR in review