Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] [HOLD for Payment 2024-09-21][Search v1] Broken tracked expenses #48942

Closed
luacmartins opened this issue Sep 10, 2024 · 8 comments
Closed
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor

Comments

@luacmartins
Copy link
Contributor

luacmartins commented Sep 10, 2024

Problem

Coming from here, users are not able to open a tracked expense on Search

Solution

Tracked expenses have reportID=0 and we're trying to redirect users to that reportID. We should instead use the transactionThreadReportID in that case

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021836407836032402528
  • Upwork Job ID: 1836407836032402528
  • Last Price Increase: 2024-09-18
Issue OwnerCurrent Issue Owner: @
@luacmartins luacmartins added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Sep 10, 2024
@luacmartins luacmartins self-assigned this Sep 10, 2024
Copy link

melvin-bot bot commented Sep 10, 2024

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@luacmartins luacmartins mentioned this issue Sep 10, 2024
50 tasks
@luacmartins luacmartins added the Reviewing Has a PR in review label Sep 10, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Sep 10, 2024
@rayane-djouah
Copy link
Contributor

Note

The production deploy automation failed: This should be on [HOLD for Payment 2024-09-21] according to production deploy checklist, confirmed in #48940 (comment)

@luacmartins luacmartins changed the title [Search v1] Broken tracked expenses [HOLD for Payment 2024-09-21][Search v1] Broken tracked expenses Sep 17, 2024
@luacmartins luacmartins added Awaiting Payment Auto-added when associated PR is deployed to production and removed Reviewing Has a PR in review labels Sep 17, 2024
@luacmartins luacmartins added Daily KSv2 and removed Weekly KSv2 labels Sep 17, 2024
@miljakljajic
Copy link
Contributor

@luacmartins @rayane-djouah whats the amount owed for this one?

@rayane-djouah
Copy link
Contributor

@miljakljajic It's a standard $250

@miljakljajic miljakljajic added the External Added to denote the issue can be worked on by a contributor label Sep 18, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for Payment 2024-09-21][Search v1] Broken tracked expenses [$250] [HOLD for Payment 2024-09-21][Search v1] Broken tracked expenses Sep 18, 2024
Copy link

melvin-bot bot commented Sep 18, 2024

Job added to Upwork: https://www.upwork.com/jobs/~021836407836032402528

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 18, 2024
Copy link

melvin-bot bot commented Sep 18, 2024

Current assignee @rayane-djouah is eligible for the External assigner, not assigning anyone new.

@miljakljajic miljakljajic removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 18, 2024
@miljakljajic
Copy link
Contributor

Thank you @rayane-djouah - I sent you an offer on upwork. Accept it and I'll get you paid by Friday 20th

@miljakljajic
Copy link
Contributor

Paid! Closing this out.

If anything else comes up, please assign a new BZ member. I am going on extended leave.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor
Projects
Archived in project
Development

No branches or pull requests

3 participants