Import categories - Column header for category is imported as a category

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.29-9
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

Precondition:

• Account is newly created.
• "File contains column headers" has not been disabled previously.

1. Go to staging.new.expensify.com
2. Go to workspace settings > Categories.
3. Click 3-dot menu.
4. Click Import spreadsheet.
5. Upload the attached csv file that has column header (category name) (attached below).
6. Map Name and Enabled.
7. Click Import.
8. Note that the column header for category is imported as a category.
9. Repeat Step 3 to 6, but now "File contains column headers" is disabled and then reenabled.
10. Click Import.
11. Note that the column header for category is not imported as a category.

Expected Result:

In Step 8, the column header for category will not be imported as a category (old dot behavior).

Actual Result:

In Step 8, the column header for category is imported as a category.

This issue only happens when "File contains column headers" has not been disabled previously (enabled by default).

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6593989_1725535163276.20240905_191458.mp4

Bug6593989_1725535163255!real_table_cat (1).csv

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @stitesExpensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @OfstadC (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[mountiny]

@filip-solecki, can you look into fixing this one? I think it's a very specific flow. It worked normally for the tester, but they had to go back and enable and disable the toggle to get to this state. They can also easily remove the categories and reupload the CSV, so I don't think this has to be a blocker now that most things are working fine.

[etCoderDysto]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Import categories - Column header for category is imported as a category

What is the root cause of that problem?

• Here we are assigning a default value true to containsHeader, and the switch is enabled

  App/src/components/ImportSpreadsheetColumns.tsx

  Line 51 in 2ef63e7

  const {containsHeader = true} = spreadsheet ?? {};

• But, in ImportedCategoriesPage we are not assigning a default value true to containsHeader, and column header is not excluded from categories that will be exported even if the switch is enabled
  

  App/src/pages/workspace/categories/ImportedCategoriesPage.tsx

  Line 28 in e1d726e

  const {containsHeader} = spreadsheet ?? {};

What changes do you think we should make in order to solve the problem?

We should assign a default value of true below too

const {containsHeader = true} = spreadsheet ?? {};

App/src/pages/workspace/categories/ImportedCategoriesPage.tsx

Line 28 in e1d726e

const {containsHeader} = spreadsheet ?? {};

What alternative solutions did you explore? (Optional)

[filip-solecki]

Sure, give me a few minutes

[filip-solecki]

Ready for review cc @mountiny @rushatgabhane

[mountiny]

Merged, we can close this now as there is nothing to pay