[HOLD for Payment 9/12] [$125] Categories - Categories explanation sentence overlaps with dropdown button

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.29-0
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

1. Launch New Expensify app.
2. Go to workspace settings > Categories.
3. Long press on category.
4. Tap Select.

Expected Result:

Categories explanation sentence will not overlap with dropdown button.

Actual Result:

Categories explanation sentence overlaps with dropdown button.
This issue also happens in Tags, Report fields, Distance rates and Taxes page.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6592370_1725411658059.ScreenRecording_09-04-2024_08-05-30_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d5633e91b68f484b
• Upwork Job ID: 1831279487956570355
• Last Price Increase: 2024-09-04

Issue Owner

Current Issue Owner: @Pujan92

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @pecanoro (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The category header text overlaps with the selected button.

What is the root cause of that problem?

The selected button has a flex1 style applied to it.

App/src/components/ButtonWithDropdownMenu/index.tsx

Lines 98 to 113 in 562d7b4

	const splitButtonWrapperStyle = isSplitButton ? [styles.flexRow, styles.justifyContentBetween, styles.alignItemsCenter] : {};
	return (
	<View style={wrapperStyle}>
	{shouldAlwaysShowDropdownMenu || options.length > 1 ? (
	<View style={[splitButtonWrapperStyle, style]}>
	<Button
	success={success}
	pressOnEnter={pressOnEnter}
	ref={dropdownButtonRef}
	onPress={(event) => (!isSplitButton ? setIsMenuVisible(!isMenuVisible) : onPress(event, selectedItem.value))}
	text={customText ?? selectedItem.text}
	isDisabled={isDisabled || !!selectedItem?.disabled}
	isLoading={isLoading}
	shouldRemoveRightBorderRadius
	style={[styles.flex1, styles.pr0]}

But the View container by default has a flex column style without any defined height. Previously, we always applied a flex row to the View style, so flex1 works fine on the button.

But now, we only apply the flex row style (along with other styles) only if isSplitButton is true.

What changes do you think we should make in order to solve the problem?

We can always apply flexRow style even though it's not needed when isSplitButton is false as mentioned here,

OR

Apply the flex1 style to the button if isSplitButton is true.

[pecanoro]

Yeah, it seems it's coming from that PR. I am going to open it for proposals so we can get it fixed asap.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01d5633e91b68f484b

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Pujan92 (External)

[melvin-bot]

Upwork job price has been updated to $125

[Pujan92]

@bernhardoj's proposal looks good to me which is to apply flexRow always for the View.

🎀👀🎀 C+ reviewed

[melvin-bot]

Current assignee @pecanoro is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[pecanoro]

Assigning @bernhardoj to the issue!

[bernhardoj]

PR is ready

[pecanoro]

Tested! Removing the blocker label

[CortneyOfstad]

Payment is set for tomorrow (based on when this went into production), so going to update the title!

[CortneyOfstad]

Both @Pujan92 @bernhardoj are paid via NewDot so will create the Payment Summary tomorrow 👍

[CortneyOfstad]

Payment Summary

@Pujan92 — to be paid $125 via NewDot
@bernhardoj — to be paid $125 via NewDot

[bernhardoj]

Requested in ND.

[JmillsExpensify]

$125 approved for @bernhardoj

[garrettmknight]

$125 approved for @Pujan92