Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable "Save and continue" for Requestor Info, Beneficial Owners, and Validate Steps until all mandatory fields have an entry #4836

Closed
kevinksullivan opened this issue Aug 25, 2021 · 8 comments
Assignees
Labels
Daily KSv2 Engineering Improvement Item broken or needs improvement. Reviewing Has a PR in review

Comments

@kevinksullivan
Copy link
Contributor

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

Break down in numbered steps

  1. Add account to freePlan beta
  2. Login to new.expensify.com
  3. Create a workspace
  4. Select Get Started in Expensify Card tab of workspace
  5. Go through VBA flow using SO credentials and note that in the three mentioned steps, Save and Continue is tappable before the required fields are filled out.

Expected Result:

Following up on #4272, we should use this same pattern to keep Save and continue disabled at every step until the required fields have an entry.

Actual Result:

Save and Continue is not disabled at all.

Notes/Photos/Videos:
These are the fields that should be mandatorily filled out before Save and Continue is enabled:

  1. Requestor Info (all fields)
    image

  2. Benefical owners (accept terms and certify information is accurate)
    image

  3. Validate Step (all fields)
    image

@jasperhuangg since you picked up the first PR for the company info step, do you want to take this?

View all open jobs on GitHub

@kevinksullivan kevinksullivan added AutoAssignerTriage Auto assign issues for triage to an available triage team member Daily KSv2 labels Aug 25, 2021
@MelvinBot
Copy link

Triggered auto assignment to @jboniface (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@MelvinBot MelvinBot removed the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Aug 25, 2021
@jboniface jboniface added Engineering and removed Daily KSv2 labels Aug 25, 2021
@MelvinBot
Copy link

Triggered auto assignment to @luacmartins (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@jboniface jboniface added Improvement Item broken or needs improvement. Daily KSv2 labels Aug 25, 2021
@jboniface jboniface removed their assignment Aug 25, 2021
@luacmartins
Copy link
Contributor

Chatted 1:1 with @jasperhuangg and I will pick up this issue as he won't be able to look at it for a few days.

@botify
Copy link

botify commented Sep 1, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@botify
Copy link

botify commented Sep 2, 2021

🚀 Deployed to staging by @Julesssss in version: 1.0.91-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@botify
Copy link

botify commented Sep 2, 2021

🚀 Deployed to staging by @luacmartins in version: 1.0.91-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@botify
Copy link

botify commented Sep 3, 2021

🚀 Deployed to production by @roryabraham in version: 1.0.92-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

1 similar comment
@botify
Copy link

botify commented Sep 3, 2021

🚀 Deployed to production by @roryabraham in version: 1.0.92-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering Improvement Item broken or needs improvement. Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

5 participants