Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Book Travel - Unable to continue setting up travel, error appears #48305

Open
6 tasks done
IuliiaHerets opened this issue Aug 29, 2024 · 94 comments
Open
6 tasks done
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Weekly KSv2

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Aug 29, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: v9.0.26-4
Reproducible in staging?: Y
Reproducible in production?: Y
Issue was found when executing this PR: #47809
Issue reported by: Applause Internal Team

Action Performed:

Go to https://staging.new.expensify.com/
Create a brand new account.
Green + > Book Travel
Enter a company address -> Press Save
Press Book Travel -> Accept the terms of service -> Press Continue

Expected Result:

Expensify Travel page opens

Actual Result:

Error appears and Unable to continue setting

Workaround:

Unknown

Platforms:

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

bandicam.2024-08-30.01-44-20-821.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01d6db9f1e6d7f6503
  • Upwork Job ID: 1829616128762264680
  • Last Price Increase: 2024-08-30
  • Automatic offers:
    • shubham1206agra | Contributor | 105189846
Issue OwnerCurrent Issue Owner: @
@IuliiaHerets IuliiaHerets added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Aug 29, 2024
@IuliiaHerets
Copy link
Author

We think that this bug might be related to #vip-travel

Copy link

melvin-bot bot commented Aug 29, 2024

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@IuliiaHerets
Copy link
Author

@joekaufmanexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@Nodebrute
Copy link
Contributor

It's a backend error User is not on Travel Beta

@joekaufmanexpensify
Copy link
Contributor

Can't reproduce, works totally fine for me. Seems like the issue was @IuliiaHerets account is not on the beta.

@joekaufmanexpensify
Copy link
Contributor

Discussing more here

@joekaufmanexpensify
Copy link
Contributor

@IuliiaHerets I got the applause.expensifail.com domain added to the beta. Going to close this for now as I don't think there is a bug here, but please reopen if you're still experiencing an issue after retesting!

@IuliiaHerets
Copy link
Author

@joekaufmanexpensify Issue still reproducible. Build - v9.0.26-4, account - [email protected]

bandicam.2024-08-30.17-28-29-312.mp4

@IuliiaHerets IuliiaHerets reopened this Aug 30, 2024
@joekaufmanexpensify
Copy link
Contributor

@IuliiaHerets can you try again in ~30 minutes? It can sometimes take an hour+ for the beta to take effect.

@IuliiaHerets
Copy link
Author

@joekaufmanexpensify QA team noticed that the issue can be reproduced with fresh accounts, after refreshing the page it works well. Build - v9.0.26-5, account - [email protected].

bandicam.2024-08-30.20-34-03-405.mp4

@joekaufmanexpensify
Copy link
Contributor

Ah, yeah. I can reproduce it when I do this with a brand new account. And then no longer can after refreshing. That said, we should still fix this as feels reasonable that some people will try to use travel soon after creating their accounts.

2024-08-30_16-20-39.mp4

@joekaufmanexpensify joekaufmanexpensify added the External Added to denote the issue can be worked on by a contributor label Aug 30, 2024
Copy link

melvin-bot bot commented Aug 30, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01d6db9f1e6d7f6503

@melvin-bot melvin-bot bot changed the title Book Travel - Unable to continue setting up travel, error appears [$250] Book Travel - Unable to continue setting up travel, error appears Aug 30, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Aug 30, 2024
Copy link

melvin-bot bot commented Aug 30, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

@joekaufmanexpensify
Copy link
Contributor

@Nodebrute are you thinking the issue here is that the beta isn't kicking in for a new account right away or something like that? As i experienced this issue, but my account is on the beta.

@Nodebrute
Copy link
Contributor

@joekaufmanexpensify This was the backend response User is not on Travel Beta. I’ll retest it to confirm.

@Nodebrute
Copy link
Contributor

@joekaufmanexpensify I’m not on the beta, so the response remains the same even after refreshing the page.
Screenshot 2024-08-31 at 1 56 00 AM

@joekaufmanexpensify
Copy link
Contributor

@mananjadhav curious if you agree that this is likely a backend issue?

@melvin-bot melvin-bot bot added the Overdue label Dec 16, 2024
@cristipaval
Copy link
Contributor

We're waiting on @shubham1206agra App PR.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Dec 16, 2024
@cristipaval
Copy link
Contributor

What's the status here, @shubham1206agra?

@melvin-bot melvin-bot bot removed the Overdue label Dec 18, 2024
@shubham1206agra
Copy link
Contributor

@cristipaval Waiting on #53845
Since I need the workspace confirmation screen.

@joekaufmanexpensify joekaufmanexpensify changed the title [Medium][$250] Book Travel - Unable to continue setting up travel, error appears [hold for #53845][$250] Book Travel - Unable to continue setting up travel, error appears Dec 19, 2024
@joekaufmanexpensify
Copy link
Contributor

Got it. Putting on hold for that one. Will unhold once that PR is out.

@joekaufmanexpensify joekaufmanexpensify added Weekly KSv2 and removed Daily KSv2 labels Dec 19, 2024
@joekaufmanexpensify
Copy link
Contributor

As an fyi, I am OOO until the new year. Please ask in slack if anything urgent BZ related comes up. Otherwise, I will continue assisting when I return!

@melvin-bot melvin-bot bot added the Overdue label Dec 30, 2024
@joekaufmanexpensify
Copy link
Contributor

Still held

@melvin-bot melvin-bot bot removed the Overdue label Dec 30, 2024
@joekaufmanexpensify
Copy link
Contributor

Still on hold

@joekaufmanexpensify
Copy link
Contributor

Same

@joekaufmanexpensify
Copy link
Contributor

Still blocked on the above PR. Hope to be unblocked soon.

@cristipaval
Copy link
Contributor

The PR just got merged. Should get deployed today.

@joekaufmanexpensify
Copy link
Contributor

Blocking PR is out to prod. @shubham1206agra @cristipaval are we good to un-hold this and finish up this issue's PR?

@cristipaval cristipaval changed the title [hold for #53845][$250] Book Travel - Unable to continue setting up travel, error appears [$250] Book Travel - Unable to continue setting up travel, error appears Jan 27, 2025
@cristipaval
Copy link
Contributor

Removed the hold. @shubham1206agra, what's the status here?

@shubham1206agra
Copy link
Contributor

I will ready the PR by tomorrow

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Jan 29, 2025
@joekaufmanexpensify
Copy link
Contributor

TY!

@stitesExpensify
Copy link
Contributor

Hey @shubham1206agra is the PR up?

@shubham1206agra
Copy link
Contributor

@stitesExpensify Here #53753

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Weekly KSv2
Projects
Status: Medium - NewDot MVP - Feb '25
Development

No branches or pull requests

10 participants