[HOLD for payment 2024-10-24] [$250] When using the account switcher on iOS there is no safe area

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.26-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @AndrewGable
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1724946621382309

Action Performed:

1.Launch the app and login
2. Tap settings > Account switcher arrows

Expected Result:

No display issues and modal view is scrollable

Actual Result

There is no safe area when using the account switcher

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021831817133463086139
• Upwork Job ID: 1831817133463086139
• Last Price Increase: 2024-09-05
• Automatic offers:
• nkdengineer | Contributor | 103922536

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @RachCHopkins

[melvin-bot]

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[dangrous]

cc @rushatgabhane on this one

[RachCHopkins]

Launch the app

Which app? Hybrid app?

Tap settings > Account switcher arrows

I don't know what this means.

Can we get some more detailed instructions for testing/reproducing, please?

[RachCHopkins]

Ok, looks like it's:

Launch the New Expensify app.
Go to Settings > tap username at the top to switch accounts

I can confirm I can't scroll in the list. I'm not sure what "safe area" means, but if I try to select my own account, the app crashes.

[RachCHopkins]

Waiting to see what @rushatgabhane has to add here! However this is supposed to work, it's definitely not working like it should.

[dangrous]

safe area means the area where default phone interface stuff should be (like in the screenshot, it's overlapping with the wifi symbols, etc.)\

I think we can go ahead and assign @rushatgabhane here for a solution! I can also take this on from the engineering side

[melvin-bot]

@dangrous, @rushatgabhane, @RachCHopkins Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[dangrous]

We might want to make this external to clear @rushatgabhane's plate since a contributor should be able to propose

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021831817133463086139

[melvin-bot]

Current assignee @rushatgabhane is eligible for the External assigner, not assigning anyone new.

[RachCHopkins]

@dangrous do we need to remove @rushatgabhane?

[ItxAltaf]

You can use SafeAreaView property if you are working with react native

[melvin-bot]

📣 @ItxAltaf! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[ItxAltaf]

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~01ff545e274abdf999?mp_source=share

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[kishan-dhankecha]

You can add a SafeArea widget as the scaffold body. So that AppBar and such things won't affect with the padding, it is also safe for content.

[nkdengineer]

@s77rt The PR is ready #49051.

[melvin-bot]

This issue has not been updated in over 15 days. @dangrous, @s77rt, @RachCHopkins, @nkdengineer eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[s77rt]

Still trying to fix a performance issue

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[dangrous]

Just to pull it out here - that ^ is not a regression, correct? It's an existing bug.

[s77rt]

Yes technically it's an existing bug in PopoverMenu which is what we opted to use in the AccountSwitcher.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.49-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• use PopoverMenu for account switcher modal #49051

If no regressions arise, payment will be issued on 2024-10-24. 🎊

For reference, here are some details about the assignees on this issue:

• @s77rt requires payment through NewDot Manual Requests
• @nkdengineer requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@s77rt] The PR that introduced the bug has been identified. Link to the PR:
• [@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@s77rt] Determine if we should create a regression test for this bug.
• [@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@RachCHopkins] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[s77rt]

• The PR that introduced the bug has been identified: Delegate access: Add account switcher #47338
• The offending PR has been commented on: Delegate access: Add account switcher #47338 (comment)
• A discussion in #expensify-bugs has been started: Not needed
• Determine if we should create a regression test for this bug: No (edge case)

[RachCHopkins]

Payment Summary:

• Contributor: @nkdengineer paid $250 via Upwork
• Contributor+: @s77rt to be paid $250 via NewDot Manual Request
  Upwork job here

[RachCHopkins]

Contributor has been paid, the contract has been completed, and the Upwork post has been closed.

[JmillsExpensify]

$250 approved for @s77rt

[tgolen]

Reopening so @RachCHopkins can complete the BZ checklist. Can you please copy @s77rt's answers to the checklist and finish it out?

[RachCHopkins]

Sorry @tgolen I don't understand - there is no regression test for me to set up?

Did you need me to change @s77rt's checklist bullet points to check boxes and tick them?

[tgolen]

Sorry, @RachCHopkins. I'm getting my footing on these and I'll be making some improvements to the BZ checklist so that it's more clear and works a little better (see https://github.com/Expensify/Expensify/issues/438990).

[tgolen]

I'll just close this for now.