Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android Native: The bottom half of the camera doesn't work (i.e. shutter, flash and file upload buttons) #47911

Closed
1 of 6 tasks
muttmuure opened this issue Aug 23, 2024 · 18 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Monthly KSv2 Reviewing Has a PR in review

Comments

@muttmuure
Copy link
Contributor

muttmuure commented Aug 23, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: Android 9.0.24
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @jliexpensify
Slack conversation: https://expensify.slack.com/archives/C05LX9D6E07/p1724402419158759

Action Performed:

Break down in numbered steps

  1. Click on "Submit expense"
  2. Camera opens and "you need to give permissions" is shown
  3. Click on "Continue" and notice nothing happens
  4. Go to Android camera settings and give permissions to Expensify app
  5. Permissions screen disappears
  6. Click on shutter, flash and upload file buttons - nothing happens

Expected Result:

Describe what you think should've happened

Shutter, flash and file upload buttons are responsive

Actual Result:

Describe what actually happened

They are not

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

@muttmuure muttmuure added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Aug 23, 2024
Copy link

melvin-bot bot commented Aug 23, 2024

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@muttmuure muttmuure changed the title The bottom half of the camera doesn't work (i.e. shutter, flash and file upload buttons) Android Native: The bottom half of the camera doesn't work (i.e. shutter, flash and file upload buttons) Aug 23, 2024
@hannojg
Copy link
Contributor

hannojg commented Aug 23, 2024

Hanno from Margelo here, who built the used react-native-vision-camera library. Feel free to assign me 👋

@Julesssss Julesssss self-assigned this Aug 23, 2024
@Julesssss
Copy link
Contributor

Julesssss commented Aug 23, 2024

I can reproduce. Perhaps the bug is within the permission logic that occurs before the camera is launched.

Pixel 8A, Android 14, existing account that has just signed in.

@hannojg
Copy link
Contributor

hannojg commented Aug 23, 2024

Yes, thats likely. We are using a very outdated version of rn-vision-camera and I believe this has been fixed already. I am currently looking in upgrading rn-vision-camera!

@hannojg
Copy link
Contributor

hannojg commented Aug 23, 2024

what phone model + android version are you using @Julesssss ?

@Julesssss
Copy link
Contributor

Just edited my comment. Pixel 8a, Android 14

@hannojg
Copy link
Contributor

hannojg commented Aug 23, 2024

Regression was introduced in:

looking into a fix within react-native-pager-view now…

@hannojg
Copy link
Contributor

hannojg commented Aug 23, 2024

(So its not a bug in react-native-vision-camera / an android 14 permission issue!)

@hannojg
Copy link
Contributor

hannojg commented Aug 23, 2024

The issue was already reported in the library here:

I found the same fix as the library maintainer. Will propose a patch PR until this is fixed in the library!

@parasharrajat
Copy link
Member

@Julesssss Should we go with the Patch or wait for the lib fix?

@cristipaval
Copy link
Contributor

FYI: We reverted the library upgrade in the meantime, to fix 3 blockers and unblock the deploy.

@jliexpensify
Copy link
Contributor

@cristipaval @hannojg @muttmuure @Julesssss the camera is working again!

@parasharrajat
Copy link
Member

@hannojg In that case, we don't that PR.

@parasharrajat
Copy link
Member

Please assign me to the issue as I am C+ on the PR @Julesssss

@Julesssss
Copy link
Contributor

Please assign me to the issue as I am C+ on the PR @Julesssss

Done

@muttmuure
Copy link
Contributor Author

@cristipaval @hannojg @muttmuure @Julesssss the camera is working again!

Hooray!

@melvin-bot melvin-bot bot removed the Weekly KSv2 label Sep 19, 2024
@melvin-bot melvin-bot bot added the Monthly KSv2 label Sep 19, 2024
Copy link

melvin-bot bot commented Sep 19, 2024

This issue has not been updated in over 15 days. @Julesssss, @hannojg, @parasharrajat, @muttmuure eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@parasharrajat
Copy link
Member

Looks like it is solved. we can close this issue @muttmuure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Monthly KSv2 Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

6 participants