[Hold for payment 2021-09-08] Missing Translation in CompanyStep

[akshayasalvi]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Set your language to Spansih
2. Navigate to /bank-account/company page
3. Enter the details of the company form and keep one or two fields invalid, say Tax ID.
4. Click on Submit & continue
5. A modal will popup with english text

Expected Result:

Content in the ConfirmModal should be translated.

Actual Result:

ConfirmModal in CompanyStep has hardcoded english strings.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number:
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @JmillsExpensify (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[akshayasalvi]

Proposed Solution

We can create three strings in en.js and es.js

en: {
	companyStep: {
		confirmModalTitle: 'Are you sure?',
		confirmModalPrompt: 'Please double check any highlighted fields and try again.'
		confirmModalConfirmText: 'Got it'
	}
}

// Same for es.js in Spanish translation 

and update CompanyStep with the following coe:

<ConfirmModal
    title={this.props.translate('companyStep.confirmModalTitle')}
    onConfirm={() => this.setState({isConfirmModalOpen: false})}
    prompt={this.props.translate('companyStep.confirmModalPrompt')}
    isVisible={this.state.isConfirmModalOpen}
    confirmText={this.props.translate('companyStep.confirmModalConfirmText')}
    shouldShowCancelButton={false}
/>

[JmillsExpensify]

Sounds great! I've created an upwork job here: https://www.upwork.com/jobs/~013d78575b95e8dfdf. Your proposal will be reviewed by our team shortly.

[MelvinBot]

Triggered auto assignment to @iwiznia (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[iwiznia]

Proposal looks good to me, @JmillsExpensify you can hire @akshayasalvi

@chiragsalian, @MitchExpensify, @marcaaron please remember all copy, numbers and dates need to go through one of the localization methods (this was added in https://github.com/Expensify/App/pull/4483/files#diff-40ada854d0b6039d4db7da6cede12f7be0cf7d113cc16c8cbc638af4bd0121d4R260)

[chiragsalian]

Ah whoops my bad, totally missed that. Thanks for the catch and fix.

[MelvinBot]

@iwiznia, @JmillsExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[iwiznia]

This is merged already Melvin

[JmillsExpensify]

Quick update: Chatted with @akshayasalvi yesterday and also successfully hired in Upwork.

[JmillsExpensify]

Closed out the Upwork job, as PR has been merged for 7 days and no specific issues with this PR. Thank you @akshayasalvi!

[akshayasalvi]

Thank you @JmillsExpensify