Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LHN - App crashes after tap on any chat in LHN #47134

Closed
2 of 6 tasks
IuliiaHerets opened this issue Aug 9, 2024 · 17 comments
Closed
2 of 6 tasks

LHN - App crashes after tap on any chat in LHN #47134

IuliiaHerets opened this issue Aug 9, 2024 · 17 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Aug 9, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.18-7
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4838537
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

  1. Open iOS App
  2. Login with any account
  3. Tap to any chat in LHN

Expected Result:

Chat opens correctly

Actual Result:

App crashes after tap on any chat in LHN

Workaround:

Unknown

Platforms:

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

log_crash.txt

Bug6566315_1723174148428.iOS-App-Crashes-tap-chat-lhn.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @trjExpensify
@IuliiaHerets IuliiaHerets added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API labels Aug 9, 2024
Copy link

melvin-bot bot commented Aug 9, 2024

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Aug 9, 2024

Triggered auto assignment to @techievivek (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Aug 9, 2024
Copy link
Contributor

github-actions bot commented Aug 9, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@IuliiaHerets
Copy link
Author

We think that this bug might be related to #vip-vsb

@techievivek
Copy link
Contributor

I am on the latest main, and I can't reproduce this. Is this already fixed?

@techievivek
Copy link
Contributor

Screen.Recording.2024-08-09.at.6.09.08.PM.mov

Tried once again on lastest main, and couldn't reproduce it.

@techievivek
Copy link
Contributor

Also, asked in #open-source channel to see if someone can reproduce it https://expensify.slack.com/archives/C01GTK53T8Q/p1723202882608139

@IuliiaHerets IuliiaHerets changed the title iOS - LHN - App crashes after tap on any chat in LHN LHN - App crashes after tap on any chat in LHN Aug 9, 2024
@Beamanator
Copy link
Contributor

A few people are experiencing this - https://expensify.slack.com/archives/C049HHMV9SM/p1723190961011019

But not sure if anyone has reproduced in main

@trjExpensify
Copy link
Contributor

Thread discussion ongoing, @AndrewGable might have an idea.

@roryabraham roryabraham self-assigned this Aug 9, 2024
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Hourly KSv2 labels Aug 9, 2024
@roryabraham roryabraham removed the DeployBlocker Indicates it should block deploying the API label Aug 9, 2024
@roryabraham
Copy link
Contributor

PR with a fix is ready to go

@roryabraham
Copy link
Contributor

this should be fixed in 9.0.18-8: https://github.com/Expensify/App/actions/runs/10323822881

@Beamanator
Copy link
Contributor

Woohoo!! Working in staging again!

@Beamanator Beamanator removed the DeployBlockerCash This issue or pull request should block deployment label Aug 9, 2024
@m-natarajan
Copy link

Issue fixed

RPReplay_Final1723231189.MP4

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Aug 12, 2024
@melvin-bot melvin-bot bot changed the title LHN - App crashes after tap on any chat in LHN [HOLD for payment 2024-08-19] LHN - App crashes after tap on any chat in LHN Aug 12, 2024
Copy link

melvin-bot bot commented Aug 12, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Aug 12, 2024
Copy link

melvin-bot bot commented Aug 12, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.18-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-08-19. 🎊

Copy link

melvin-bot bot commented Aug 12, 2024

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@techievivek / @roryabraham] The PR that introduced the bug has been identified. Link to the PR:
  • [@techievivek / @roryabraham] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • [@techievivek / @roryabraham] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • [@techievivek / @roryabraham] Determine if we should create a regression test for this bug.
  • [@techievivek / @roryabraham] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@techievivek
Copy link
Contributor

Going to close this since it's deployed to PROD and no payments or BZ checklist if required for this.

@techievivek techievivek removed the Awaiting Payment Auto-added when associated PR is deployed to production label Aug 12, 2024
@techievivek techievivek changed the title [HOLD for payment 2024-08-19] LHN - App crashes after tap on any chat in LHN LHN - App crashes after tap on any chat in LHN Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2
Projects
None yet
Development

No branches or pull requests

6 participants