Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenApp fail/partially fails for Jason's heavy approver account on a throttled connection #47093

Closed
6 tasks
muttmuure opened this issue Aug 8, 2024 · 40 comments
Closed
6 tasks
Assignees
Labels
AutoAssignerNewDotQuality Used to assign quality issues to engineers Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@muttmuure
Copy link
Contributor

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number:
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @JmillsExpensify
Slack conversation: https://expensify.slack.com/archives/C05LX9D6E07/p1723132613137659?thread_ts=1722970682.900369&cid=C05LX9D6E07

Action Performed:

Break down in numbered steps

Use an account that approves a lot of reports (@JmillsExpensify's account)
Go to new.expensify.com
Open the Network console and enable 3G throttling
Log in

Expected Result:

Describe what you think should've happened

OpenApp completes successfully and all data is visible in Jason's account

Actual Result:

Describe what actually happened

The app shows a partially loaded state, or nothing is loaded at all

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Using clear cache and restart in the Troubleshoot menu loads the data on a second try

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

@muttmuure muttmuure added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. AutoAssignerNewDotQuality Used to assign quality issues to engineers labels Aug 8, 2024
@muttmuure muttmuure moved this to CRITICAL in [#whatsnext] #quality Aug 8, 2024
Copy link

melvin-bot bot commented Aug 8, 2024

Triggered auto assignment to @francoisl (AutoAssignerNewDotQuality)

@melvin-bot melvin-bot bot added the Weekly KSv2 label Aug 8, 2024
Copy link

melvin-bot bot commented Aug 8, 2024

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot removed the Weekly KSv2 label Aug 8, 2024
@muttmuure
Copy link
Contributor Author

muttmuure commented Aug 8, 2024

How do I handle an AutoAssignerNewDotQuality issue I've been assigned as part of #newdot-quality?

@johncschuster
Copy link
Contributor

Oh! This is new! Thanks for the SO, Matt! I'll dig into this proper in the AM.

@melvin-bot melvin-bot bot added the Overdue label Aug 12, 2024
Copy link

melvin-bot bot commented Aug 12, 2024

@francoisl, @johncschuster Whoops! This issue is 2 days overdue. Let's get this updated quick!

@johncschuster
Copy link
Contributor

Sorry I haven't gotten to dive into this yet. I've got it on my plate first thing tomorrow.

@melvin-bot melvin-bot bot removed the Overdue label Aug 12, 2024
@francoisl
Copy link
Contributor

Matt's last update in Slack here mentioned that Eduardo from Callstack started investigating this one, should we co-assign?

@muttmuure
Copy link
Contributor Author

@gedu please could you comment so we can assign you?

@melvin-bot melvin-bot bot added the Overdue label Aug 16, 2024
@johncschuster
Copy link
Contributor

Bumped in Slack 👍

@melvin-bot melvin-bot bot removed the Overdue label Aug 16, 2024
@gedu
Copy link
Contributor

gedu commented Aug 17, 2024

Hi, I’m Edu from Callstack, I can take a look at this issue

@johncschuster
Copy link
Contributor

Not overdue. This was just assigned.

@melvin-bot melvin-bot bot removed the Overdue label Aug 19, 2024
Copy link

melvin-bot bot commented Aug 22, 2024

@gedu @francoisl @johncschuster this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@melvin-bot melvin-bot bot added the Overdue label Aug 22, 2024
@johncschuster
Copy link
Contributor

@gedu how's this going?

@melvin-bot melvin-bot bot added the Overdue label Sep 23, 2024
Copy link

melvin-bot bot commented Sep 24, 2024

@gedu, @francoisl, @johncschuster Whoops! This issue is 2 days overdue. Let's get this updated quick!

@johncschuster
Copy link
Contributor

Not overdue. @gedu is regularly working on this (updates in the PR)

@melvin-bot melvin-bot bot removed the Overdue label Sep 24, 2024
@muttmuure muttmuure changed the title OpenApp fail/partially fails for Jason's heavy approver account on a throttled connection HOLD OpenApp fail/partially fails for Jason's heavy approver account on a throttled connection Sep 26, 2024
@melvin-bot melvin-bot bot added the Overdue label Sep 27, 2024
@francoisl
Copy link
Contributor

Not overdue, the PR is still being actively worked on.

@melvin-bot melvin-bot bot removed the Overdue label Sep 30, 2024
Copy link

melvin-bot bot commented Sep 30, 2024

@gedu, @francoisl, @johncschuster Huh... This is 4 days overdue. Who can take care of this?

@melvin-bot melvin-bot bot added the Overdue label Oct 2, 2024
@johncschuster
Copy link
Contributor

Still not overdue. Steady progress is being made in the PR

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Oct 2, 2024
@mountiny mountiny changed the title HOLD OpenApp fail/partially fails for Jason's heavy approver account on a throttled connection OpenApp fail/partially fails for Jason's heavy approver account on a throttled connection Oct 7, 2024
@mountiny
Copy link
Contributor

mountiny commented Oct 7, 2024

Not on hold anymore the dedupe PR was merged

@johncschuster
Copy link
Contributor

Thanks, @mountiny!

@melvin-bot melvin-bot bot removed the Overdue label Oct 7, 2024
@mountiny
Copy link
Contributor

mountiny commented Oct 8, 2024

@gedu what are the next steps on this one, do we need to de-dupe the OpenApp?

@melvin-bot melvin-bot bot added the Overdue label Oct 10, 2024
Copy link

melvin-bot bot commented Oct 11, 2024

@gedu, @francoisl, @johncschuster Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@johncschuster
Copy link
Contributor

@gedu bump on the above!

@melvin-bot melvin-bot bot removed the Overdue label Oct 11, 2024
@mountiny
Copy link
Contributor

We actually merged this PR #50258 which dedupes the OpenApp so we should be better to test this one again soon

@melvin-bot melvin-bot bot added the Overdue label Oct 14, 2024
@gedu
Copy link
Contributor

gedu commented Oct 14, 2024

Hey, sorry, I don't think there's a specific fix for this one. There were multiple requests failing and some internal errors. Is it still reproducible? Can we get some steps?

@melvin-bot melvin-bot bot removed the Overdue label Oct 14, 2024
@mountiny
Copy link
Contributor

I think we can close this one and just see if @JmillsExpensify can still experience these issues and start new more precise investigation if so (not sure if there is much to get out of this one)

@github-project-automation github-project-automation bot moved this from CRITICAL to Done in [#whatsnext] #quality Oct 14, 2024
@JmillsExpensify
Copy link

Sounds good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AutoAssignerNewDotQuality Used to assign quality issues to engineers Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
Development

No branches or pull requests

6 participants