Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Android - Mark down - App crashes when deleting text with mark down in a sentence with heading #46908

Closed
1 of 6 tasks
lanitochka17 opened this issue Aug 6, 2024 · 56 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor

Comments

@lanitochka17
Copy link

lanitochka17 commented Aug 6, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.17-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

  • Device keyboard must be Samsung keyboard
  • Issue is not reproducible with Gboard
  1. Launch New Expensify app
  2. Go to chat
  3. Type # hey hey
  4. Double tap to select and highlight the second word with mark down _ hey _
  5. Tap delete on Samsung keyboard

Expected Result:

App will not crash

Actual Result:

App crashes
This issue is only reproducible with Samsung keyboard and not Gboard

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6563572_1722962062565.Screen_Recording_20240807_002944_Device_care.mp4

logs (2).txt

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01bc8d3436a587add7
  • Upwork Job ID: 1821616561702134137
  • Last Price Increase: 2024-08-29
  • Automatic offers:
    • alitoshmatov | Reviewer | 103818157
    • wildan-m | Contributor | 103818158
Issue OwnerCurrent Issue Owner: @isabelastisser
@lanitochka17 lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Aug 6, 2024
Copy link

melvin-bot bot commented Aug 6, 2024

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@lanitochka17
Copy link
Author

We think that this bug might be related to #Live Markdown

@lanitochka17
Copy link
Author

@isabelastisser FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@isabelastisser isabelastisser added External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors labels Aug 8, 2024
@melvin-bot melvin-bot bot changed the title Android - Mark down - App crashes when deleting text with mark down in a sentence with heading [$250] Android - Mark down - App crashes when deleting text with mark down in a sentence with heading Aug 8, 2024
Copy link

melvin-bot bot commented Aug 8, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01bc8d3436a587add7

@melvin-bot melvin-bot bot added the Overdue label Aug 8, 2024
Copy link

melvin-bot bot commented Aug 8, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (External)

@BartoszGrajdek
Copy link
Contributor

cc @tomekzaw 👀

@isabelastisser
Copy link
Contributor

No proposals yet.

Copy link

melvin-bot bot commented Aug 12, 2024

@isabelastisser, @alitoshmatov Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Copy link

melvin-bot bot commented Aug 14, 2024

@isabelastisser, @alitoshmatov Huh... This is 4 days overdue. Who can take care of this?

@isabelastisser
Copy link
Contributor

Still waiting for proposals.

Copy link

melvin-bot bot commented Aug 15, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

Copy link

melvin-bot bot commented Aug 16, 2024

@isabelastisser, @alitoshmatov 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@alitoshmatov
Copy link
Contributor

Waiting for proposals

@melvin-bot melvin-bot bot removed the Overdue label Aug 17, 2024
Copy link

melvin-bot bot commented Aug 20, 2024

@isabelastisser @alitoshmatov this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@melvin-bot melvin-bot bot added the Overdue label Aug 20, 2024
Copy link

melvin-bot bot commented Aug 20, 2024

@isabelastisser, @alitoshmatov Whoops! This issue is 2 days overdue. Let's get this updated quick!

@isabelastisser
Copy link
Contributor

No proposals yet.

Copy link

melvin-bot bot commented Aug 22, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@isabelastisser
Copy link
Contributor

@alitoshmatov @wildan-m, can you please provide an update? Thanks!

@wildan-m
Copy link
Contributor

@isabelastisser discussing optimal approach to avoid duplicate calls in upstream. Expensify/react-native-live-markdown#469 (comment)

@tomekzaw
Copy link
Contributor

Expensify/react-native-live-markdown#469 has just been merged

@wildan-m
Copy link
Contributor

Thank you, @tomekzaw!

@alitoshmatov @neil-marcellini Should we simply update the version in the E/App to apply it? I see that the live markdown version in E/App is not the latest. Are there specific steps to follow?

@tomekzaw
Copy link
Contributor

There's already a PR that bumps react-native-live-markdown here: #48626

@wildan-m
Copy link
Contributor

@tomekzaw can we bump the version to 0.1.140 there or we should temporarily create patch until that PR closed?

@tomekzaw
Copy link
Contributor

Let's avoid patches and bump directly to latest if possible

Copy link

melvin-bot bot commented Sep 12, 2024

@wildan-m, @neil-marcellini, @isabelastisser, @alitoshmatov 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@tomekzaw
Copy link
Contributor

Should be fixed with #48626

@alitoshmatov
Copy link
Contributor

Waiting for react-native-live-markdown bump on #48626

@melvin-bot melvin-bot bot removed the Overdue label Sep 12, 2024
@mvtglobally
Copy link

Issue not reproducible during KI retests. (First week)

Copy link

melvin-bot bot commented Sep 16, 2024

@wildan-m, @neil-marcellini, @isabelastisser, @alitoshmatov Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label Sep 16, 2024
@wildan-m
Copy link
Contributor

Not overdue, The fix PR passed the test and is now live in production #48626 (comment).

@alitoshmatov
Copy link
Contributor

Not overdue.

FYI: I was only involved on selecting proposal, I was not involved in reviewing corresponding PRs

@melvin-bot melvin-bot bot removed the Overdue label Sep 17, 2024
@neil-marcellini
Copy link
Contributor

What's the next step here? What are we waiting for?

@alitoshmatov
Copy link
Contributor

We are in a regression period now. Solution went into production on 16th september

@neil-marcellini neil-marcellini added the Awaiting Payment Auto-added when associated PR is deployed to production label Sep 18, 2024
@isabelastisser
Copy link
Contributor

@alitoshmatov, it looks like payment automation failed. I see that it went into production three days ago. Is this ready for payment now? Do we need a regression test? Thanks!

@melvin-bot melvin-bot bot added the Overdue label Sep 23, 2024
@isabelastisser
Copy link
Contributor

@neil-marcellini @alitoshmatov, it looks like this is ready for payment. Do we need a regression test?

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Overdue Daily KSv2 labels Sep 23, 2024
@isabelastisser
Copy link
Contributor

The payments were processed in Upwork. All set!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor
Projects
Status: HIGH
Development

No branches or pull requests

9 participants