Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-08-07] [Search v2.1] [App] Create Type filter #46028

Closed
luacmartins opened this issue Jul 23, 2024 · 11 comments
Closed

[HOLD for payment 2024-08-07] [Search v2.1] [App] Create Type filter #46028

luacmartins opened this issue Jul 23, 2024 · 11 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Weekly KSv2

Comments

@luacmartins
Copy link
Contributor

luacmartins commented Jul 23, 2024

Implement this section of the design doc for the Type filter only!

cc @adamgrzybowski @Kicu @WojtekBoman @Guccio163

Issue OwnerCurrent Issue Owner: @joekaufmanexpensify
@luacmartins luacmartins added Daily KSv2 NewFeature Something to build that is a new item. labels Jul 23, 2024
@luacmartins luacmartins self-assigned this Jul 23, 2024
Copy link

melvin-bot bot commented Jul 23, 2024

Triggered auto assignment to @joekaufmanexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Jul 23, 2024
@luacmartins
Copy link
Contributor Author

@Kicu is already working on this one!

@luacmartins luacmartins added Daily KSv2 and removed Weekly KSv2 labels Jul 23, 2024
@joekaufmanexpensify
Copy link
Contributor

Sounds good! @Kicu mind commenting here so we can assign you, and linking the PR (if there is one)

@Kicu
Copy link
Contributor

Kicu commented Jul 24, 2024

hey yes, I am working on this already 😄 in this draft #46022

@joekaufmanexpensify
Copy link
Contributor

Sweet, TY! Linked this issue to that PR too.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Jul 24, 2024
@joekaufmanexpensify
Copy link
Contributor

PR in review

@luacmartins
Copy link
Contributor Author

I'm gonna close this issue since we'll handle payment in #46029

@github-project-automation github-project-automation bot moved this from Release 3: Fall 2024 (Nov) to Done in [#whatsnext] #expense Jul 29, 2024
@joekaufmanexpensify
Copy link
Contributor

Sounds good. TY!

@luacmartins luacmartins changed the title [Search v2] [App] Create Type filter [Search v2.1] [App] Create Type filter Jul 31, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Jul 31, 2024
@melvin-bot melvin-bot bot added the Awaiting Payment Auto-added when associated PR is deployed to production label Jul 31, 2024
@melvin-bot melvin-bot bot changed the title [Search v2.1] [App] Create Type filter [HOLD for payment 2024-08-07] [Search v2.1] [App] Create Type filter Jul 31, 2024
Copy link

melvin-bot bot commented Jul 31, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jul 31, 2024
Copy link

melvin-bot bot commented Jul 31, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.14-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-08-07. 🎊

For reference, here are some details about the assignees on this issue:

  • @Kicu does not require payment (Contractor)

Copy link

melvin-bot bot commented Jul 31, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@Kicu] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@joekaufmanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Weekly KSv2
Projects
Status: Done
Development

No branches or pull requests

3 participants