Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CRITICAL] [Advanced Approval Workflows] Implement utils that transform data between backend and frontend (convertApprovalWorkflowToPolicyEmployees & convertPolicyEmployeesToApprovalWorkflows functions) #45957

Closed
tgolen opened this issue Jul 22, 2024 · 6 comments
Assignees
Labels

Comments

@tgolen
Copy link
Contributor

tgolen commented Jul 22, 2024

Coming from: #wave-control: advanced approval + workflows polish

Issue OwnerCurrent Issue Owner: @blazejkustra
@blazejkustra
Copy link
Contributor

Hey! I’m Błażej Kustra from Software Mansion, an expert agency, and I’d like to work on this issue!

@allgandalf
Copy link
Contributor

I was assigned the related PR, does it require a C+ review?

@blazejkustra
Copy link
Contributor

@tgolen Functions implemented in this PR aren't used anywhere yet, that's why I think we do not need C+ review for this one.

@blazejkustra
Copy link
Contributor

blazejkustra commented Jul 25, 2024

Same thing for this PR, I added onyx actions for the future PRs but for now these onyx actions are unused.

@melvin-bot melvin-bot bot removed the Weekly KSv2 label Aug 19, 2024
Copy link

melvin-bot bot commented Aug 19, 2024

This issue has not been updated in over 15 days. @tgolen, @blazejkustra eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot added the Monthly KSv2 label Aug 19, 2024
@tgolen
Copy link
Contributor Author

tgolen commented Aug 30, 2024

Monthly Update

  • There was no C+ review of this PR and the work has been completed. I will close this out.

@tgolen tgolen closed this as completed Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants