[$500] Android- Workspace- Unable to open workspaces that out of view after creating new workspace

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.9.1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Open the app and log in with an account that has several workspaces > 5 or create them
2. Navigate to the account settings > Workspaces
3. Create a new workspace
4. Return to the list of workspaces
5. Scroll down until the first 4 workspaces out of view
6. Open any workspace that in a view

Expected Result:

User is able to open any workspace

Actual Result:

User is unable to open workspaces that require to scroll to get accessed after creating a new workspace

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6546506_1721327150029.video_2024-07-18_14-24-13.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~012f764fe91b1e3b3b
• Upwork Job ID: 1814333041047712558
• Last Price Increase: 2024-08-15

Issue Owner

Current Issue Owner: @parasharrajat

[melvin-bot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@puneetlath FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 1

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~012f764fe91b1e3b3b

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[melvin-bot]

@puneetlath, @parasharrajat Whoops! This issue is 2 days overdue. Let's get this updated quick!

[kabeer95]

Proposal

Problem Statement

After creating a new workspace, users are unable to open workspaces that are out of view, requiring scrolling to access them.

Root Cause

The root cause of this problem is that the code is not properly updating the workspace list after creating a new workspace, causing the out-of-view workspaces to become inaccessible.

##Proposed Solution
To solve this problem, I propose updating the code to ensure that the workspace list is properly updated after creating a new workspace, allowing users to access all workspaces, including those that are out of view.

Changes To implement this solution, we need to make the following changes:

// Update the workspace list after creating a new workspace
public void createNewWorkspace(Workspace newWorkspace) {
    // Add the new workspace to the list
    workspaces.add(newWorkspace);
    
    // Refresh the workspace list
    workspaceListAdapter.notifyDataSetChanged();
}

// Ensure the workspace list is refreshed after creating a new workspace
public void onResume() {
    super.onResume();
    workspaceListAdapter.notifyDataSetChanged();
}

Expected Result

Users should be able to open any workspace, including those that are out of view, after creating a new workspace.

Actual Result

Users are unable to open workspaces that require scrolling to access after creating a new workspace.

Alternative Solutions

Implementing a lazy loading mechanism to load workspaces only when they come into view, but this may cause performance issues.
Using a different data structure to store the workspace list, but this may require significant changes to the existing codebase.

[parasharrajat]

@kabeer95 Please use the standard template as it is.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[puneetlath]

Still waiting for proposals.

[melvin-bot]

@puneetlath, @parasharrajat Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[parasharrajat]

Need more proposals.

[melvin-bot]

Upwork job price has been updated to $500

[Kureev]

Hi, I'm Alexey from Margelo, an expert agency and I can work on this issue.

Prev worked on:

• LHN-Reports/chats missing in LHN when logging in to account in "#focus" priority mode #43612
• Log unhandled promise rejections to the server #46173

[melvin-bot]

@puneetlath, @Kureev, @parasharrajat Huh... This is 4 days overdue. Who can take care of this?

[CyberAndrii]

FYI, I can reproduce this and have a guess at what it could be. I'll test it tomorrow and let you all know.

[parasharrajat]

Awesome, let us know.

[CyberAndrii]

I think it is similar to facebook/react-native#44643 and facebook/react-native#36504. Using onPressIn or onPressOut here seems to fix it, but it isn't a valid solution in this case. I'm not sure if I'll be able to help with this any further, so feel free to have someone else take this on.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[puneetlath]

@Kureev have you had a chance to look at it?

[melvin-bot]

@puneetlath @Kureev @parasharrajat this issue is now 4 weeks old, please consider:

• Finding a contributor to fix the bug
• Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
• If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

[melvin-bot]

@puneetlath, @Kureev, @parasharrajat Whoops! This issue is 2 days overdue. Let's get this updated quick!

[chrispader]

i'm going to take this over from @Kureev, because he is busy with other tasks right now

[parasharrajat]

Sounds good @chrispader. Looking forward to it.

[chrispader]

I cannot reproduce this on main on neither of two physical Android devices:

Samsung S10e:

Screen_Recording_20240820_115311_New.Expensify.Dev.mp4

Huawei P smart 2019:

FILE.2024-08-20.11_51_18.mov

[parasharrajat]

@chrispader Is there any specific that you need from tester @lanitochka17 to be able to reproduce this?

[chrispader]

@lanitochka17 are there any more steps i need to make in order to be able to reproduce this?

[lanitochka17]

@parasharrajat @chrispader the same steps mentioned in the OP. Issue is still reproduce

video_2024-08-20_12-01-24.mp4

accounts: [email protected] (the one I tested today) and [email protected] (the one from the OP)

[chrispader]

Still not reproducible on my accounts with the following devices:

• Samsung S10e (Android 12)
• Huawei P smart 2019 (Android 11)
• Samsung S21 (Android 14)

@parasharrajat @lanitochka17 is it possible to provide me a different account or one of either [email protected] or [email protected]?

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[melvin-bot]

@puneetlath, @chrispader, @parasharrajat Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@puneetlath, @chrispader, @parasharrajat 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[puneetlath]

Given that QA is also saying it's no longer reproducible, I'm going to go ahead and close this out. Thanks everyone.