Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat - Chat is auto scrolled up when opened for the first time #45634

Closed
2 of 6 tasks
lanitochka17 opened this issue Jul 17, 2024 · 15 comments
Closed
2 of 6 tasks

Chat - Chat is auto scrolled up when opened for the first time #45634

lanitochka17 opened this issue Jul 17, 2024 · 15 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@lanitochka17
Copy link

lanitochka17 commented Jul 17, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.8-3
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to http://staging.new.expensify.com/
  2. [User A] Create a new workspace
  3. [User A] Invite User B to the workspace
  4. [User B] Open workspace switcher
  5. [User B] Click on the invited workspace. (This will open the workspace chat for the first time)

Expected Result:

  • Chat will not auto scroll up when opened for the first time
  • Skeleton will disappear once the chat is loaded

Actual Result:

  • Chat auto scrolls up when opened for the first time
  • Skeleton still remains briefly when the chat background is loaded

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6545429_1721235112598.20240718_003954.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @abdulrahuman5196
@lanitochka17 lanitochka17 added DeployBlockerCash This issue or pull request should block deployment DeployBlocker Indicates it should block deploying the API labels Jul 17, 2024
Copy link

melvin-bot bot commented Jul 17, 2024

Triggered auto assignment to @tgolen (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@lanitochka17
Copy link
Author

@tgolen FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@lanitochka17
Copy link
Author

We think that this bug might be related to #vip-vsp

@thienlnam
Copy link
Contributor

Looks potentially related: #44724

@youssef-lr
Copy link
Contributor

@thienlnam let me try reverting it locally and see if I can reproduce

@shubham1206agra
Copy link
Contributor

@bernhardoj Can you please check this?

@bernhardoj
Copy link
Contributor

Can't test it, looks like the invite member is broken.
image

@mountiny mountiny added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Jul 18, 2024
Copy link

melvin-bot bot commented Jul 18, 2024

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@mountiny
Copy link
Contributor

Looking at the video, this does not seem like a blocker to me, the skeleton disappeared after a second, this is minor ux issue

@mountiny
Copy link
Contributor

I could not really reproduce this issue either

Screen.Recording.2024-07-18.at.13.13.19.mp4

@mountiny mountiny added the External Added to denote the issue can be worked on by a contributor label Jul 18, 2024
Copy link

melvin-bot bot commented Jul 18, 2024

Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 18, 2024
Copy link

melvin-bot bot commented Jul 18, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

@kavimuru
Copy link

@mountiny bug is fixed.

bandicam.2024-07-18.21-07-44-295.mp4

@mountiny
Copy link
Contributor

Nice, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests

10 participants