[HOLD for payment 2024-08-01] Expense - Missing background image in the combined report

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.8-1
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to DM with user that has no unsettled expense.
3. Submit one manual expense (only one).
4. Click on the expense preview to go to the combined report.

Expected Result:

There will be background image in the combined report.

Actual Result:

There is no background image in the combined report.
This issue only happens in the combined report (one transaction view).

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6544692_1721194531887.20240717_133235.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @stephanieelliott

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @NikkiWines (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

We think this issue might be related to the #collect project.

[izarutskaya]

Production

bandicam.2024-07-17.08-57-08-226.mp4

[NikkiWines]

I'm not seeing this behavior on staging v9.0.8-3

Screen.Recording.2024-07-17.at.16.39.51.mov

Also not seeing it on prod v9.0.7-8

Screen.Recording.2024-07-17.at.16.44.21.mov

Asked for a retest from applause here

[kavimuru]

@NikkiWines Please use the same currency as the default currency to reproduce the bug. If the different currency is used, bug is not reproducible.

20240718_004705.mp4

[NikkiWines]

Oh, yes thank you @kavimuru - i can reproduce the issue on staging now. I'm fairly confident this is due to #45042

It's a pretty minor bug, so I don't think it needs to be a blocker but we should spin up a follow up issue to resolve the bug.

cc: @nkdengineer @Ollyws @thienlnam

[nkdengineer]

@NikkiWines I will create a PR tomorrow morning

[nkdengineer]

@Ollyws The PR is here.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.11-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix no background when creating money request #45746

If no regressions arise, payment will be issued on 2024-08-01. 🎊

For reference, here are some details about the assignees on this issue:

• @Ollyws requires payment through NewDot Manual Requests
• @nkdengineer requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Ollyws] The PR that introduced the bug has been identified. Link to the PR:
• [@Ollyws] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@Ollyws] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@Ollyws] Determine if we should create a regression test for this bug.
• [@Ollyws] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@stephanieelliott] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @Ollyws owed $250 via NewDot
• ROLE: @nkdengineer paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@stephanieelliott)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[stephanieelliott]

Summarizing payment on this issue:

• Contributor: @nkdengineer $250 via Upwork -- I extended the offer to you, please accept when you get a chance! https://www.upwork.com/nx/wm/offer/103368089
• Contributor+: @nkdengineer $250 via NewDot -- Please request

Upwork job is here: https://www.upwork.com/jobs/~018eb452959d186422

[nkdengineer]

@stephanieelliott This issue is the regression from my PR so we don't need to process payment here.

[melvin-bot]

@Ollyws, @NikkiWines, @stephanieelliott, @nkdengineer Whoops! This issue is 2 days overdue. Let's get this updated quick!

[stephanieelliott]

Ah ok thanks @nkdengineer! Closing this then.