[$250] Xero - App Crashes when navigating to Accounting page when connecting to Xero

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.8-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4729589
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Sign in with expensifail account as a new user
2. Navigate to workspace settings >More features> Accounting
3. Enable accounting
4. Go to the Accounting settings page and click on Connect to Xero
5. Enable 2FA and continue
6. The Xero site will be opened in a new tab
7. Enter the Xero credentials to log in and complete the connection (Here notice that the Xero connection isn't established)
8. Go back to staging
9. Navigate back and away from the Accounting settings page

Expected Result:

Xero connection is established and the accounting page opens properly

Actual Result:

App crashes when navigating to accountings page and connection to Xero is not established

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6544674_1721193023389.2024-07-17_08_07_11.mp4

Bug6544674_1721193023389!staging.new.expensify.com-1721192917726.txt

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a3aea544c5139591
• Upwork Job ID: 1813704314112548490
• Last Price Increase: 2024-07-17

Issue Owner

Current Issue Owner: @rushatgabhane

[melvin-bot]

Triggered auto assignment to @grgia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

We think this issue might be related to the #wave-collect

[izarutskaya]

Production

bandicam.2024-07-17.08-52-09-741.mp4

[grgia]

Quick glance at the deploy checklist

Most likely caused by #44059

Other potential culprits:

https://github.com/Expensify/App/pull/45375/files#diff-cba2d7681fcae80a49675e4cbe9fb66e66f6cc12cdb292550dcf9bff22ae5145

https://github.com/Expensify/App/pull/44930/files

[grgia]

@rushatgabhane

[mananjadhav]

https://github.com/Expensify/App/pull/45375/files#diff-cba2d7681fcae80a49675e4cbe9fb66e66f6cc12cdb292550dcf9bff22ae5145

@grgia This code doesn't touch any of the Xero or related Policy files. I think this can be excluded.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01a3aea544c5139591

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[mountiny]

Merged the revert and CPing it to staging

[mountiny]

Asked for a retest here on 8-5 version

[mountiny]

fixed https://expensify.slack.com/archives/C9YU7BX5M/p1721298585014889

[melvin-bot]

@kevinksullivan, @rushatgabhane, @grgia Eep! 4 days overdue now. Issues have feelings too...

[mountiny]

I believe this can be closed as we just reverted the pr