Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Categorize -Blank workspace selection page when existing workspace has disabled all categories #45478

Closed
6 tasks done
lanitochka17 opened this issue Jul 16, 2024 · 5 comments
Closed
6 tasks done
Assignees

Comments

@lanitochka17
Copy link

lanitochka17 commented Jul 16, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.7-4
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

  • User has only one workspace
  1. Go to staging.new.expensify.com
  2. Go to workspace settings > Categories
  3. Bulk select all the categories and disable them
  4. Go to self DM
  5. Track a manual expense in the self DM
  6. Click Categorize it from the actionable whisper

Expected Result:

Since the existing workspace has no categories, clicking Categorize it should directly open category selection list for a new workspace

Actual Result:

Clicking Categorize it opens a blank workspace selection page
This issue only happens when the existing workspace(s) has disabled all the categories

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6543727_1721124751428.bandicam_2024-07-16_18-08-27-809.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added DeployBlockerCash This issue or pull request should block deployment DeployBlocker Indicates it should block deploying the API labels Jul 16, 2024
Copy link

melvin-bot bot commented Jul 16, 2024

Triggered auto assignment to @arosiclair (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@arosiclair
Copy link
Contributor

Looks like this is expected behavior from #43975 and this slack convo. Definitely not a blocker though I'm not sure if we want to display an empty state message here.

@arosiclair arosiclair removed DeployBlockerCash This issue or pull request should block deployment DeployBlocker Indicates it should block deploying the API labels Jul 16, 2024
@allgandalf
Copy link
Contributor

Yes this is a expected behaviour which was intended!, thanks @arosiclair

@arosiclair arosiclair added Daily KSv2 and removed Hourly KSv2 labels Jul 16, 2024
@arosiclair
Copy link
Contributor

Looks like we'll punt adding any kind of empty state for this screen here. Closing this out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants