[HOLD for payment 2024-10-22] [$250] Web/Desktop - Chat - Focus is lost after deleting a message from edit mode

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.7-4
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4725448
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Action Performed:

1. Start ND on Desktop App or go to staging.new.expensify.com
2. Login with any account
3. Open any chat and send a message
4. Press Arrow Up key on keyboard
5. Select All - Ctrl / Cmd + A
6. Press 'Delete' key
7. Press 'Enter' key
8. Confirm message deletion with 'Enter' key

Expected Result:

Message deleted. Focus is on composer field

Actual Result:

Focus lost after deleting message in edit mode

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6543348_1721088513421.Desktop-Focus-lost-after-msg-delete.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01fe43add27dc504ef
• Upwork Job ID: 1826277990269229690
• Last Price Increase: 2024-09-18
• Automatic offers:
• brunovjk | Reviewer | 104052891

Issue Owner

Current Issue Owner: @brunovjk

[melvin-bot]

Triggered auto assignment to @johnmlee101 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

We think that this bug might be related to #vip-vsp

[thienlnam]

This is a pretty edge case bug - don't think it needs to be a blocker

[melvin-bot]

@johnmlee101 Still overdue 6 days?! Let's take care of this!

[melvin-bot]

@johnmlee101 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

[melvin-bot]

@johnmlee101 12 days overdue. Walking. Toward. The. Light...

[melvin-bot]

This issue has not been updated in over 14 days. @johnmlee101 eroding to Weekly issue.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01fe43add27dc504ef

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @brunovjk (External)

[melvin-bot]

📣 @brunovjk 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @Shahidullah-Muffakir You have been assigned to this job!
Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs!
Keep in mind: Code of Conduct | Contributing 📖

[Shahidullah-Muffakir]

I will submit the PR within 24hrs.

[brunovjk]

PR under review.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.48-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix focus loss after message deletion in edit mode #49538

If no regressions arise, payment will be issued on 2024-10-22. 🎊

For reference, here are some details about the assignees on this issue:

• @brunovjk requires payment automatic offer (Reviewer)
• @Shahidullah-Muffakir requires payment (Needs manual offer from BZ)

[brunovjk]

BugZero Checklist:

• [@brunovjk] The PR that introduced the bug has been identified. Link to the PR: I couldn't find any changes or pull requests that would have caused this issue. According to the file history, those lines have remained unchanged since the file was created.
• [@brunovjk] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: The change updated the code by directly assigning the result of runAndResetCallback() to callbackWhenDeleteModalHide.current, eliminating unnecessary indirection and making the behavior more predictable.
• [@brunovjk] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@brunovjk] Determine if we should create a regression test for this bug. Yes
• [@brunovjk] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

• Start the ND Desktop App or go to staging.new.expensify.com and log in with any account.
• Open any chat and send a message.
• Press the Arrow Up key, then use Ctrl + A (or Cmd + A) to select all text, followed by the 'Delete' key.
• Press 'Enter' to confirm the deletion.
• Ensure that the focus remains on the composer field after deletion.

Do we agree 👍 or 👎?

cc: @youssef-lr, @johnmlee101

[melvin-bot]

Issue is ready for payment but no BZ is assigned. @joekaufmanexpensify you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

[joekaufmanexpensify]

Regression test here: https://github.com/Expensify/Expensify/issues/438069

[joekaufmanexpensify]

All set to issue payment. We need to pay:

• @Shahidullah-Muffakir - $250 for PR vio Upwork.
• @brunovjk - $250 for C+ visa Upwork.

[joekaufmanexpensify]

@brunovjk $250 sent and contract ended!

[joekaufmanexpensify]

@Shahidullah-Muffakir you were never hired, so created a new upwork job and send you an offer for $250

[Shahidullah-Muffakir]

@joekaufmanexpensify, Thanks, I accepted it. Just to mention that I've already been assigned to a few issues and have received payment through Upwork (Same Upwork account).

[joekaufmanexpensify]

TY! The issue might've been that this issue was several months old.

[joekaufmanexpensify]

@Shahidullah-Muffakir $250 sent and contract ended!

[joekaufmanexpensify]

New upwork job closed.

[joekaufmanexpensify]

All set. Thanks everyone!