[HOLD for payment 2024-07-25] [HOLD for payment 2024-07-24] iOS - Search - "No options available for the selected group of expenses." is truncated

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

issue found when validating #44820
Version Number: 9.0.7-4
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:

Action Performed:

Precondition:

• User has at least one paid expense.

1. Launch New Expensify app.
2. Go to Search.
3. Tap on the dropdown.
4. Select Finished.
5. Long tap on any expense.
6. Tap Select.
7. Tap on the "1 selected" dropdown.

Expected Result:

The content "No options available for the selected group of expenses." will be displayed in two lines (no truncation).

Actual Result:

The content "No options available for the selected group of expenses." is truncated.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6543325_1721086409232.RPReplay_Final1721086084.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @bfitzexpensify

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @MonilBhavsar (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

iOS - Search - "No options available for the selected group of expenses." is truncated

What is the root cause of that problem?W

We aren't passing the numberOfLinesTitle prop and few other props.

App/src/pages/Search/SearchSelectedNarrow.tsx

Lines 65 to 72 in 7d58aa6

	{options.map((option, index) => (
	<MenuItem
	title={option.text}
	icon={option.icon}
	onPress={() => handleOnMenuItemPress(option, index)}
	key={option.value}
	/>
	))}

What changes do you think we should make in order to solve the problem?

We should pass the props as we do in other components.

            <Modal
                isVisible={isModalVisible}
                type={CONST.MODAL.MODAL_TYPE.BOTTOM_DOCKED}
                onClose={closeMenu}
            >
                {options.map((option) => (
                    <MenuItem
                        title={option.text}
                        icon={option.icon}
                        onPress={option.onSelected}
                        key={option.value}
                        numberOfLinesTitle={option.numberOfLinesTitle}
                        // pass other missing props also, like `iconFill`, `iconHeight`, `iconWidth`, `titleStyle`, `interactive`.
                    />
                ))}
            </Modal>

What alternative solutions did you explore? (Optional)

Spread the remaining option's properties.

                {options.map((option) => (
                    <MenuItem
                        title={option.text}
                        icon={option.icon}
                        onPress={option.onSelected}
                        key={option.value}
                        numberOfLinesTitle={option.numberOfLinesTitle}
                        // eslint-disable-next-line react/jsx-props-no-spreading
                        {...option}
                    />
                ))}

[shawnborton]

Hmm I feel like this is using an incorrect style anyways, why not use a style that matches what we are doing on desktop?

It should basically look identical to that, just in bottom-docked mobile format. cc @Expensify/design for any thoughts too!

[shawnborton]

cc @filip-solecki in case you have any context there as to why we didn't reuse the same styles from desktop.

[Krishna2323]

@shawnborton, the solution for this will fix the styling as well. The styling is there but it isn't passed to child component.

[filip-solecki]

TBH I am not sure if we need this Modal anymore. I am working on Download functionality and AFAIK user can download every single transaction, so there will always be at least one option, but yes, looks like quick styling fix

[MonilBhavsar]

It seems to be coming from #44820. Would you be able to make a quick follow up fix?

[filip-solecki]

Yes, I will prepare it right now

[trjExpensify]

TBH I am not sure if we need this Modal anymore. I am working on Download functionality and AFAIK user can download every single transaction, so there will always be at least one option, but yes, looks like quick styling fix

I agree with this btw.. with the option to Download being added to the menu imminently, it makes this kinda' obsolete.

[DylanDylann]

This issue come from #44820. @rushatgabhane Could you take over this one? Then, @MonilBhavsar Could you help to update the C+ role in this new PR

[MonilBhavsar]

I just did a quick test and looks good!

[thienlnam]

Doesn't look like this was CPed - will request one

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.7-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix text wrapping when no option to select #45454

If no regressions arise, payment will be issued on 2024-07-24. 🎊

For reference, here are some details about the assignees on this issue:

• @filip-solecki does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@MonilBhavsar] The PR that introduced the bug has been identified. Link to the PR:
• [@MonilBhavsar] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@MonilBhavsar] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@filip-solecki] Determine if we should create a regression test for this bug.
• [@filip-solecki] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@bfitzexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[MonilBhavsar]

This issue is fixed. No further action required. Thanks all!

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.8-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix text wrapping when no option to select #45454

If no regressions arise, payment will be issued on 2024-07-25. 🎊

For reference, here are some details about the assignees on this issue:

• @filip-solecki does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@MonilBhavsar] The PR that introduced the bug has been identified. Link to the PR:
• [@MonilBhavsar] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@MonilBhavsar] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@filip-solecki] Determine if we should create a regression test for this bug.
• [@filip-solecki] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@bfitzexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: