[$250] Concierge - Concierge chat name and icon changes if the page is refreshed on WS settings page

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.6-8
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Log in with a new account
2. Wait for self DM to appear in the LHN
3. Create a workspace
4. Refresh the page
5. Go back to the LHN
6. Open Concierge

Expected Result:

Concierge chat name and icon should be the default one

Actual Result:

Concierge chat name and icon changes to the self DM one if the page is refreshed on workspace settings page. Affects Gmail and expensifail accounts too. It reverts to the default one if the chat is clicked

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6542845_1721059418742.bandicam_2024-07-15_17-56-12-105.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01075d42013d493c4a
• Upwork Job ID: 1813015223843940374
• Last Price Increase: 2024-08-06

Issue Owner

Current Issue Owner: @eh2077

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@mallenexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-vsp

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Concierge chat name and icon changes to the self DM one if the page is refreshed on workspace settings page. Affects Gmail and expensifail accounts too. It reverts to the default one if the chat is clicked

What is the root cause of that problem?

When we reload the page and call API OpenApp, we'll get 2 participants in the Concierge chat

But currently, we don't consider Concierge as a Participants and it will be filtered

App/src/libs/migrations/Participants.ts

Lines 53 to 61 in cf34d87

	possibleParticipants.forEach((accountID) => {
	if (deprecatedParticipants.has(accountID) || accountID === currentUserAccountID) {
	participants[accountID] = {
	hidden: report.participants?.[accountID]?.hidden ?? (!deprecatedVisibleParticipants.has(accountID) && accountID !== currentUserAccountID),
	};
	} else {
	participants[accountID] = null;
	}
	});

So the Concierge chat will have only one participant (current user)

What changes do you think we should make in order to solve the problem?

We'll not filter participants when it is Concierge chat

App/src/libs/migrations/Participants.ts

Line 54 in cf34d87

if (deprecatedParticipants.has(accountID) || accountID === currentUserAccountID) {

if (deprecatedParticipants.has(accountID) || accountID === currentUserAccountID || isConciergeChatReport(report)) {

What alternative solutions did you explore? (Optional)

[mallenexpensify]

Thanks @daledah , I'm checking on internally, we have quite a few report.participants issues now, we might want to fix them holistically (or.. add them to a tracking issue since we might not need separate fixes for each one).

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01075d42013d493c4a

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eh2077 (External)

[mallenexpensify]

@eh2077 , do you think this can be external?

[eh2077]

@mallenexpensify Yeah, I think so

[eh2077]

@daledah Thanks for your proposal!

I can't reproduce it using existing account. Can you explain why this only happens with new account?

[daledah]

@eh2077 @mallenexpensify I can't reproduce now
maybe this PR has fixed this issue

[eh2077]

I also can't reproduce it.

@mallenexpensify Should we just close it?

[eh2077]

@lanitochka17 This issue isn't reproducible anymore. Can you help to confirm?

[MelvinBot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

[mallenexpensify]

Let's give it one pass for QA to try to repro then we'll close if they can't. Thanks @eh2077 and @daledah for the help here

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@mallenexpensify @eh2077 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[eh2077]

Not overdue, we're waiting for QA to test it again

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸