-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-08-13] [Free Trial] [FE] Getting onboarding chat reportID from nvp #45238
Comments
Current assignee @trjExpensify is eligible for the NewFeature assigner, not assigning anyone new. |
Hi! I’m Pedro Guerreiro from Callstack - expert contributor group. I’d like to work on this task! |
Assigned! |
PR is deployed to staging. |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.7-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-07-24. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Going to hold off on payment until we get this PR merged: #45785 |
Payment Summary
BugZero Checklist (@trjExpensify)
|
@rojiphil, @chiragsalian, @trjExpensify, @pac-guerreiro Whoops! This issue is 2 days overdue. Let's get this updated quick! |
@rojiphil, @chiragsalian, @trjExpensify, @pac-guerreiro Huh... This is 4 days overdue. Who can take care of this? |
PR hit staging 4 days ago. |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.16-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-08-13. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Payment Summary
BugZero Checklist (@trjExpensify)
|
no need for a regression test here. Payment summary as follows:
Offer sent! |
@trjExpensify Offer Accepted. Thanks. |
Paid, closing! |
Coming from here.
This is the issue @pac-guerreiro will link his PR to for the FE updates discussed in thread.
We've added the chatReportID to onboarding NVP on the backend, so here we need to use it to decide where to put the free trial stuff, so it's more robust than simply relying on odd/even accountIDs like the A/B testing does for onboarding tasks.
Issue Owner
Current Issue Owner: @trjExpensifyThe text was updated successfully, but these errors were encountered: