Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-08-13] [Free Trial] [FE] Getting onboarding chat reportID from nvp #45238

Closed
trjExpensify opened this issue Jul 11, 2024 · 20 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item.

Comments

@trjExpensify
Copy link
Contributor

trjExpensify commented Jul 11, 2024

Coming from here.

This is the issue @pac-guerreiro will link his PR to for the FE updates discussed in thread.

We've added the chatReportID to onboarding NVP on the backend, so here we need to use it to decide where to put the free trial stuff, so it's more robust than simply relying on odd/even accountIDs like the A/B testing does for onboarding tasks.

Issue OwnerCurrent Issue Owner: @trjExpensify
Copy link

melvin-bot bot commented Jul 11, 2024

Current assignee @trjExpensify is eligible for the NewFeature assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Jul 11, 2024
@trjExpensify trjExpensify moved this to Release 2: Summer 2024 (Aug) in [#whatsnext] #wave-collect Jul 11, 2024
@trjExpensify trjExpensify added Daily KSv2 and removed Weekly KSv2 labels Jul 11, 2024
@pac-guerreiro
Copy link
Contributor

Hi! I’m Pedro Guerreiro from Callstack - expert contributor group. I’d like to work on this task!

@trjExpensify
Copy link
Contributor Author

Assigned!

@trjExpensify
Copy link
Contributor Author

PR is deployed to staging.

Copy link

melvin-bot bot commented Jul 16, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jul 17, 2024
@melvin-bot melvin-bot bot changed the title [Free Trial] [FE] Getting onboarding chat reportID from nvp [HOLD for payment 2024-07-24] [Free Trial] [FE] Getting onboarding chat reportID from nvp Jul 17, 2024
Copy link

melvin-bot bot commented Jul 17, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jul 17, 2024
Copy link

melvin-bot bot commented Jul 17, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.7-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-07-24. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Jul 17, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@rojiphil] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 Daily KSv2 and removed Weekly KSv2 labels Jul 19, 2024
@trjExpensify
Copy link
Contributor Author

Going to hold off on payment until we get this PR merged: #45785

Copy link

melvin-bot bot commented Jul 24, 2024

Payment Summary

Upwork Job

  • ROLE: @rojiphil paid $(AMOUNT) via Upwork (LINK)
  • Contributor: @pac-guerreiro is from an agency-contributor and not due payment

BugZero Checklist (@trjExpensify)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

Copy link

melvin-bot bot commented Jul 31, 2024

@rojiphil, @chiragsalian, @trjExpensify, @pac-guerreiro Whoops! This issue is 2 days overdue. Let's get this updated quick!

Copy link

melvin-bot bot commented Aug 2, 2024

@rojiphil, @chiragsalian, @trjExpensify, @pac-guerreiro Huh... This is 4 days overdue. Who can take care of this?

@trjExpensify
Copy link
Contributor Author

PR hit staging 4 days ago.

@trjExpensify trjExpensify changed the title [HOLD for payment 2024-07-24] [Free Trial] [FE] Getting onboarding chat reportID from nvp [Free Trial] [FE] Getting onboarding chat reportID from nvp Aug 5, 2024
@trjExpensify trjExpensify removed the Awaiting Payment Auto-added when associated PR is deployed to production label Aug 5, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels Aug 6, 2024
@melvin-bot melvin-bot bot changed the title [Free Trial] [FE] Getting onboarding chat reportID from nvp [HOLD for payment 2024-08-13] [Free Trial] [FE] Getting onboarding chat reportID from nvp Aug 6, 2024
Copy link

melvin-bot bot commented Aug 6, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Aug 6, 2024
Copy link

melvin-bot bot commented Aug 6, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.16-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-08-13. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Aug 6, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@rojiphil] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Aug 12, 2024
Copy link

melvin-bot bot commented Aug 13, 2024

Payment Summary

Upwork Job

  • ROLE: @rojiphil paid $(AMOUNT) via Upwork (LINK)
  • Contributor: @pac-guerreiro is from an agency-contributor and not due payment

BugZero Checklist (@trjExpensify)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@trjExpensify
Copy link
Contributor Author

no need for a regression test here. Payment summary as follows:

Offer sent!

@rojiphil
Copy link
Contributor

@trjExpensify Offer Accepted. Thanks.

@trjExpensify
Copy link
Contributor Author

Paid, closing!

@github-project-automation github-project-automation bot moved this from Release 2: Summer 2024 (Aug) to Done in [#whatsnext] #wave-collect Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item.
Projects
No open projects
Status: Done
Development

No branches or pull requests

4 participants