Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] [HOLD for payment 2024-08-07] Unable to make the archived chats in the LHN to read #45228

Closed
1 of 6 tasks
m-natarajan opened this issue Jul 11, 2024 · 17 comments
Closed
1 of 6 tasks
Assignees
Labels
AutoAssignerNewDotQuality Used to assign quality issues to engineers Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor

Comments

@m-natarajan
Copy link

m-natarajan commented Jul 11, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @quinthar
Slack conversation: https://expensify.slack.com/archives/C05LX9D6E07/p1720290639217409

Action Performed:

Precondition : Have an archived workspace chat in the account

  1. Open the report
  2. Click on the archived chat in the LHN which is unread

Expected Result:

Chat should be read

Actual Result:

Still showing as unread and unable to make it read

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

image (13)

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @DylanDylann
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~011ff42d6c7196dc02
  • Upwork Job ID: 1829034655875781794
  • Last Price Increase: 2024-08-29
  • Automatic offers:
    • mkhutornyi | Contributor | 103729872
@m-natarajan m-natarajan added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. AutoAssignerNewDotQuality Used to assign quality issues to engineers labels Jul 11, 2024
Copy link

melvin-bot bot commented Jul 11, 2024

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Jul 11, 2024

Triggered auto assignment to @grgia (AutoAssignerNewDotQuality)

@quinthar
Copy link
Contributor

I think this is fixed.

Copy link

melvin-bot bot commented Jul 30, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jul 31, 2024
@melvin-bot melvin-bot bot changed the title Unable to make the archived chats in the LHN to read [HOLD for payment 2024-08-07] Unable to make the archived chats in the LHN to read Jul 31, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jul 31, 2024
Copy link

melvin-bot bot commented Jul 31, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Jul 31, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.14-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-08-07. 🎊

Copy link

melvin-bot bot commented Jul 31, 2024

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@grgia] The PR that introduced the bug has been identified. Link to the PR:
  • [@grgia] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • [@grgia] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • [@grgia] Determine if we should create a regression test for this bug.
  • [@grgia] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • [@VictoriaExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@mkhutornyi
Copy link
Contributor

I reviewed linked PR.
@VictoriaExpensify can you please reopen and sort payment? Thanks

@VictoriaExpensify VictoriaExpensify added Daily KSv2 External Added to denote the issue can be worked on by a contributor and removed Weekly KSv2 labels Aug 27, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-08-07] Unable to make the archived chats in the LHN to read [$250] [HOLD for payment 2024-08-07] Unable to make the archived chats in the LHN to read Aug 29, 2024
Copy link

melvin-bot bot commented Aug 29, 2024

Job added to Upwork: https://www.upwork.com/jobs/~011ff42d6c7196dc02

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Aug 29, 2024
Copy link

melvin-bot bot commented Aug 29, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann (External)

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Aug 29, 2024
Copy link

melvin-bot bot commented Aug 29, 2024

📣 @mkhutornyi 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@VictoriaExpensify
Copy link
Contributor

Hey @mkhutornyi - can you please accept the job offer and I'll organise payment

@mkhutornyi
Copy link
Contributor

Accepted thanks

@melvin-bot melvin-bot bot added the Overdue label Sep 2, 2024
Copy link

melvin-bot bot commented Sep 3, 2024

@quinthar, @grgia, @VictoriaExpensify, @mkhutornyi Eep! 4 days overdue now. Issues have feelings too...

@quinthar
Copy link
Contributor

quinthar commented Sep 5, 2024

What are the next steps here to make this not overdue?

@melvin-bot melvin-bot bot removed the Overdue label Sep 5, 2024
@VictoriaExpensify
Copy link
Contributor

I was just waiting for @mkhutornyi to accept the offer so I can make payment, but the issue wasn't starred to me so I missed it.

Making payment now then we can close this out.

@VictoriaExpensify
Copy link
Contributor

Payment Summary:
Contributor+: @mkhutornyi paid $250 via Upwork

Thanks for your work on this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AutoAssignerNewDotQuality Used to assign quality issues to engineers Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor
Projects
Status: Done
Development

No branches or pull requests

6 participants