[PAID] Workspace - Endless skeleton loader after login if the account is added to a workspace

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.6-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR https://github.com/Expensify/Web-Expensify/pull/42621 https://github.com/Expensify/Web-Expensify/pull/42602

Action Performed:

1. Navigate to https://staging.new.expensify.com/
2. User A: Log in with a new Gmail account
3. User A: Create a workspace
4. User A: Navigate to Workspace settings - Members
5. User A: Invite a Gmail address that doesn't have an account yet (User B)
6. User B: Open Chrome in incognito mode
7. User B: Navigate to https://staging.new.expensify.com/
8. User B: Log in

Expected Result:

The workspace chat should load with minimal loading animation

Actual Result:

Endless skeleton loader after login if the account is added to a workspace

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6538239_1720636518054.bandicam_2024-07-10_20-27-19-679.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @strepanier03

[melvin-bot]

Triggered auto assignment to @francoisl (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

@francoisl FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[francoisl]

I can repro too.

One difference between prod and staging is that on production there's a call to OpenReport at some point after signing in, which I don't see on staging. I don't know if that's the reason, but could be a lead.

Production	Staging

[melvin-bot]

Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mkhutornyi (External)

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[francoisl]

Ran a git bisect, this appears to come from commit fce482497a3d6c0c5b2d93de6688e01a653c8d27 in #44955.

Did a local revert and it seems to fix the issue. Going to see if I can figure out the issue, otherwise we can proceed with the revert.

[francoisl]

Ok it seems like partially reverting this change and moving back the lastAccessedReportID as a dependency of the useEffect fixes the issue. Going to run more tests and submit a fix.

[mountiny]

cc @kosmydel for visibility

[francoisl]

Reassigning C+s because @rayane-djouah is online now and able to review the fix.

[kosmydel]

Thanks for handling that.

Ok it seems like partially reverting this change and moving back the lastAccessedReportID as a dependency of the useEffect fixes the issue. Going to run more tests and submit a fix.

This might degrade performance a bit, but together with 2nd PR it should work fine for now. I will revisit it, probably next week, as I have other projects in progress.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.7-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix default chat report view not loading upon signin #45224

If no regressions arise, payment will be issued on 2024-07-24. 🎊

For reference, here are some details about the assignees on this issue:

• @rayane-djouah requires payment (offer)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rayane-djouah] The PR that introduced the bug has been identified. Link to the PR:
• [@rayane-djouah] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@rayane-djouah] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@rayane-djouah] Determine if we should create a regression test for this bug.
• [@rayane-djouah] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@strepanier03] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[rayane-djouah]

• The PR that introduced the bug has been identified. Link to the PR: perf: remove useLastAccessedReportID hook and call findLastAccessedReport only when needed #44955
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: perf: remove useLastAccessedReportID hook and call findLastAccessedReport only when needed #44955 (comment)
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• Determine if we should create a regression test for this bug. No
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A

[strepanier03]

@rayane-djouah - Thanks for the checklist!

I sent you an offer on Upwork and will keep an eye for the acceptance email to come through.

[rayane-djouah]

@strepanier03 - Accepted, Thanks!

[strepanier03]

Paid out the contract and closed it. Thanks @rayane-djouah for accepting it so quickly.