[HOLD for payment 2024-08-19] [$750] [Violations] Remove violations beta from front-end #44995

cead22 · 2024-07-08T18:37:36Z

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

Problem

Violations were implemented under a beta and we're ready to release this functionality to everyone

Solution

Remove all the code in the front end using the violations beta, and run a thorough set of manual tests to make sure everything is working as designed.
The proposal should outline all the places in the code we need to update
The proposed test script is below, and both online and offline tests should be done on every platform

(related https://github.com/Expensify/Expensify/issues/338701)

Tests

Pre-testing steps

Make sure emails sent to the testing email addresses go to an inbox you can access to validate your account(s)
Create a new workspace in new dot and go to the workspace settings
- From the members tab, invite an additional user to the policy
- From the More Features tab, enable categories and tags
- From the Categories tab, add at least 2 categories, click settings, and switch on “Members must categorize all expenses”
- From the Tags tab, add at least 2 tags, click settings, and switch on “Members must tag all expenses”

Important Notes

Only the violations related to tags and categories work while offline. That means if you have a missing tag or missing category violation, you’re offline, and you update the tag or category, the violation should disappear. Similarly, if you’re online, the violation should disappear right away.
- For other violations, you’ll need to wait for the API to return a response and update the transaction violations.
Some tests ask to verify that the report preview looks correct. If you're on the case of a single-expense report, where we put a money request preview directly in the workspace chat (as oppposed to workspace chat having report previews, and reports having money request previews), you can add a second expense to the report and then verify the report preview, or omit the step and verify the money request preview
If you find any steps need to be updated, please let us know so we can update our testing script

Missing tag and missing category violations

Manual Request

Press big plus sign > submit expense
Select Manual tab (from Manual | Scan | Distance)
Enter amount and press next
Press the workspace from the pre-testing steps (press the row, not the split button in the row)
Press the show more button if it’s there
- Verify there’s a Required label on the Category row
- Verify there’s a Required label on the tag row
Enter a merchant
Press the Request $X.XX button
Repeat steps 1-7
- Verify the report preview in the workspace chat has a red circle
Press the report preview
- Verify the money request previews in the iou report have a red circle
Press the first money request preview
- Verify you see the Missing Category red text under the category row
Press the category row
Press on a category
- Verify you no longer see the Missing Category red text under the category row
Press the Tag row
Press on a tag
- Verify you no longer see the Missing Tag red text under the category row
Press on the IOU chat report link at the top
Press on the second money request view
Repeat steps 11-15
Press on the IOU chat report link at the top
- Verify the money request previews in the iou report no longer have a red circle
Press on the policy expense chat report link at the top
- Verify the report preview in the policy expense chat report no longer has a red circle
🛜 Repeats all these steps while offline

Scan Request

Same as the Manual Request test above, replacing steps 2 and 3 with the following
Select Scan tab (from Manual | Scan | Distance)
Press choose file, select an image
Press the workspace from the pre-testing steps (press the row, not the split button in the row)
- Verify there’s a Required label on the Category row
- Verify there’s a Required label on the tag row
Press the Submit expense button
Continue from the verification of step 8 above, and once done, repeat all these steps while offline 🛜

Distance Request

Same as the Manual Request test above, replacing steps 2 and 3 with the following
Select Distance tab (from Manual | Scan | Distance)
Press Start and enter an address, eg 88 Kearny st. Then Press Finish and enter an address, eg, 1180 jackson st. And press Next
Continue from step 4 above, and once done, repeat all these steps while offline 🛜

Category out of policy, tag out of policy violation, expense over limit, max age, over category limit, receipt required

Manual Request

In old dot, in the workspace editor > expenses tab, set max expense age to 5, max expense amount to $10, receipt required amount to $5
In the workspace editor > categories tab, set the max amount for one of the categories to $3
On new dot, press big plus sign > submit expense
Select Manual tab (from Manual | Scan | Distance)
Enter $15 as the amount amount and press next
Press the workspace from the pre-testing steps
Press the show more button
Press the Date row, and set the date to be more than 5 days ago
Press the category row, select a category that doesn’t have a max amount
Press the tag row, select a tag
Enter a merchant
Press the Submit $15 button
If you have more than one expense
- Confirm the report preview has a red circle
Press the report preview
- Confirm the money request preview has a red circle and shows “Review Required”
Press the report preview or money request preview (depending on the number of expenses)
- Verify you see Receipt required over $5 violation
- Verify you see Amount over $10.00/person limit violation
- Verify you see Date older than 5 days violation
Press the category row, and select the category with max amount set to $3
- Verify you see Receipt required over $3 category limit violation
On a different tab, sign into old dot as an admin of the workspace where the money request was created
Go to the policy editor, and disable the category and the tag you added to the money request
Switch back to new dot, and refresh the page
- Verify you see Category no longer valid violation
- Verify you see Tag no longer valid violation
Switch back to old dot, re-enable the category and tag you had disabled, remove the max amount from the category, and from the expenses tab, remove the values from the Max Expense Age (Days), Max Expense Amount and Receipt Required Amount fields
Switch back to new dot, and refresh the page
- Verify you don’t see Category out of policy violation
- Verify you don’t see Tag out of policy violation
- Verify you don’t see Amount over $10/person limit violation
- Verify you don’t see Date older than 5 days violation
- Verify you don’t see Receipt required over $5 violation
Repeat steps 1-3 in old dot
🛜 Switch to new dot and go offline
Repeat steps 1-14. The report preview, money request preview should be grayed out
Go online, and repeat steps 15-21

Scan Request

Same as the Manual Request test above, replacing steps 4 and 5 with the following
Select Scan tab (from Manual | Scan | Distance)
Press choose file, select an image
Press the workspace from the pre-testing steps
- Verify there’s a Required label on the Category row
- Verify there’s a Required label on the tag row
Press the Request button
Continue from the verification of step 13 above, and once done, repeat all these steps while offline 🛜

Distance Request

Same as the Manual Request test above, replacing steps 4 and 5 with the following
Select Distance tab (from Manual | Scan | Distance)
Press Start and enter an address, eg 88 Kearny st. Then Press Finish and enter an address, eg, 1180 jackson st. And press Next
Continue from step 6 above, and once done, repeat all these steps while offline 🛜

Tag violations on workspace with Independent Tags (multi-level tags)

Manual Request

In old dot, in the workspace editor > tags tab, switch on the Use multiple levels of tags toggle
Click import from spreadsheet, and upload the file in this issue comment
On new dot, press big plus sign > submit expense
Select Manual tab (from Manual | Scan | Distance)
Enter $15 as the amount amount and press next
Press the workspace from the pre-testing steps (press the row, not the split button in the row)
Press the merchant row and enter a merchant
Press the Submit $15 button
Confirm the report preview has a red circle
Press the report preview
If the report has more than 1 expense
- Confirm the money request preview has a red circle and shows “Review Required”
Press the money request preview
- Verify you see Missing Region, Missing Project, and Missing Department violations
Press the Region menu item, and select a region
- Verify that the Missing Region violation disappears right away
Repeat for Department and Project
Press the Region menu item, and unselect the selected region
- Verify that the Missing Region violation appears right away
🛜 Switch to new dot and go offline
Repeat steps 1-16. The report preview, money request preview should be grayed out
Go online, and confirm everything looks the same, except nothing is grayed out
Submit a new expense on the same workspace, and select all the required fields so there are no violation on that expense
Click on the link in the transaction thread header to go back to the expense report if you didn’t land there already
- Verify the money request preview says Missing Region next to the a red circle

Tag violations on workspace with Dependent Tags (multi-level tags)

Manual Request

In old dot, in the workspace editor > tags tab, switch on the Use multiple levels of tags and the People must tag expenses toggles
Click import from spreadsheet, uncheck “Are these independent tags?”, and upload the file in this issue comment
On new dot, press big plus sign > submit expense
Select Manual tab (from Manual | Scan | Distance)
Enter $15 as the amount amount and press next
Press the workspace from the pre-testing steps (press the row, not the split button in the row)
Press the merchant row and enter a merchant
- Confirm the Required label shows on the State, Region, and City rows
Press the Submit $15 button
Confirm the report preview has a red circle
Press the report preview
If the report has more than 1 expense
- Confirm the money request preview has a red circle and shows “Review Required”
Press the money request preview
- Verify you see Missing State, Missing Region, and Missing City violations
Press the Region menu item, and select a region
- Verify that the Missing Region violation disappears right away
- Verify you see All tags required violations under State and City
Select a State
- Verify that the see All tags required violation disappears from under State
- Verify you see All tags required violations under City
Select a City
- Verify that the see All tags required violations are gone
De-select City
- Verify that the All tags required violation appears under City
🛜 Switch to new dot and go offline
Repeat steps 1-16. The report preview, money request preview should be grayed out
Go online, and confirm everything looks the same, except nothing is grayed out
Submit a new expense on the same workspace, and select all the required fields so there are no violation on that expense
Click on the link in the transaction thread header to go back to the expense report if you didn’t land there already
- Verify the money request preview for the first expense says Review Required next to the a red circle
  Switch off requirement for tags and categories
  For the next tests, stop requiring tags and categories so you can focus on receipt related violations

Go to the workspace settings for the workspace you’re using
- From the Categories tab switch off “Members must categorize all expenses”
- From the Tags tab switch off “Members must tag all expenses”

Receipt Audit Scan

Press big plus sign > submit expense
Select Scan tab (from Manual | Scan | Distance)
Press choose file and upload the popbagel.pdf file in this issue comment
Select the workspace to submit to
Wait for it to scan, it should be quick since we have a parser for square receipts
- Verify you see “Receipt * Verified √” above the receipt
- Verify amount is set to $21.90, and date to 2020-01-23
Update the amount to $25
- Verify you see “Amount greater than scanned receipt” violation under the amount field
Click the blue link in the report header
If there aren’t any other expenses on the report you added the receipt to, submit another expense on the same workspace
Navigate to the expense report
- Verify you see "Cash * Review required 🔴" in the Request Preview

Receipt Audit Distance

Press big plus sign > submit expense
Select Distance tab (from Manual | Scan | Distance)
Press Start and enter an address, eg 88 Kearny st. Then Press Finish and enter an address, eg, 1180 jackson st. And press Next
Select the workspace to submit to
Click Submit $XX button
Update the amount to $7
- Verify you see “Amount differs from calculated distance” violation under the amount field
Click the blue link in the report header
If there aren’t any other expenses on the report you added the receipt to, submit another expense on the same workspace
Navigate to the expense report
- Verify you see "Distance * Review required 🔴" in the Request Preview
  Receipt Audit Card (Amount greater than card transaction)
Import a third party domain control card via OldDot
Find the card transaction in the workspace chat corresponding to the assigned employee, or visit the Search page and find the transaction by date.
Open the card expense
Change the amount of the card transaction to an amount higher than the original charge
Verify that you see “Amount greater than scanned receipt”
Verify that you see “Receipt * Issue found 🔴” above the receipt
Navigate back to the transaction/expense preview.
Verify that you see “Review required 🔴" in the Request Preview

Receipt Audit - Receipt Not Verified

Press big plus sign > submit expense
Select Scan tab (from Manual | Scan | Distance)
Press choose file and upload a bad receipt. You can take a screenshot of a blank space on your screen and upload that
Select the workspace to submit to
Wait for it to scan, it should fail
- Verify you see “Receipt scanning failed. Enter details manually.” violation under the receipt
Add an amount and a merchant
- Verify all violations are gone

cc @JmillsExpensify

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01e029ffdb5d51f383
Upwork Job ID: 1810382758841290536
Last Price Increase: 2024-07-08
Automatic offers:

ShridharGoel | Contributor | 103067321

Issue Owner

Current Issue Owner: @JmillsExpensify

melvin-bot · 2024-07-08T18:37:41Z

Job added to Upwork: https://www.upwork.com/jobs/~01e029ffdb5d51f383

melvin-bot · 2024-07-08T18:37:46Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (External)

ShridharGoel · 2024-07-08T18:44:20Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

[Violations] Remove violations beta from front-end.

What is the root cause of that problem?

We need to remove violations code.

What changes do you think we should make in order to solve the problem?

All the things are already mentioned in OP. Most important part seems to be testing.

canUseViolations is present in Permissions.ts. Check all the usages and remove them so that the dependency on this check is no longer present and everyone can access it. Then, this method would no longer be needed.

canUseViolations is present at 28 places in 12 files:

App/src/components/MoneyRequestConfirmationListFooter.tsx

Line 221 in da24e9a

const {canUseViolations} = usePermissions(iouType);

App/src/components/MoneyRequestConfirmationListFooter.tsx

Line 221 in da24e9a

const {canUseViolations} = usePermissions(iouType);

App/src/components/MoneyRequestConfirmationListFooter.tsx

Line 439 in da24e9a

    
           rightLabel={isCategoryRequired && canUseViolations ? translate('common.required') : ''}

App/src/components/MoneyRequestConfirmationListFooter.tsx

Line 464 in da24e9a

    
           rightLabel={isTagRequired && canUseViolations ? translate('common.required') : ''}

App/src/components/LHNOptionsList/LHNOptionsList.tsx

Line 45 in da24e9a

const {canUseViolations} = usePermissions();

App/src/components/LHNOptionsList/LHNOptionsList.tsx

Line 155 in da24e9a

canUseViolations={canUseViolations}

App/src/components/LHNOptionsList/LHNOptionsList.tsx

Line 155 in da24e9a

canUseViolations={canUseViolations}

App/src/components/LHNOptionsList/LHNOptionsList.tsx

Line 172 in da24e9a

canUseViolations,

App/src/components/LHNOptionsList/OptionRowLHNData.tsx

Line 29 in da24e9a

canUseViolations,

App/src/components/LHNOptionsList/OptionRowLHNData.tsx

Line 38 in da24e9a

    
           const shouldDisplayViolations = canUseViolations && ReportUtils.shouldDisplayTransactionThreadViolations(fullReport, transactionViolations, parentReportAction);

App/src/components/LHNOptionsList/OptionRowLHNData.tsx

Line 71 in da24e9a

canUseViolations,

App/src/components/LHNOptionsList/types.ts

Line 78 in da24e9a

canUseViolations: boolean | undefined;

App/src/components/ReportActionItem/MoneyRequestView.tsx

Line 121 in da24e9a

    
           const {canUseViolations, canUseP2PDistanceRequests} = usePermissions(isTrackExpense ? CONST.IOU.TYPE.TRACK : undefined);

App/src/components/ReportActionItem/MoneyRequestView.tsx

Line 195 in da24e9a

    
           !!canUseViolations && getViolationsForField(field, data, policyHasDependentTags, tagValue).length > 0,

App/src/components/ReportActionItem/MoneyRequestView.tsx

Line 196 in da24e9a

[canUseViolations, getViolationsForField],

App/src/components/ReportActionItem/MoneyRequestView.tsx

Line 349 in da24e9a

    
           const shouldShowNotesViolations = !isReceiptBeingScanned && canUseViolations && ReportUtils.isPaidGroupPolicy(report);

App/src/components/ReportActionItem/ReportPreview.tsx

Line 113 in da24e9a

const {canUseViolations} = usePermissions();

App/src/components/ReportActionItem/ReportPreview.tsx

Line 156 in da24e9a

    
           (canUseViolations && (ReportUtils.hasViolations(iouReportID, transactionViolations) || ReportUtils.hasWarningTypeViolations(iouReportID, transactionViolations))) ||

App/src/components/ReportActionItem/MoneyRequestPreview/MoneyRequestPreviewContent.tsx

Line 87 in da24e9a

const {canUseViolations} = usePermissions();

App/src/components/ReportActionItem/MoneyRequestPreview/MoneyRequestPreviewContent.tsx

Line 118 in da24e9a

canUseViolations

App/src/hooks/__mocks__/usePermissions.ts

Line 5 in da24e9a

canUseViolations: true,

App/src/libs/OptionsListUtils.ts

Line 1746 in da24e9a

if (!Permissions.canUseViolations(betas)) {

App/src/libs/Permissions.ts

Line 22 in da24e9a

function canUseViolations(betas: OnyxEntry<Beta[]>): boolean {

App/src/libs/Permissions.ts

Line 74 in da24e9a

canUseViolations,

App/src/libs/__mocks__/Permissions.ts

Line 15 in da24e9a

canUseViolations: (betas: Beta[]) => betas.includes(CONST.BETAS.VIOLATIONS),

App/src/libs/actions/IOU.ts

Line 1625 in da24e9a

if (Permissions.canUseViolations(betas)) {

App/src/libs/actions/IOU.ts

Line 1688 in da24e9a

if (Permissions.canUseViolations(betas)) {

App/src/libs/actions/IOU.ts

Line 5389 in da24e9a

if (Permissions.canUseViolations(betas)) {

Example:

This would be changed to:

optimisticData.push({
    onyxMethod: Onyx.METHOD.SET,
    key: `${ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS}${transactionID}`,
    value: null,
});

This would be changed to:

rightLabel={isCategoryRequired ? translate('common.required') : ''}

cead22 · 2024-07-08T18:48:45Z

I'll update the solution in the issue description, but please include all the places in the code we need to update in your proposal

ShridharGoel · 2024-07-08T19:03:11Z

@cead22 Updated.

cead22 · 2024-07-09T18:00:06Z

@getusha any thoughts on that proposal?

getusha · 2024-07-09T21:55:42Z

The task looks pretty straightforward to me. the main part seems to be the testing. we can proceed with @ShridharGoel
I am assuming there aren't other beta futures like #43864 under violations beta
🎀 👀 🎀 C+ Reviewed.

melvin-bot · 2024-07-09T21:55:52Z

Current assignee @cead22 is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

cead22 · 2024-07-10T18:11:14Z

Correct, we can leave that and other betas alone and focus on the violations one

melvin-bot · 2024-07-10T18:11:33Z

📣 @ShridharGoel 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

ShridharGoel · 2024-07-15T14:36:33Z

Will open PR within a few days (once all test steps get completed).

cead22 · 2024-07-15T15:49:06Z

Thanks, let me know if I can help!

cead22 · 2024-07-16T18:22:46Z

@ShridharGoel how is the PR coming along? anything I can do to help?

ShridharGoel · 2024-07-17T13:11:41Z

@cead22 Will open the PR soon. I was travelling yesterday, it got a bit delayed.

ShridharGoel · 2024-07-17T17:58:28Z

@cead22 The "Missing category" and "Missing tag" messages are not shown when a receipt is scanning. Is that expected?

cead22 · 2024-07-17T18:00:10Z

Yes

cead22 · 2024-07-22T23:01:30Z

Yes probably. Which ones are failing?

ShridharGoel · 2024-07-23T14:41:44Z

@cead22 Verify you see “Receipt * Issue found 🔴” above the receipt when changing amount.

ShridharGoel · 2024-07-23T14:42:08Z

Import a third party domain control card via OldDot

Can you share some insights on how to do this?

cead22 · 2024-07-23T16:52:25Z

I will, let me make sure I can get the steps right. Is this the last thing blocking you from submitting the PR for review? If so, let's get started on the review and we can worry about that test later

ShridharGoel · 2024-07-23T19:01:56Z

@getusha I think the PR can be reviewed while I'm working on completing the videos for all platforms.

ShridharGoel · 2024-07-29T10:28:08Z

Update: PR is awaiting review.

melvin-bot · 2024-08-12T09:54:54Z

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot · 2024-08-12T09:54:59Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.18-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Take violations out of beta #45760

If no regressions arise, payment will be issued on 2024-08-19. 🎊

For reference, here are some details about the assignees on this issue:

@ShridharGoel requires payment automatic offer (Contributor)
@getusha requires payment through NewDot Manual Requests

JmillsExpensify · 2024-08-19T21:22:26Z

Payment summary:

Contributor: @ShridharGoel $750
Reviewer: @getusha $750

@getusha I vaguely remember that as part of this issue we'd add a series of new regression tests, is that right or did I misremember that part?

cead22 · 2024-08-20T15:33:21Z

@getusha I vaguely remember that as part of this issue we'd add a series of new regression tests, is that right or did I misremember that part?

They're the ones at the top of this issue, which should be the same as these ones shared in #qa

JmillsExpensify · 2024-08-20T17:10:05Z

Nice thanks for clarifying. Contributor is paid out via Upwork. @getusha Please submit a request via Newdot and we'll get that processed.

mallenexpensify · 2024-08-22T18:36:50Z

Contributor: @ShridharGoel paid $750 via Upwork
Contributor+: @getusha owed $750 via NewDot

Do we want a test case for/from this issue specifically or is that being covered more holistically as part of a project?

JmillsExpensify · 2024-08-22T20:19:34Z

$750 approved for @getusha

cead22 added External Added to denote the issue can be worked on by a contributor Daily KSv2 Improvement Item broken or needs improvement. labels Jul 8, 2024

cead22 self-assigned this Jul 8, 2024

cead22 added this to [#whatsnext] #expense Jul 8, 2024

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 8, 2024

melvin-bot bot assigned getusha Jul 8, 2024

JmillsExpensify moved this to Polish in [#whatsnext] #expense Jul 8, 2024

JmillsExpensify self-assigned this Jul 8, 2024

cead22 assigned ShridharGoel Jul 10, 2024

melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 10, 2024

melvin-bot bot added the Overdue label Jul 15, 2024

melvin-bot bot removed the Overdue label Jul 15, 2024

ShridharGoel mentioned this issue Jul 19, 2024

Take violations out of beta #45760

Merged

48 tasks

melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Jul 23, 2024

lanitochka17 mentioned this issue Aug 8, 2024

[HOLD for payment 2024-09-26][$250] Violations - "Receipt required" error message is missing from the expense details #47105

Closed

6 tasks

izarutskaya mentioned this issue Aug 8, 2024

Receipt Scan - No “Receipt * Issue found' when change the amount of the card transaction #47112

Closed

6 tasks

IuliiaHerets mentioned this issue Aug 8, 2024

[$250] Web - Dependent tag choices are cleared and actions are repeated when coming online #47113

Closed

6 tasks

izarutskaya mentioned this issue Aug 9, 2024

[$250] Expense-Skeleton shown below header after creating expense with violations offline #47152

Closed

6 tasks

IuliiaHerets mentioned this issue Aug 9, 2024

Web - Violations - Missing tag instead of Review required shown on expense preview if depende #47154

Closed

6 tasks

melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Aug 12, 2024

melvin-bot bot changed the title ~~[$750] [Violations] Remove violations beta from front-end~~ [HOLD for payment 2024-08-19] [$750] [Violations] Remove violations beta from front-end Aug 12, 2024

melvin-bot bot removed the Reviewing Has a PR in review label Aug 12, 2024

melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Aug 18, 2024

JmillsExpensify closed this as completed Aug 20, 2024

github-project-automation bot moved this from Polish to Done in [#whatsnext] #expense Aug 20, 2024

rayane-d mentioned this issue Sep 23, 2024

[HOLD] [$250] Tags-Deselecting state tag shows state no longer valid error #49504

Open

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HOLD for payment 2024-08-19] [$750] [Violations] Remove violations beta from front-end #44995

[HOLD for payment 2024-08-19] [$750] [Violations] Remove violations beta from front-end #44995

cead22 commented Jul 8, 2024 •

edited by melvin-bot bot

Loading

melvin-bot bot commented Jul 8, 2024

melvin-bot bot commented Jul 8, 2024

ShridharGoel commented Jul 8, 2024 •

edited

Loading

cead22 commented Jul 8, 2024

ShridharGoel commented Jul 8, 2024

cead22 commented Jul 9, 2024

getusha commented Jul 9, 2024

melvin-bot bot commented Jul 9, 2024

cead22 commented Jul 10, 2024

melvin-bot bot commented Jul 10, 2024

ShridharGoel commented Jul 15, 2024

cead22 commented Jul 15, 2024

cead22 commented Jul 16, 2024

ShridharGoel commented Jul 17, 2024

ShridharGoel commented Jul 17, 2024

cead22 commented Jul 17, 2024

cead22 commented Jul 22, 2024

ShridharGoel commented Jul 23, 2024

ShridharGoel commented Jul 23, 2024

cead22 commented Jul 23, 2024

ShridharGoel commented Jul 23, 2024

ShridharGoel commented Jul 29, 2024

melvin-bot bot commented Aug 12, 2024

melvin-bot bot commented Aug 12, 2024

JmillsExpensify commented Aug 19, 2024

cead22 commented Aug 20, 2024

JmillsExpensify commented Aug 20, 2024

mallenexpensify commented Aug 22, 2024

JmillsExpensify commented Aug 22, 2024

[HOLD for payment 2024-08-19] [$750] [Violations] Remove violations beta from front-end #44995

[HOLD for payment 2024-08-19] [$750] [Violations] Remove violations beta from front-end #44995

Comments

cead22 commented Jul 8, 2024 • edited by melvin-bot bot Loading

Problem

Solution

Tests

Pre-testing steps

Important Notes

Missing tag and missing category violations

Manual Request

Scan Request

Distance Request

Category out of policy, tag out of policy violation, expense over limit, max age, over category limit, receipt required

Manual Request

Scan Request

Distance Request

Tag violations on workspace with Independent Tags (multi-level tags)

Manual Request

Tag violations on workspace with Dependent Tags (multi-level tags)

Manual Request

Receipt Audit Scan

Receipt Audit Distance

Receipt Audit - Receipt Not Verified

melvin-bot bot commented Jul 8, 2024

melvin-bot bot commented Jul 8, 2024

ShridharGoel commented Jul 8, 2024 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

cead22 commented Jul 8, 2024

ShridharGoel commented Jul 8, 2024

cead22 commented Jul 9, 2024

getusha commented Jul 9, 2024

melvin-bot bot commented Jul 9, 2024

cead22 commented Jul 10, 2024

melvin-bot bot commented Jul 10, 2024

ShridharGoel commented Jul 15, 2024

cead22 commented Jul 15, 2024

cead22 commented Jul 16, 2024

ShridharGoel commented Jul 17, 2024

ShridharGoel commented Jul 17, 2024

cead22 commented Jul 17, 2024

cead22 commented Jul 22, 2024

ShridharGoel commented Jul 23, 2024

ShridharGoel commented Jul 23, 2024

cead22 commented Jul 23, 2024

ShridharGoel commented Jul 23, 2024

ShridharGoel commented Jul 29, 2024

melvin-bot bot commented Aug 12, 2024

melvin-bot bot commented Aug 12, 2024

JmillsExpensify commented Aug 19, 2024

cead22 commented Aug 20, 2024

JmillsExpensify commented Aug 20, 2024

mallenexpensify commented Aug 22, 2024

JmillsExpensify commented Aug 22, 2024

cead22 commented Jul 8, 2024 •

edited by melvin-bot bot

Loading

ShridharGoel commented Jul 8, 2024 •

edited

Loading