Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOU - Title change is not reflected in header and details section #44962

Closed
5 of 6 tasks
izarutskaya opened this issue Jul 8, 2024 · 12 comments
Closed
5 of 6 tasks

IOU - Title change is not reflected in header and details section #44962

izarutskaya opened this issue Jul 8, 2024 · 12 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Reviewing Has a PR in review Weekly KSv2

Comments

@izarutskaya
Copy link

izarutskaya commented Jul 8, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: v9.0.5-3
Reproducible in staging?: Y
Reproducible in production?: New feature
Email or phone of affected tester (no customers): [email protected]
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

  1. Navigate to p2p chat
  2. Submit a manual expense
  3. Click on the IOU preview component
  4. Click on report header > Title
  5. Edit title & click Save

Expected Result:

Change in title should be reflected in report header and details section

Actual Result:

Change in title is not reflected in report header and details section

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6535804_1720442344045.Screen_Recording_2024-07-08_at_3.03.24_in_the_afternoon.mp4

View all open jobs on GitHub

@izarutskaya izarutskaya added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API labels Jul 8, 2024
Copy link

melvin-bot bot commented Jul 8, 2024

Triggered auto assignment to @dangrous (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Jul 8, 2024

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Jul 8, 2024
Copy link
Contributor

github-actions bot commented Jul 8, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@izarutskaya
Copy link
Author

@anmurali I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

@izarutskaya
Copy link
Author

We think this issue might be related to the #collect project.

@ishpaul777
Copy link
Contributor

ishpaul777 commented Jul 8, 2024

I think Title field should not editable in P2P chat. i'll raise a quick PR to resolve this since this comes from a PR i reviewed, once we confirm

cc @trjExpensify

@ishpaul777
Copy link
Contributor

ishpaul777 commented Jul 8, 2024

Above is a draft PR i'll open once confirmed above ^

@trjExpensify
Copy link
Contributor

I think Title field should not editable in P2P chat. i'll raise a quick PR to resolve this since this comes from a PR i reviewed, once we confirm

Right, report titles are a feature on workspaces whereas iouReports are not on workspaces.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Hourly KSv2 labels Jul 9, 2024
@danieldoglas danieldoglas removed the DeployBlocker Indicates it should block deploying the API label Jul 9, 2024
@danieldoglas
Copy link
Contributor

removing backend blocker on this issue.

@ishpaul777
Copy link
Contributor

i have opened PR for review #44978

@Julesssss
Copy link
Contributor

We'll continue with the PR as it does resolve the issue. But as far as I can tell, edit is a new feature and should not be blocking deploy:

Prod:
Screenshot 2024-07-09 at 13 56 01

Staging:
Screenshot 2024-07-09 at 13 57 39

@Julesssss Julesssss removed the DeployBlockerCash This issue or pull request should block deployment label Jul 9, 2024
@Julesssss
Copy link
Contributor

Julesssss commented Jul 9, 2024

Ah, this appears to have been resolved by a different deploy blocker fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

7 participants