[HOLD for payment 2024-07-26] [$250] Send invoice - "Choose a payment method" disappears after returning from Pay elsewhere page

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.4-0
Reproducible in staging?: Y
Reproducible in production?: Y
Found when validating PR : #43036
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Go to staging.new.expensify.com
2. [User A] Send an invoice to user B.
3. [User B] Go to invoice chat.
4. [User B] Click Pay button.
5. [User B] Click Pay as individual or Pay as business.
6. [User B] Click on the back button.

Expected Result:

"Choose a payment method below" in the payment method selection page will persist.

Actual Result:

"Choose a payment method below" in the payment method selection page disappears.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6532611_1720055363822.20240704_090314.1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ace2c2d5df911f17
• Upwork Job ID: 1809200291724480759
• Last Price Increase: 2024-07-05
• Automatic offers:
• cretadn22 | Contributor | 103046339

Issue Owner

Current Issue Owner: @sonialiap

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[izarutskaya]

We think this issue might be related to the #vip-bills.

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

"Choose a payment method below" in the payment method selection page disappears.

What is the root cause of that problem?

We don't use setState when click back button in

App/src/components/PopoverMenu.tsx

Line 159 in 6ac95e4

enteredSubMenuIndexes.splice(-1);

so state enteredSubMenuIndexes is not updated and popover isn't rendered again

What changes do you think we should make in order to solve the problem?

We should create a function renderHeader() and it'll update header everytime enteredSubMenuIndexes changes

    const renderHeader = () => {
        if(!headerText || enteredSubMenuIndexes.length > 0) {
            return;
        }
        return <Text style={[styles.createMenuHeaderText, styles.ph5, styles.pv3]}>{headerText}</Text>
    }

What alternative solutions did you explore? (Optional)

Using setState in this case

setEnteredSubMenuIndexes((prevState) => prevState.splice(-1)) 

[cretadn22]

Proposal

Please re-state the problem that we are trying to solve in this issue.

"Choose a payment method" disappears after returning from Pay elsewhere page

What is the root cause of that problem?

We update enteredSubMenuIndexes state directly

App/src/components/PopoverMenu.tsx

Line 159 in 6ac95e4

enteredSubMenuIndexes.splice(-1);

What changes do you think we should make in order to solve the problem?

Need to utilize setState to adjust the state value

App/src/components/PopoverMenu.tsx

Line 159 in 6ac95e4

enteredSubMenuIndexes.splice(-1);

setEnteredSubMenuIndexes((prevState) => prevState.slice(0, -1)) 

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01ace2c2d5df911f17

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

[Abdelrahman286]

it would be better if you explain with voice

[melvin-bot]

📣 @Abdelrahman286! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[mollfpr]

@cretadn22 What's the advantage of your solution to use slice instead of splice?

[cretadn22]

@mollfpr The bug occurs because we modify the state directly instead of using setState

App/src/components/PopoverMenu.tsx

Line 159 in 6ac95e4

enteredSubMenuIndexes.splice(-1);

This logic will delete the final element from enteredSubMenuIndexes

splice(-1) will remove the last element in the original array and return the last element

[mollfpr]

Thanks @cretadn22 it seems to make sense to use slice instead because it returned the copied array.

The proposal from @cretadn22 looks good to me!

🎀 👀 🎀 C+ reviewed!

[melvin-bot]

Triggered auto assignment to @techievivek, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @cretadn22 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[mollfpr]

@cretadn22 I don't know why you laughing at my comment 🥲

This idea was mine first. Please check the history of their proposal

Also, I'm not sure which part you mean is your idea. What I'm pointing out is this snippet from your PR.

    const renderHeaderText = () => {
        if (!headerText || enteredSubMenuIndexes.length !== 0) {
            return;
        }
        return <Text style={[styles.createMenuHeaderText, styles.ph5, styles.pv3]}>{headerText}</Text>;
    };

Here's the history from the @daledah proposal.

[cretadn22]

@mollfpr Sorry, I misunderstand your mean. I didn't expect this coincidence 😄

[cretadn22]

I don't know why you laughing at my comment 🥲

I don't mean anything, don't mind

[mollfpr]

I don't mean anything, don't mind

@cretadn22 No worries, I'm just joking with you 😄

[techievivek]

@mollfpr so are we going with another PR here since the original changes got reverted? Or did we implement the solution somewhere else?

[cretadn22]

@techievivek My PR fixed this issue. We don't need to create a new PR

[cretadn22]

While working on the pull request, I encountered #45178 (comment) that caused the native app to crash. I dedicated considerable effort to investigating and fixing this issue in order to proceed with the pull request by using #45178 (comment).

The fixing for additional bug also resolve this issue 😄 , (detail here)

[techievivek]

#45178 fixed this issue. We don't need to create a new PR

Aaah, I see now, @mollfpr referred to a different PR by a different contributor.

[techievivek]

I think we can partially compensate @daledah(since their solution was used in the fix) and @cretadn22(they created the PR and helped fix another bug). I will let @sonialiap take a look into it. Thanks.

[mollfpr]

[@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
[@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

No offending PR was found.

[@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

The regression step should be good!

[@mollfpr] Determine if we should create a regression test for this bug.
[@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

1. [User A] Send an invoice to user B.
2. [User B] Go to invoice chat.
3. [User B] Click the Pay button.
4. [User B] Click Pay as individual
5. [User B] Click on the back button
6. Verify "Choose a payment method below" in the payment method selection page will persist
7. 👍 or 👎

[techievivek]

Looks good to me, @sonialiap can we please get this added to testRail, thanks.

[melvin-bot]

@sonialiap, @mollfpr, @techievivek, @cretadn22 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[JmillsExpensify]

@sonialiap please add a payment summary when you get a chance.

[sonialiap]

Since it seems like there was extra work put into this, I'm increasing the base price to $500

Payment summary:

• @daledah $250 for the proposal - offer sent in Upwork - paid in Upwork ✔️
• @cretadn22 $500 for the fix - paid in Upwork ✔️
• @mollfpr $500 for the c+ - please request in ND

Does this sound fair to everyone?

[JmillsExpensify]

$500 approved for @mollfpr

[cretadn22]

@JmillsExpensify @sonialiap Could you please approve my offer?

[daledah]

@sonialiap Sounds good to me thanks, could you send the offer to my UW profile here? https://www.upwork.com/freelancers/~0138d999529f34d33f

[sonialiap]

@daledah thanks for the upwork link! Offer sent 💃

[daledah]

@sonialiap Accepted the offer thx

[sonialiap]

Everyone has been paid ✔️