[HOLD for payment 2024-07-24] [HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [CRITICAL] [$250] Comment link - Navigating to a report action comment doesn't scroll the report page

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.3-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Navigate to staging.new.expensify.com
2. Open a chat with a user and send a lot of comments so that there is a scrollable history
3. Go to the top comment and copy the link to that comment
4. Open another chat and navigate to the copied link

Expected Result:

The chat page scrolls to that specific comment

Actual Result:

The report page opens up but doesn't scroll to the specific comment

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6527366_1719577792343.bandicam_2024-06-28_15-24-59-313.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~016eb6bedcd3171adc
• Upwork Job ID: 1808449293455136963
• Last Price Increase: 2024-07-03

Issue Owner

Current Issue Owner: @slafortune

[melvin-bot]

Triggered auto assignment to @bondydaa (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

@bondydaa FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-vsp

[bondydaa]

i'm pretty sure if this only happens on web then it's most likely an app thing and not a web deploy problem.

[srikarparsi]

Hey @nkdengineer and @mollfpr, could you take a look if this regression is from this PR whenever you have a chance?

[bondydaa]

☝️. that PR is the only one that stood out to me from the checklist that looks like it might be related to comment linking in some way so i'd ping'd srikar 1:1.

[nkdengineer]

@srikarparsi I tried to revert my PR and it doesn't fix this issue. Correct me if I missed something.

[Kicu]

Just two cents from me (im the author of the react PR)

In the network tab of the developer tools, the OpenReport API request is being called twice, when opening a report.

as long as we are using StrictMode to try and prevent any possible future errors with react concurrent, the double requests will keep happening. That is how strict mode is supposed to work.

At least in theory we should try to make the app work despite the double renders.

[jasperhuangg]

Offending PR: #42592

The ReportScreen gets mounted, unmounted, mounted, unmounted, and then mounted again.

In the network tab of the developer tools, the OpenReport API request is being called twice, when opening a report.

@tsa321

Did you test this out with your local build of the App? I think the logic added in that PR only runs on dev builds, so since this is also happening on staging I don't think that's the cause.

[jasperhuangg]

@Kicu ^ please correct me if I'm wrong 🙇

[tsa321]

@tsa321

Did you test this out with your local build of the App? I think the logic added in that PR only runs on dev builds, so since this is also happening on staging I don't think that's the cause.

@jasperhuangg you are right, Looks like I made a mistake.

[jasperhuangg]

Can't reproduce this anymore after reverting #44412

~~cc @roryabraham ~~

EDIT: Made a mistake, the page still scrolls but just not all the way that's not related

[Kicu]

@Kicu ^ please correct me if I'm wrong 🙇

You are correct I believe. Staging should run production build of React and so if an error happens both on dev and on staging it shouldn't be because of StrictMode.

Btw I didn't check the actual build/deploy scripts, but if one opens react performance devtools on staging they don't work, with the message that a dev build is required. I hope that is enough of a confirmation 😅

[bondydaa]

hm so i tested on staging and it links me to the correct comment and highlights it but it is more "bottom pinned" where the comment loads at the very bottom instead of the top.

2024-07-02_09-30-21.mp4

[bondydaa]

okay a couple more cases here...

this is a case where you link to the top most comment when you have enough to make the page scrollable which won't scroll back up

2024-07-02_09-36-18.mp4

And then this case shows where you have more messages below the linked comment and the linked comment gets "bottom pinned" and can't be scrolled until you click new messages which loads more messages underneath them.

2024-07-02_09-38-34.mp4

[ishpaul777]

shows where you have more messages below the linked comment and the linked comment gets "bottom pinned" and can't be scrolled until you click new messages which loads more messages underneath them.

this seems to be similar to #40644 should be fixed in #41962

[janicduplessis]

I wasn't aware of this issue, ended up investigating as part of the issues we found when working on #41962

#45313 fixes it.

I'm pretty sure this is a dev only issue since it happens only when strict mode is on so it would explain why it is not reproducible on staging.

[jasperhuangg]

@janicduplessis we were able to reliably reproduce the issue on staging when we initially ran into it–I don't think it has to do with strict mode.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.6-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: list not scrolling to the linked report action #44819

If no regressions arise, payment will be issued on 2024-07-22. 🎊

For reference, here are some details about the assignees on this issue:

• @rayane-djouah requires payment (Needs manual offer from BZ)

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[bondydaa]

adding BZ for payment, I think just @rayane-djouah for PR reviewing/testing right?

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.7-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix web maintainVisibleContentPosition with strict mode enabled #45313

If no regressions arise, payment will be issued on 2024-07-24. 🎊

For reference, here are some details about the assignees on this issue:

• @rayane-djouah requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rayane-djouah] The PR that introduced the bug has been identified. Link to the PR:
• [@rayane-djouah] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@rayane-djouah] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@rayane-djouah] Determine if we should create a regression test for this bug.
• [@rayane-djouah] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@slafortune] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[slafortune]

@rayane-djouah - offer sent here

Can you please complete the checklist?

[rayane-djouah]

• The PR that introduced the bug has been identified. Link to the PR: Fix deep linking to reports after signing in #43307
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/43307/files#r1685456779
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• Determine if we should create a regression test for this bug. There is already a regression test for this.
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A

[rayane-djouah]

@slafortune - Offer accepted and checklist completed. Thanks!

[slafortune]

Paid ✅