Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Chat - Badge 'New messages' disappears after returning to the chat from thread #44535

Closed
2 of 6 tasks
izarutskaya opened this issue Jun 27, 2024 · 15 comments
Closed
2 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@izarutskaya
Copy link

izarutskaya commented Jun 27, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.2-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4676291
Email or phone of affected tester (no customers): [email protected]
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

  1. Open iOS/iPad or Android App
  2. Login with any account
  3. Got to any chat with long history
  4. Mark the latest message as unread
  5. Scroll up the chat history, long-tap on any message and tap to 'Reply in thread'
  6. Go back from thread to the main chat history

Expected Result:

The badge 'New Messages' is present at the top of the screen

Actual Result:

The badge 'New messages' disappears after returning to the chat history from the thread

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native/ iPad
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6525813_1719444944828.iPad-New-messages-badge-disappear-after-back-from-thread.mp4
Bug6525813_1719444944822.iOS-New-messages-badge-disappear-after-back-from-thread.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01701df429333bf5ee
  • Upwork Job ID: 1806345990119579428
  • Last Price Increase: 2024-07-04
Issue OwnerCurrent Issue Owner: @fedirjh
@izarutskaya izarutskaya added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API labels Jun 27, 2024
Copy link

melvin-bot bot commented Jun 27, 2024

Triggered auto assignment to @youssef-lr (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Jun 27, 2024

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Jun 27, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@izarutskaya
Copy link
Author

@zanyrenney I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

@izarutskaya
Copy link
Author

We think this issue might be related to the #vip-vsb

@mountiny mountiny added External Added to denote the issue can be worked on by a contributor and removed DeployBlocker Indicates it should block deploying the API labels Jun 27, 2024
@melvin-bot melvin-bot bot changed the title Chat - Badge 'New messages' disappears after returning to the chat from thread [$250] Chat - Badge 'New messages' disappears after returning to the chat from thread Jun 27, 2024
Copy link

melvin-bot bot commented Jun 27, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01701df429333bf5ee

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jun 27, 2024
Copy link

melvin-bot bot commented Jun 27, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

@mountiny mountiny added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Jun 27, 2024
@mountiny
Copy link
Contributor

I think this is kinda fixed on the latest 9.0.2-5. You can see the badge does not show up immediately but the unread line is there and as you scroll the badge shows up.

RPReplay_Final1719509520.mp4

I think we can demote and retest and see if we need to update the OP @kavimuru @izarutskaya

Copy link

melvin-bot bot commented Jul 2, 2024

@youssef-lr, @fedirjh, @zanyrenney Huh... This is 4 days overdue. Who can take care of this?

@melvin-bot melvin-bot bot added the Overdue label Jul 2, 2024
@zanyrenney
Copy link
Contributor

Nice, thanks @mountiny <3

Copy link

melvin-bot bot commented Jul 4, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

Copy link

melvin-bot bot commented Jul 4, 2024

@youssef-lr, @fedirjh, @zanyrenney Still overdue 6 days?! Let's take care of this!

Copy link

melvin-bot bot commented Jul 8, 2024

@youssef-lr, @fedirjh, @zanyrenney 10 days overdue. I'm getting more depressed than Marvin.

@zanyrenney
Copy link
Contributor

retesting!

@zanyrenney
Copy link
Contributor

Can no longer repro, given then comment above from Vit, i think we should be good to close this one.

@melvin-bot melvin-bot bot removed the Overdue label Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests

5 participants