Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-07-10] [$250] Chat - 1:1 DM refreshes itself, composer + action menu closes #44498

Closed
2 of 6 tasks
m-natarajan opened this issue Jun 26, 2024 · 19 comments
Closed
2 of 6 tasks
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Weekly KSv2

Comments

@m-natarajan
Copy link

m-natarajan commented Jun 26, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Bug was found when validating #43307
Version Number: 9.0.2-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

  1. Open the app
  2. Log in with a new Gmail account
  3. Tap on FAB - Start chat
  4. Enter a Gmail address that doesn't have an account yet
  5. Tap on the account
  6. Tap on the "+" button next to the composer

Expected Result:

I should be able to use the + menu and the chat shouldn't refresh itself.

Actual Result:

Chat - 1:1 DM resreshes itself for a few times after opening. Composer + action menu closes and the chat starts refreshing again. The menu is inaccessible.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6524795_1719377257496.az_recorder_20240626_063343.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0129f8c701589e31b8
  • Upwork Job ID: 1806096676893409978
  • Last Price Increase: 2024-06-26
Issue OwnerCurrent Issue Owner: @Christinadobrzyn
@m-natarajan m-natarajan added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API labels Jun 26, 2024
Copy link

melvin-bot bot commented Jun 26, 2024

Triggered auto assignment to @roryabraham (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Jun 26, 2024

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@m-natarajan
Copy link
Author

@Christinadobrzyn FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@m-natarajan
Copy link
Author

We think that this bug might be related to #vip-vsb

@Christinadobrzyn
Copy link
Contributor

@arosiclair @roryabraham @c3024 - can you double-check if this relates to #43307

@Christinadobrzyn
Copy link
Contributor

I'm able to reproduce the bug in the OP

screenRecording-26-6-2024-16-5.mp4

@yuwenmemon yuwenmemon added External Added to denote the issue can be worked on by a contributor and removed DeployBlocker Indicates it should block deploying the API labels Jun 26, 2024
Copy link

melvin-bot bot commented Jun 26, 2024

Job added to Upwork: https://www.upwork.com/jobs/~0129f8c701589e31b8

@melvin-bot melvin-bot bot changed the title Chat - 1:1 DM refreshes itself, composer + action menu closes [$250] Chat - 1:1 DM refreshes itself, composer + action menu closes Jun 26, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jun 26, 2024
Copy link

melvin-bot bot commented Jun 26, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (External)

@pecanoro
Copy link
Contributor

I am not sure if it's the same RCA, but I am getting something similar and I can't send any messages at all: https://expensify.slack.com/archives/C049HHMV9SM/p1719413599651529

Copy link

melvin-bot bot commented Jun 27, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@Christinadobrzyn
Copy link
Contributor

Asking if this is the same as #44419

@arosiclair
Copy link
Contributor

arosiclair commented Jun 27, 2024

Looks like we're fixing this here: #44544
Slack thread: https://expensify.slack.com/archives/C049HHMV9SM/p1719475873244049

@mountiny
Copy link
Contributor

confirmed its fixed by #44544 gonna add it to the list of issue it fixes

@mountiny mountiny added Reviewing Has a PR in review and removed DeployBlockerCash This issue or pull request should block deployment labels Jun 27, 2024
@mountiny
Copy link
Contributor

CPed to staging, confirmed this is fixed 🎉

RPReplay_Final1719507460.mp4

@mountiny mountiny added Daily KSv2 and removed Hourly KSv2 Help Wanted Apply this label when an issue is open to proposals by contributors labels Jun 27, 2024
@mountiny
Copy link
Contributor

We will handle C+ payment on the other linked issue, we can close this one now

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels Jul 3, 2024
@melvin-bot melvin-bot bot changed the title [$250] Chat - 1:1 DM refreshes itself, composer + action menu closes [HOLD for payment 2024-07-10] [$250] Chat - 1:1 DM refreshes itself, composer + action menu closes Jul 3, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jul 3, 2024
Copy link

melvin-bot bot commented Jul 3, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Jul 3, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-07-10. 🎊

For reference, here are some details about the assignees on this issue:

  • @getusha requires payment through NewDot Manual Requests

Copy link

melvin-bot bot commented Jul 3, 2024

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@getusha] The PR that introduced the bug has been identified. Link to the PR:
  • [@getusha] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • [@getusha] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • [@getusha] Determine if we should create a regression test for this bug.
  • [@getusha] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • [@Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Weekly KSv2
Projects
None yet
Development

No branches or pull requests

8 participants